Skip to content

"Vibe-Trading: Your Personal Trading Agent"

fix(tools): reject inverted trade-journal date filters

santhreal159bffbef99f
diff --git a/agent/src/tools/trade_journal_tool.py b/agent/src/tools/trade_journal_tool.py
index 29abba903..95fca8549 100644
--- a/agent/src/tools/trade_journal_tool.py
+++ b/agent/src/tools/trade_journal_tool.py
@@ -389,10 +389,15 @@ def _apply_filter(df: pd.DataFrame, expr: str) -> pd.DataFrame:
if hi_month
else hi_base + pd.Timedelta(days=1)
)
- return df[(df["datetime"] >= lo) & (df["datetime"] < hi)]
+ except ValueError:
+ raise
except Exception as exc:
logger.warning("filter date parse failed: %s", exc)
return df
+ # Mirror alpha_bench _parse_period: reject inverted ranges.
+ if lo >= hi:
+ raise ValueError(f"inverted date filter: {expr!r}")
+ return df[(df["datetime"] >= lo) & (df["datetime"] < hi)]
if "=" in expr:
key, val = (p.strip() for p in expr.split("=", 1))
diff --git a/agent/tests/test_journal_inverted_date_filter.py b/agent/tests/test_journal_inverted_date_filter.py
new file mode 100644
index 000000000..9a4870e69
--- /dev/null
+++ b/agent/tests/test_journal_inverted_date_filter.py
@@ -0,0 +1,27 @@
+"""Inverted journal date filters must raise, not silently empty the frame."""
+
+from __future__ import annotations
+
+import pandas as pd
+import pytest
+
+from src.tools.trade_journal_tool import _apply_filter
+
+
+def _frame() -> pd.DataFrame:
+ return pd.DataFrame(
+ {
+ "datetime": pd.to_datetime(["2026-01-15", "2026-02-15", "2026-03-15"]),
+ "symbol": ["A", "A", "A"],
+ }
+ )
+
+
+def test_inverted_month_filter_raises() -> None:
+ with pytest.raises(ValueError, match="inverted date filter"):
+ _apply_filter(_frame(), "2026-03 to 2026-01")
+
+
+def test_normal_month_filter_keeps_rows() -> None:
+ out = _apply_filter(_frame(), "2026-01 to 2026-03")
+ assert len(out) == 2