"Vibe-Trading: Your Personal Trading Agent"
Python ai-agentalgorithmic-tradingbacktestingfintechllmmcpmulti-agentpythonquantitative-financetrading
fix(channels): thread message_id into IM outbound so QQ replies are passive (#1008)
Stephen Su2f23ce606378
diff --git a/agent/src/channels/runtime.py b/agent/src/channels/runtime.pyindex ede1f7d79..fbd6061bf 100644--- a/agent/src/channels/runtime.py+++ b/agent/src/channels/runtime.py@@ -136,7 +136,11 @@ class ChannelRuntime:"Not authorized: pairing management is restricted to ""configured operators."),- metadata={PAIRING_COMMAND_META_KEY: True, "unauthorized": True},+ metadata={+ PAIRING_COMMAND_META_KEY: True,+ "unauthorized": True,+ "message_id": msg.metadata.get("message_id"),+ },))return@@ -151,7 +155,10 @@ class ChannelRuntime:channel=msg.channel,chat_id=msg.chat_id,content=reply,- metadata={PAIRING_COMMAND_META_KEY: True},+ metadata={+ PAIRING_COMMAND_META_KEY: True,+ "message_id": msg.metadata.get("message_id"),+ },))return@@ -167,7 +174,11 @@ class ChannelRuntime:channel=msg.channel,chat_id=msg.chat_id,content=reply,- metadata={"_channel_runtime": True, "session_reset": True},+ metadata={+ "_channel_runtime": True,+ "session_reset": True,+ "message_id": msg.metadata.get("message_id"),+ },))return@@ -189,6 +200,11 @@ class ChannelRuntime:"_channel_runtime": True,"attempt_id": attempt_id,"session_id": session_id,+ # QQ (and other platforms) need the originating message id+ # to reply as a passive message; without it, replies are+ # treated as active messages and rejected for+ # non-privileged bots.+ "message_id": msg.metadata.get("message_id"),},))@@ -206,7 +222,11 @@ class ChannelRuntime:"Still working on your previous message — send this again ""once I reply, or use the reset command to start over."),- metadata={"_channel_runtime": True, "busy": True},+ metadata={+ "_channel_runtime": True,+ "busy": True,+ "message_id": msg.metadata.get("message_id"),+ },))except Exception as exc: # noqa: BLE001 - channel errors must surface to users@@ -216,7 +236,11 @@ class ChannelRuntime:channel=msg.channel,chat_id=msg.chat_id,content=f"Channel runtime error: {type(exc).__name__}: {exc}",- metadata={"_channel_runtime": True, "error": True},+ metadata={+ "_channel_runtime": True,+ "error": True,+ "message_id": msg.metadata.get("message_id"),+ },))diff --git a/agent/tests/test_channels_runtime.py b/agent/tests/test_channels_runtime.pyindex e8ec771bc..60d600632 100644--- a/agent/tests/test_channels_runtime.py+++ b/agent/tests/test_channels_runtime.py@@ -20,6 +20,7 @@ from src.channelsui.mcp_presets_api import normalize_mcp_preset_mentionsfrom src.channelsui.transcription_ws import webui_transcription_eventfrom src.session.goal_state import goal_state_ws_blobfrom src.session.models import Message, Session+from src.session.service import SessionBusyErrorfrom src.session.webui_turns import (clear_websocket_turn_started,mark_websocket_turn_started,@@ -265,6 +266,7 @@ def test_channel_runtime_routes_inbound_to_session_and_outbound(tmp_path: Path)sender_id="user-1",chat_id="chat-1",content="hello from IM",+ metadata={"message_id": "orig-msg-42"},))@@ -281,6 +283,10 @@ def test_channel_runtime_routes_inbound_to_session_and_outbound(tmp_path: Path)"_channel_runtime": True,"attempt_id": "attempt-1","session_id": "session-1",+ # The originating message id is threaded through so the QQ+ # adapter can send the reply as a passive message (msg_id)+ # instead of an active message QQ rejects for non-privileged bots.+ "message_id": "orig-msg-42",},)@@ -312,6 +318,7 @@ def test_channel_runtime_handles_pairing_commands_without_agent(tmp_path: Path,sender_id="owner",chat_id="chat-1",content="/PAIRING LIST",+ metadata={"message_id": "pairing-msg-1"},))outbound = await asyncio.wait_for(bus.consume_outbound(), timeout=1)@@ -323,6 +330,7 @@ def test_channel_runtime_handles_pairing_commands_without_agent(tmp_path: Path,assert outbound.chat_id == "chat-1"assert "No pending pairing requests" in outbound.contentassert outbound.metadata["_pairing_command"] is True+ assert outbound.metadata["message_id"] == "pairing-msg-1"asyncio.run(scenario())@@ -361,6 +369,7 @@ def test_channel_runtime_rejects_pairing_from_non_operator(sender_id="stranger",chat_id="chat-1",content=f"/pairing approve {code}",+ metadata={"message_id": "pairing-msg-2"},))outbound = await asyncio.wait_for(bus.consume_outbound(), timeout=1)@@ -369,6 +378,7 @@ def test_channel_runtime_rejects_pairing_from_non_operator(assert service.sent == []assert outbound.metadata.get("unauthorized") is True+ assert outbound.metadata["message_id"] == "pairing-msg-2"assert "Not authorized" in outbound.content# The code must NOT have been consumed by the rejected attempt.assert pairing.is_approved("signal", "victim-sender") is False@@ -649,7 +659,13 @@ def test_channel_runtime_new_command_with_no_existing_session(tmp_path: Path) ->await runtime.start(start_manager=False)try:await bus.publish_inbound(- InboundMessage(channel="telegram", sender_id="u1", chat_id="c1", content="/new")+ InboundMessage(+ channel="telegram",+ sender_id="u1",+ chat_id="c1",+ content="/new",+ metadata={"message_id": "reset-msg-1"},+ ))reply = await asyncio.wait_for(bus.consume_outbound(), timeout=1)finally:@@ -657,12 +673,65 @@ def test_channel_runtime_new_command_with_no_existing_session(tmp_path: Path) ->assert "No active session to reset" in reply.contentassert reply.metadata.get("session_reset") is True+ assert reply.metadata["message_id"] == "reset-msg-1"assert service.sent == []assert len(service.created) == 0asyncio.run(scenario())+ ("failure", "flag"),+ [+ (SessionBusyError("busy"), "busy"),+ (RuntimeError("boom"), "error"),+ ],+)+def test_channel_runtime_preserves_message_id_for_failure_replies(+ tmp_path: Path,+ failure: Exception,+ flag: str,+) -> None:+ async def scenario() -> None:+ from src.channels.runtime import ChannelRuntime++ bus = MessageBus()+ service = FakeSessionService()++ async def fail_send(*args: Any, **kwargs: Any) -> dict[str, str]:+ del args, kwargs+ raise failure++ service.send_message = fail_send # type: ignore[method-assign]+ runtime = ChannelRuntime(+ bus=bus,+ session_service=service,+ manager=None,+ session_map_path=tmp_path / "channel_sessions.json",+ reply_timeout_s=1,+ poll_interval_s=0.01,+ )+ await runtime.start(start_manager=False)+ try:+ await bus.publish_inbound(+ InboundMessage(+ channel="qq",+ sender_id="u1",+ chat_id="c1",+ content="hello",+ metadata={"message_id": "origin-msg-1"},+ )+ )+ reply = await asyncio.wait_for(bus.consume_outbound(), timeout=1)+ finally:+ await runtime.stop()++ assert reply.metadata[flag] is True+ assert reply.metadata["message_id"] == "origin-msg-1"++ asyncio.run(scenario())++def test_channel_runtime_reset_and_newsession_aliases_work(tmp_path: Path) -> None:async def scenario() -> None:from src.channels.runtime import ChannelRuntime