"Vibe-Trading: Your Personal Trading Agent"
Python ai-agentalgorithmic-tradingbacktestingfintechllmmcpmulti-agentpythonquantitative-financetrading
fix(factors): mask alpha101_049 output during undefined warmup and gaps
Lanre Shittu30935fe40891
diff --git a/agent/src/factors/zoo/alpha101/alpha_049.py b/agent/src/factors/zoo/alpha101/alpha_049.pyindex 17e8ed202..e57b700e0 100644--- a/agent/src/factors/zoo/alpha101/alpha_049.py+++ b/agent/src/factors/zoo/alpha101/alpha_049.py@@ -96,4 +96,9 @@ def compute(panel: dict) -> pd.DataFrame:x = ((delay(close, 20) - delay(close, 10)) / 10.0) - ((delay(close, 10) - close) / 10.0)one = make_one(close)out = where_ternary(x < -0.1, one, -1.0 * (close - delay(close, 1)))- return out+ # A NaN comparison is False, not NaN, so where_ternary's own+ # np.isfinite safety net never fires here: the else branch only needs+ # a 1-day delay and stays finite well before x's 20-day lookback is+ # available, fabricating a signal during the declared warmup instead+ # of NaN.+ return out.where(x.notna())diff --git a/agent/tests/factors/test_alpha101_alpha049_nan_propagation.py b/agent/tests/factors/test_alpha101_alpha049_nan_propagation.pynew file mode 100644index 000000000..28178776d--- /dev/null+++ b/agent/tests/factors/test_alpha101_alpha049_nan_propagation.py@@ -0,0 +1,71 @@+"""Regression: alpha101_049 must not fabricate a signal before its+declared warmup, and must propagate NaN through a data gap.++compute() picks a ternary via where_ternary(x < -0.1, 1, else_branch).+x needs delay(close, 20), so it is NaN for the first 20 rows. A NaN+comparison evaluates False, not NaN, so where_ternary always falls to+else_branch there, which only needs delay(close, 1) and is finite from+row 1 onward. The alpha's own np.isfinite safety net only catches a+non-finite output, not an output computed from an undefined condition,+so it does not fire. min_warmup_bars=21 declares the first 20 rows+unreliable, but compute() returned real-looking numbers for 19 of them.+"""++from __future__ import annotations++import numpy as np+import pandas as pd++from src.factors.registry import Registry++N_ROWS = 55+GAP_ROW = 25 # past min_warmup_bars=21, leaves room for +20 lookback+++def test_no_signal_before_declared_warmup():+ idx = pd.date_range("2024-01-01", periods=N_ROWS, freq="D")+ rng = np.random.default_rng(1)+ close = pd.DataFrame(+ 100.0 + np.cumsum(rng.normal(0.0, 1.0, size=(N_ROWS, 2)), axis=0),+ index=idx,+ columns=["SYM0", "SYM1"],+ )+ out = Registry().compute("alpha101_049", {"close": close})++ # x needs delay(close, 20): rows 0-19 (before the 21st bar) must stay+ # NaN, not a fabricated -1*(close-delay(close,1)) reading.+ warmup = out.iloc[:20]+ assert warmup.isna().all().all(), (+ f"alpha101_049: rows before min_warmup_bars must stay NaN, "+ f"got {warmup.stack().tolist()}"+ )+ assert (+ out.iloc[20:].notna().any().any()+ ), "alpha101_049: must produce real values once warmed up"+++def test_gap_stays_nan_not_fabricated():+ idx = pd.date_range("2024-01-01", periods=N_ROWS, freq="D")+ rng = np.random.default_rng(1)+ close = pd.DataFrame(+ 100.0 + np.cumsum(rng.normal(0.0, 1.0, size=(N_ROWS, 2)), axis=0),+ index=idx,+ columns=["SYM0", "SYM1"],+ )+ close.loc[idx[GAP_ROW], "SYM1"] = np.nan+ out = Registry().compute("alpha101_049", {"close": close})++ # The gap feeds x directly at the gap row, and via delay(10)/delay(20)+ # ten and twenty rows later.+ for offset in (0, 10, 20):+ row = GAP_ROW + offset+ assert pd.isna(out["SYM1"].iloc[row]), (+ f"alpha101_049: row {row} (gap + {offset}) must stay NaN, "+ f"got {out['SYM1'].iloc[row]!r}"+ )++ unaffected = out["SYM0"].iloc[20:]+ assert not unaffected.isna().any(), (+ "alpha101_049: a symbol with no gap must not pick up stray NaN "+ "from another symbol's column"+ )