Skip to content

"Vibe-Trading: Your Personal Trading Agent"

fix(quantlib): enforce the serialized result leaf budget

Rudy Celekli3e504d67c049
diff --git a/agent/src/tools/quantlib_tool.py b/agent/src/tools/quantlib_tool.py
index 241ed1715..544093e07 100644
--- a/agent/src/tools/quantlib_tool.py
+++ b/agent/src/tools/quantlib_tool.py
@@ -214,32 +214,50 @@ def _encode(value: Any, budget: _Budget) -> Any:
return value.value
if isinstance(value, (np.integer, np.floating, np.bool_)):
return _encode(value.item(), budget)
+
+ def sequence(values):
+ encoded = []
+ for item in values:
+ if budget.leaves >= _MAX_RESULT_LEAVES:
+ budget.truncated = True
+ break
+ encoded.append(_encode(item, budget))
+ return encoded
+
+ def mapping(items):
+ encoded = {}
+ for key, item in items:
+ if budget.leaves >= _MAX_RESULT_LEAVES:
+ budget.truncated = True
+ break
+ encoded[str(key)] = _encode(item, budget)
+ return encoded
+
if isinstance(value, np.ndarray):
- return [_encode(v, budget) for v in value.tolist()]
+ return sequence(value)
if isinstance(value, pd.Series):
return {
"__series__": {
- "index": [_encode(i, budget) for i in value.index.tolist()],
- "values": [_encode(v, budget) for v in value.tolist()],
+ "index": sequence(value.index),
+ "values": sequence(value),
}
}
if isinstance(value, pd.DataFrame):
return {
"__dataframe__": {
- "index": [_encode(i, budget) for i in value.index.tolist()],
- "columns": [str(c) for c in value.columns],
- "data": [[_encode(v, budget) for v in row] for row in value.to_numpy().tolist()],
+ "index": sequence(value.index),
+ "columns": sequence(str(c) for c in value.columns),
+ "data": sequence(value.itertuples(index=False, name=None)),
}
}
if dataclasses.is_dataclass(value) and not isinstance(value, type):
- return {
- f.name: _encode(getattr(value, f.name), budget)
- for f in dataclasses.fields(value)
- }
+ return mapping(
+ (f.name, getattr(value, f.name)) for f in dataclasses.fields(value)
+ )
if isinstance(value, dict):
- return {str(k): _encode(v, budget) for k, v in value.items()}
+ return mapping(value.items())
if isinstance(value, (list, tuple, set, frozenset)):
- return [_encode(v, budget) for v in value]
+ return sequence(value)
budget.leaves += 1
return str(value)
diff --git a/agent/tests/test_quantlib_result_budget.py b/agent/tests/test_quantlib_result_budget.py
new file mode 100644
index 000000000..f98f00eb1
--- /dev/null
+++ b/agent/tests/test_quantlib_result_budget.py
@@ -0,0 +1,110 @@
+"""The real quantlib consumer must bound its serialized result, not only numbers."""
+
+import json
+from dataclasses import dataclass
+
+import numpy as np
+import pandas as pd
+import pytest
+
+from src.tools.quantlib_tool import (
+ QuantlibCallTool,
+ _Budget,
+ _encode,
+ _MAX_RESULT_LEAVES,
+)
+
+
+def leaves(value):
+ if isinstance(value, dict):
+ return sum(leaves(v) for v in value.values())
+ if isinstance(value, list):
+ return sum(leaves(v) for v in value)
+ return 1
+
+
+def test_real_exported_monte_carlo_result_stays_within_budget():
+ result = json.loads(
+ QuantlibCallTool().execute(
+ action="call",
+ module="risk",
+ function="monte_carlo_gbm",
+ kwargs={
+ "s0": 100,
+ "mu": 0,
+ "sigma": 0,
+ "n_steps": 1,
+ "n_paths": 10000,
+ "seed": 7,
+ },
+ )
+ )
+ assert result["ok"] and result["truncated"]
+ assert leaves(result["result"]) <= _MAX_RESULT_LEAVES
+ assert all(row == [100, 100] for row in result["result"])
+ assert len(result["result"]) == _MAX_RESULT_LEAVES // 2
+
+
+ "value",
+ [
+ list(range(6000)),
+ np.arange(6000),
+ {str(i): i for i in range(6000)},
+ {"rows": [list(range(100)) for _ in range(100)]},
+ pd.Series(range(6000)),
+ pd.DataFrame({"a": range(6000), "b": range(6000)}),
+ ],
+)
+def test_every_container_stops_at_the_shared_budget(value):
+ budget = _Budget()
+ encoded = _encode(value, budget)
+ assert budget.truncated
+ assert leaves(encoded) <= _MAX_RESULT_LEAVES
+ assert budget.leaves == leaves(encoded)
+
+
+@dataclass
+class Summary:
+ count: int
+ values: list
+
+
+ "value,expected",
+ [
+ ([1, 2, 3], [1, 2, 3]),
+ (np.array([[1, 2], [3, 4]]), [[1, 2], [3, 4]]),
+ (
+ {"count": np.int64(2), "values": [np.float64(1.5), True]},
+ {"count": 2, "values": [1.5, True]},
+ ),
+ (Summary(2, [1, 2]), {"count": 2, "values": [1, 2]}),
+ (
+ pd.Series([1, 2], index=["a", "b"]),
+ {"__series__": {"index": ["a", "b"], "values": [1, 2]}},
+ ),
+ (
+ pd.DataFrame([[1, 2]], index=["x"], columns=["a", "b"]),
+ {
+ "__dataframe__": {
+ "index": ["x"],
+ "columns": ["a", "b"],
+ "data": [[1, 2]],
+ }
+ },
+ ),
+ ],
+)
+def test_small_results_keep_their_json_contract(value, expected):
+ budget = _Budget()
+ assert _encode(value, budget) == expected
+ assert not budget.truncated
+
+
+def test_exact_budget_is_not_reported_as_truncated():
+ budget = _Budget()
+ assert _encode(list(range(_MAX_RESULT_LEAVES)), budget) == list(
+ range(_MAX_RESULT_LEAVES)
+ )
+ assert not budget.truncated