Skip to content

"Vibe-Trading: Your Personal Trading Agent"

Merge PR #658

Haozhe Wu593dbe4f941d
diff --cc agent/tests/factors/test_bench_strict.py
index be5ca2f2e,60593dc5a..a42c428d8
--- a/agent/tests/factors/test_bench_strict.py
+++ b/agent/tests/factors/test_bench_strict.py
@@@ -156,11 -158,17 +158,22 @@@ def test_categorise_confirmed_alive_whe
assert categorise_strict(row) == "confirmed_alive"
+def test_categorise_rejects_oos_confirmation_when_training_fails() -> None:
+ row = _row(alpha_t_full=2.5, alpha_t_train=-1.0, alpha_t_test=4.0)
+ assert categorise_strict(row) == "noise"
+
+
+ def test_categorise_rejects_underpowered_oos_split() -> None:
+ row = _row(
+ alpha_t_full=3.0,
+ alpha_t_train=3.0,
+ alpha_t_test=3.0,
+ ic_count_train=58,
+ ic_count_test=2,
+ )
+ assert categorise_strict(row) == "noise"
+
+
def test_categorise_short_ic_count_is_noise() -> None:
# Below min_ic_count even strong t-stats are downgraded.
row = _row(alpha_t_full=10.0, ic_count=10)