Skip to content

"Vibe-Trading: Your Personal Trading Agent"

fix(metrics): compute drawdown from absolute peak on negative equity

santhreal6b1e438ccce2
diff --git a/agent/backtest/metrics.py b/agent/backtest/metrics.py
index 336359aaf..d7c8e13bf 100644
--- a/agent/backtest/metrics.py
+++ b/agent/backtest/metrics.py
@@ -507,7 +507,7 @@ def calc_metrics(
# Drawdown
peak = equity_curve.cummax()
- dd = (equity_curve - peak) / peak.replace(0, 1)
+ dd = (equity_curve - peak) / peak.abs().replace(0, 1)
max_dd = float(dd.min())
calmar = ann_ret / abs(max_dd) if abs(max_dd) > 1e-10 else 0.0
diff --git a/agent/tests/test_metrics.py b/agent/tests/test_metrics.py
index fddcbb4f3..b21101e70 100644
--- a/agent/tests/test_metrics.py
+++ b/agent/tests/test_metrics.py
@@ -427,6 +427,14 @@ class TestCalcMetrics:
if m["annual_return"] > 0:
assert m["calmar"] > 0
+ def test_calmar_and_drawdown_negative_equity(self) -> None:
+ """Negative equity curves must compute negative drawdown and non-zero Calmar, not zero."""
+ dates = pd.bdate_range("2025-01-01", periods=3)
+ eq = pd.Series([-20.0, -50.0, -100.0], index=dates)
+ m = calc_metrics(eq, [], 100.0, 252)
+ assert m["max_drawdown"] == pytest.approx(-4.0)
+ assert m["calmar"] < 0
+
def test_zero_final_equity(self) -> None:
"""A full wipeout (equity reaches 0) annualises to -100%, not a crash."""
dates = pd.bdate_range("2025-01-01", periods=252)