"Vibe-Trading: Your Personal Trading Agent"
Python ai-agentalgorithmic-tradingbacktestingfintechllmmcpmulti-agentpythonquantitative-financetrading
fix(governance): make archive ledger verification report corruption instead of crashing
Lanre Shittu77fc417e557f
diff --git a/agent/src/governance/ledger.py b/agent/src/governance/ledger.pyindex 8ece74049..41d1a6600 100644--- a/agent/src/governance/ledger.py+++ b/agent/src/governance/ledger.py@@ -662,6 +662,30 @@ def rotate_if_needed(return archive+def _iter_all_segment_lines(+ path: Path,+) -> Iterator[tuple[int, dict[str, Any] | None, str | None]]:+ """Like :func:`_iter_parsed_lines`, chained across every sealed segment and+ then the active file, with one continuous index over the concatenation.++ Delegates the actual parsing to :func:`_iter_parsed_lines` so a malformed+ line anywhere in the history is reported the same clean, structured way a+ single-file :func:`verify_chain` call already reports one -- rather than+ an uncaught ``json.JSONDecodeError`` escaping to the caller, which a+ from-scratch ``json.loads`` loop over the concatenated lines used to do.+ """+ offset = 0+ for segment in [*archive_segments(path), path]:+ if not segment.exists():+ continue+ lines = segment.read_text(encoding="utf-8").splitlines()+ for local_index, record, parse_error in _iter_parsed_lines(lines):+ yield offset + local_index, record, parse_error+ if parse_error is not None:+ return+ offset += len(lines)++def verify_chain_with_archives(path: Path) -> ChainVerificationResult:"""Verify a ledger's whole history, sealed segments included.@@ -678,61 +702,5 @@ def verify_chain_with_archives(path: Path) -> ChainVerificationResult:``index`` of a break is its position in that concatenation, not in anyone file."""- records: list[dict[str, Any]] = []- for segment in [*archive_segments(path), path]:- if not segment.exists():- continue- for line in segment.read_text(encoding="utf-8").splitlines():- if line.strip():- records.append(json.loads(line))-- if not records:- return ChainVerificationResult(ok=True, record_count=0, first_break=None)-- prev_hash = GENESIS_PREV_HASH- for index, record in enumerate(records):- expected_seq = index + 1- if record.get("seq") != expected_seq:- return ChainVerificationResult(- ok=False,- record_count=len(records),- first_break=ChainBreak(- index=index,- seq=record.get("seq"),- reason="seq_gap",- detail=f"expected seq={expected_seq}, found {record.get('seq')!r}",- ),- )- if record.get("prev_record_hash") != prev_hash:- return ChainVerificationResult(- ok=False,- record_count=len(records),- first_break=ChainBreak(- index=index,- seq=record.get("seq"),- reason="prev_hash_mismatch",- detail=(- f"expected prev_record_hash={prev_hash!r}, "- f"found {record.get('prev_record_hash')!r}"- ),- ),- )- payload = {- k: v for k, v in record.items()- if k not in ("seq", "prev_record_hash", "record_hash")- }- recomputed = compute_record_hash(record["seq"], record["prev_record_hash"], payload)- if recomputed != record.get("record_hash"):- return ChainVerificationResult(- ok=False,- record_count=len(records),- first_break=ChainBreak(- index=index,- seq=record.get("seq"),- reason="record_hash_mismatch",- detail=f"stored {record.get('record_hash')!r}, recomputed {recomputed!r}",- ),- )- prev_hash = record["record_hash"]-- return ChainVerificationResult(ok=True, record_count=len(records), first_break=None)+ result, _, _ = _walk_chain(_iter_all_segment_lines(path))+ return resultdiff --git a/agent/tests/test_governance.py b/agent/tests/test_governance.pyindex 1474705b6..c9dd44030 100644--- a/agent/tests/test_governance.py+++ b/agent/tests/test_governance.py@@ -740,6 +740,40 @@ def test_deleting_a_whole_sealed_segment_is_detected(tmp_path):assert result.first_break.reason == "seq_gap"+def test_a_malformed_line_in_a_sealed_segment_is_reported_not_raised(tmp_path):+ """verify_chain already reports malformed JSON as a clean ChainBreak+ instead of letting json.JSONDecodeError escape; the whole-history+ verifier must do the same for the exact same corruption, whether it+ lands in a sealed segment or the active file."""+ from src.governance.ledger import rotate_if_needed, verify_chain_with_archives++ led = tmp_path / "audit_chain.jsonl"+ for i in range(5):+ append_record(led, {"action": "order", "n": i})+ archive = rotate_if_needed(led, max_bytes=100)+ append_record(led, {"action": "order", "n": 5})++ with archive.open("a", encoding="utf-8") as handle:+ handle.write("{not valid json\n")++ result = verify_chain_with_archives(led)+ assert result.ok is False+ assert result.first_break.reason == "malformed_json"+++def test_a_malformed_line_in_the_active_file_is_reported_not_raised(tmp_path):+ from src.governance.ledger import verify_chain_with_archives++ led = tmp_path / "audit_chain.jsonl"+ append_record(led, {"action": "order", "n": 0})+ with led.open("a", encoding="utf-8") as handle:+ handle.write("{not valid json\n")++ result = verify_chain_with_archives(led)+ assert result.ok is False+ assert result.first_break.reason == "malformed_json"++def test_rotation_refuses_to_seal_a_corrupt_ledger(tmp_path):from src.governance.ledger import rotate_if_needed