Skip to content

"Vibe-Trading: Your Personal Trading Agent"

fix(events): preserve share-class dots in configured RSS routes

Rudy Celekli8beee6e680da
diff --git a/README.md b/README.md
index a1c21775f..309797865 100644
--- a/README.md
+++ b/README.md
@@ -2435,3 +2435,5 @@ The same flow is available from `vibe-trading provider custom list`,
`vibe-trading provider custom add --id example --label Example --base-url https://api.example.com/v1 --model example-model`
(the key is prompted privately), and `vibe-trading provider custom activate example`.
The configured provider is used by CLI, API, Web, and agent runs alike.
+
+RSSHub feed `code_style` transformations separate the final venue suffix from the ticker, preserving share-class dots: `BRK.B.US` becomes `BRK.B` for `bare` routes and `USBRK.B` for `exchange_prefix`; `raw` remains unchanged.
diff --git a/agent/backtest/loaders/rsshub_events.py b/agent/backtest/loaders/rsshub_events.py
index bd4015397..3eba8178c 100644
--- a/agent/backtest/loaders/rsshub_events.py
+++ b/agent/backtest/loaders/rsshub_events.py
@@ -21,7 +21,6 @@ judge, as the ``event-driven`` skill describes) to override it.
from __future__ import annotations
import logging
-import os
import time
from dataclasses import dataclass
from email.utils import parsedate_to_datetime
@@ -95,10 +94,16 @@ def format_code_for_route(code: str, style: str) -> str:
ValueError: If ``style`` is not a recognised code style.
"""
if style not in CODE_STYLES:
- raise ValueError(f"Unknown code_style {style!r}; expected one of {sorted(CODE_STYLES)}")
+ raise ValueError(
+ f"Unknown code_style {style!r}; expected one of {sorted(CODE_STYLES)}"
+ )
if style == "raw":
return code
- symbol, _, suffix = code.partition(".")
+ # Only the final dot separates the venue; share-class dots belong to
+ # the ticker (for example BRK.B.US).
+ symbol, separator, suffix = code.rpartition(".")
+ if not separator:
+ return code
if style == "bare":
return symbol
return f"{suffix.upper()}{symbol}" if suffix else symbol
@@ -160,10 +165,18 @@ def feed_specs_from_config(entries: Iterable[Mapping[str, Any]]) -> list[FeedSpe
seen: set[str] = set()
for entry in entries:
if not isinstance(entry, Mapping):
- raise ValueError("each event feed must be a mapping with name/route_template/event_type")
- missing = [k for k in ("name", "route_template", "event_type") if not str(entry.get(k, "")).strip()]
+ raise ValueError(
+ "each event feed must be a mapping with name/route_template/event_type"
+ )
+ missing = [
+ k
+ for k in ("name", "route_template", "event_type")
+ if not str(entry.get(k, "")).strip()
+ ]
if missing:
- raise ValueError(f"event feed is missing required field(s): {', '.join(missing)}")
+ raise ValueError(
+ f"event feed is missing required field(s): {', '.join(missing)}"
+ )
name = str(entry["name"]).strip()
if name in seen:
raise ValueError(f"duplicate event feed name: {name!r}")
@@ -314,7 +327,9 @@ class RSSHubEventProvider:
"""
from src.config.accessor import get_env_config
- resolved = (base_url if base_url is not None else get_env_config().data.rsshub_base_url).strip()
+ resolved = (
+ base_url if base_url is not None else get_env_config().data.rsshub_base_url
+ ).strip()
self.base_url = resolved.rstrip("/")
specs = tuple(feeds) if feeds is not None else DEFAULT_FEEDS
self.feeds: dict[str, FeedSpec] = {spec.name: spec for spec in specs}
@@ -323,7 +338,9 @@ class RSSHubEventProvider:
def is_available(self) -> bool:
"""Whether a usable RSSHub base URL is configured."""
- return self.base_url not in {p.rstrip("/") for p in RSSHUB_BASE_URL_PLACEHOLDERS}
+ return self.base_url not in {
+ p.rstrip("/") for p in RSSHUB_BASE_URL_PLACEHOLDERS
+ }
def list_feeds(self) -> list[str]:
"""Return registered feed names in stable order."""
@@ -395,7 +412,9 @@ class RSSHubEventProvider:
frame = pd.DataFrame(rows, columns=list(EVENT_COLUMNS))
frame = frame[frame["knowable_date"] <= as_of_date]
- frame = frame.drop_duplicates(subset=["ts_code", "knowable_date", "event_type", "summary"])
+ frame = frame.drop_duplicates(
+ subset=["ts_code", "knowable_date", "event_type", "summary"]
+ )
frame = frame.sort_values(["ts_code", "knowable_date"]).reset_index(drop=True)
return frame
@@ -407,7 +426,9 @@ class RSSHubEventProvider:
feed so an all-feeds-unreachable run can be surfaced loudly.
"""
if spec.is_per_symbol:
- route = spec.route_template.format(code=format_code_for_route(code, spec.code_style))
+ route = spec.route_template.format(
+ code=format_code_for_route(code, spec.code_style)
+ )
else:
route = spec.route_template
url = f"{self.base_url}{route}"
diff --git a/agent/tests/test_rsshub_events_provider.py b/agent/tests/test_rsshub_events_provider.py
index 1dbc25fd7..170652554 100644
--- a/agent/tests/test_rsshub_events_provider.py
+++ b/agent/tests/test_rsshub_events_provider.py
@@ -115,7 +115,12 @@ def test_duplicate_items_are_deduplicated() -> None:
doubled = f'<?xml version="1.0"?><rss version="2.0"><channel>{items}{items}</channel></rss>'
frame = _provider(doubled).query_events(["AAA"], as_of="2024-01-31")
assert len(frame) == 2 # 4 items in, 2 unique out
- assert frame.duplicated(subset=["ts_code", "knowable_date", "event_type", "summary"]).sum() == 0
+ assert (
+ frame.duplicated(
+ subset=["ts_code", "knowable_date", "event_type", "summary"]
+ ).sum()
+ == 0
+ )
def test_hostile_xml_is_neutralised() -> None:
@@ -129,7 +134,9 @@ def test_unknown_feed_raises() -> None:
def test_custom_scorer_override() -> None:
- frame = _provider().query_events(["AAA"], as_of="2024-01-31", scorer=lambda t, s: 0.5)
+ frame = _provider().query_events(
+ ["AAA"], as_of="2024-01-31", scorer=lambda t, s: 0.5
+ )
assert (frame["score"] == 0.5).all()
@@ -183,7 +190,11 @@ def test_per_symbol_route_applies_code_style() -> None:
client = _FakeClient(_RSS)
provider = RSSHubEventProvider(
"https://rsshub.local",
- feeds=[FeedSpec("xq", "/xueqiu/stock/{code}", "earnings", code_style="exchange_prefix")],
+ feeds=[
+ FeedSpec(
+ "xq", "/xueqiu/stock/{code}", "earnings", code_style="exchange_prefix"
+ )
+ ],
client=client,
)
provider.query_events(["600519.SH"], as_of="2024-01-31")
@@ -194,7 +205,12 @@ def test_feed_specs_from_config_parses_and_validates() -> None:
specs = feed_specs_from_config(
[
{"name": "a", "route_template": "/x/{code}", "event_type": "earnings"},
- {"name": "b", "route_template": "/y", "event_type": "macro", "code_style": "bare"},
+ {
+ "name": "b",
+ "route_template": "/y",
+ "event_type": "macro",
+ "code_style": "bare",
+ },
]
)
assert [s.name for s in specs] == ["a", "b"]
@@ -233,7 +249,9 @@ def test_all_feeds_unreachable_raises(monkeypatch) -> None:
provider.query_events(["AAA"], as_of="2024-01-31")
-def test_malformed_timeout_env_falls_back_to_default(monkeypatch: pytest.MonkeyPatch) -> None:
+def test_malformed_timeout_env_falls_back_to_default(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
monkeypatch.setenv("RSSHUB_TIMEOUT_S", "not-a-float")
client = _FakeClient(_RSS)
provider = RSSHubEventProvider(
@@ -248,7 +266,9 @@ def test_malformed_timeout_env_falls_back_to_default(monkeypatch: pytest.MonkeyP
assert client.timeouts == [DEFAULT_TIMEOUT_S]
-def test_malformed_budget_env_falls_back_to_default(monkeypatch: pytest.MonkeyPatch) -> None:
+def test_malformed_budget_env_falls_back_to_default(
+ monkeypatch: pytest.MonkeyPatch,
+) -> None:
monkeypatch.setenv("RSSHUB_FETCH_BUDGET_S", "not-a-float")
client = _FakeClient(_RSS)
provider = RSSHubEventProvider(
@@ -268,3 +288,31 @@ def test_reachable_but_empty_feed_does_not_raise() -> None:
empty_rss = '<?xml version="1.0"?><rss version="2.0"><channel></channel></rss>'
frame = _provider(empty_rss).query_events(["AAA"], as_of="2024-01-31")
assert frame.empty
+
+
+ "code,style,expected",
+ [
+ ("BRK.B.US", "bare", "BRK.B"),
+ ("BF.B.US", "bare", "BF.B"),
+ ("BRK.B.US", "exchange_prefix", "USBRK.B"),
+ ("BF.B.US", "exchange_prefix", "USBF.B"),
+ ("BRK.B.US", "raw", "BRK.B.US"),
+ ("600519.SH", "bare", "600519"),
+ ("600519.SH", "exchange_prefix", "SH600519"),
+ ("AAPL", "bare", "AAPL"),
+ ("AAPL", "exchange_prefix", "AAPL"),
+ ],
+)
+def test_declared_feed_route_preserves_compound_ticker(
+ code: str, style: str, expected: str
+) -> None:
+ client = _FakeClient(_RSS)
+ provider = RSSHubEventProvider(
+ "https://rsshub.local",
+ feeds=[FeedSpec("news", "/news/{code}", "sentiment", style)],
+ client=client,
+ )
+ events = provider.query_events([code], as_of="2024-01-31")
+ assert client.calls == ["https://rsshub.local/news/" + expected]
+ assert events["ts_code"].tolist() == [code, code]