"Vibe-Trading: Your Personal Trading Agent"
Python ai-agentalgorithmic-tradingbacktestingfintechllmmcpmulti-agentpythonquantitative-financetrading
fix(grounding): parse formulas after descriptive labels
zeus2299351a8437f0c
diff --git a/agent/src/agent/grounding/policies.py b/agent/src/agent/grounding/policies.pyindex 179f6bd41..e4b057785 100644--- a/agent/src/agent/grounding/policies.py+++ b/agent/src/agent/grounding/policies.py@@ -411,12 +411,12 @@ def _formula_in_note(note: str) -> tuple[float, list[float], ast.Expression] | Nparts = [piece for part in parts for piece in part.split(separator)]# A formula followed by its explanation ("(a − b) / b,自高点回撤"). A bare# "," is not split: it groups thousands inside a formula.- for separator in (",", ";", ":", "; ", ", "):+ for separator in (",", ";", ":", ":", "; ", ", "):parts = [piece for part in parts for piece in part.split(separator)]candidates.extend(part for part in parts if part.strip())# Only once the note as written fails: its words removed, whole and in parts.unlabelled = _without_labels(note)- for separator in ("≈", "≒", "=", "=", "→", "->", ",", ";", ":", "; ", ", "):+ for separator in ("≈", "≒", "=", "=", "→", "->", ",", ";", ":", ":", "; ", ", "):unlabelled = " \n ".join(unlabelled.split(separator))candidates.extend(part for part in unlabelled.split(" \n ") if part.strip())for candidate in candidates:diff --git a/agent/tests/test_grounding_formula_note.py b/agent/tests/test_grounding_formula_note.pynew file mode 100644index 000000000..05477a912--- /dev/null+++ b/agent/tests/test_grounding_formula_note.py@@ -0,0 +1,118 @@+"""Descriptive punctuation must preserve arithmetic and evidence checks."""++from __future__ import annotations++import ast+import json+from pathlib import Path++import pytest++from src.agent.grounding import GroundingLedger+from src.agent.grounding.policies import _evaluate_formula, _formula_in_note++pytestmark = pytest.mark.unit++[email protected]("separator", [":", ":"])+ "note",+ [+ "scenario result{separator} 125 / 10000 * 100",+ "任意说明{separator} 125 / 10000 * 100",+ "αποτέλεσμα{separator} 125 / 10000 * 100",+ "scenario result{separator}125 / 10000 * 100",+ "scenario result{separator} 125 / 10000 * 100 = 1.25",+ "scenario result{separator} 125 / 10000 * 100, explanation",+ "scenario result{separator} 125 units / 10000 units * 100",+ ],+)+def test_descriptive_colon_preserves_formula(note: str, separator: str) -> None:+ expected = _evaluate_formula("125 / 10000 * 100")+ actual = _formula_in_note(note.format(separator=separator))++ assert expected is not None+ assert actual is not None+ assert actual[:2] == expected[:2]+ assert ast.dump(actual[2]) == ast.dump(expected[2])++[email protected]("separator", [":", ":"])+ "expression",+ [+ "125",+ "125 / 0",+ "125 +",+ "(125 + 100",+ "125 + unknown",+ "125 // 100",+ "125 ** 4",+ "f(125) + 100",+ "__import__('os')",+ "[125, 100][0] + 100",+ ],+)+def test_descriptive_colon_does_not_extend_evaluator(+ expression: str, separator: str+) -> None:+ assert _formula_in_note(f"scenario result{separator} {expression}") is None++[email protected]("separator", [":", ":"])+ ("value", "expression", "ref", "with_evidence", "reason"),+ [+ ("12.4%", "(112.4 - 100.0) / 100.0", "quote", True, None),+ (+ "99.0%",+ "(112.4 - 100.0) / 100.0",+ "quote",+ True,+ "derivation_result_mismatch",+ ),+ ("12.4%", "(56.2 - 50.0) / 50.0", "quote", True, "formula_not_anchored"),+ ("12.4%", "(112.4 - 100.0) / 100.0", "quote", False, "no_evidence"),+ ("12.4%", "(112.4 - 100.0) / 0", "quote", True, "formula_not_evaluable"),+ (+ "13.4%",+ "(112.4 - 100.0 + 1) / 100.0",+ "quote",+ True,+ "additive_operand_not_observed",+ ),+ ],+)+def test_descriptive_colon_keeps_derived_grounding_checks(+ tmp_path: Path,+ separator: str,+ value: str,+ expression: str,+ ref: str,+ with_evidence: bool,+ reason: str | None,+) -> None:+ ledger = GroundingLedger(run_dir=tmp_path, user_message="Analyze AAPL.US")+ if with_evidence:+ ledger.ingest_tool_result(+ tool_name="get_market_data",+ arguments={"codes": ["AAPL.US"]},+ result=json.dumps(+ {+ "AAPL.US": [+ {"trade_date": "2026-08-03", "close": 100.0},+ {"trade_date": "2026-09-02", "close": 112.4},+ ]+ }+ ),+ call_id="quote",+ success=True,+ )+ result = ledger.validate_final_answer(+ f"AAPL.US (USD) cumulative return: {value}.\n\n"+ f"```figures\n{value} | derived | scenario result{separator} {expression} | {ref}\n```"+ )++ assert result.valid is (reason is None), result.issues+ if reason is not None:+ assert reason in {issue.get("reason") for issue in result.issues}, result.issues