Skip to content

"Vibe-Trading: Your Personal Trading Agent"

fix(loaders): accept daily aliases in FMP interval gate (#831)

Santhbe32143bc4a0
diff --git a/agent/backtest/loaders/fmp_loader.py b/agent/backtest/loaders/fmp_loader.py
index 254124151..706e63291 100644
--- a/agent/backtest/loaders/fmp_loader.py
+++ b/agent/backtest/loaders/fmp_loader.py
@@ -118,7 +118,7 @@ class DataLoader:
"""
validate_date_range(start_date, end_date)
- if interval != "1D":
+ if str(interval).strip().lower() not in {"1d", "d", "day", "daily"}:
logger.warning("fmp only supports 1D bars; got interval=%r", interval)
return {}
diff --git a/agent/tests/test_fmp_daily_aliases.py b/agent/tests/test_fmp_daily_aliases.py
new file mode 100644
index 000000000..8e78a3154
--- /dev/null
+++ b/agent/tests/test_fmp_daily_aliases.py
@@ -0,0 +1,35 @@
+"""FMP daily gate must accept connector-style daily aliases like sina/tencent."""
+
+from __future__ import annotations
+
+from unittest.mock import patch
+
+from backtest.loaders import fmp_loader as fl
+from backtest.loaders.fmp_loader import DataLoader
+
+
+def _body(symbol, bars):
+ return {"symbol": symbol, "historical": bars}
+
+
+_AAPL_BARS = [
+ {"date": "2024-01-04", "open": 3.0, "high": 4.0, "low": 2.5, "close": 3.5, "volume": 200.0},
+ {"date": "2024-01-03", "open": 1.0, "high": 2.0, "low": 0.5, "close": 1.5, "volume": 100.0},
+]
+
+
+def test_lowercase_1d_still_fetches(monkeypatch) -> None:
+ """``1d`` used to hit the exact ``!= "1D"`` gate and return empty."""
+ monkeypatch.setenv("FMP_API_KEY", "secret")
+ with patch.object(fl, "throttled_get_json", return_value=_body("AAPL", _AAPL_BARS)) as mock_get:
+ out = DataLoader().fetch(["AAPL.US"], "2024-01-01", "2024-01-31", interval="1d")
+ assert set(out) == {"AAPL.US"}
+ mock_get.assert_called_once()
+
+
+def test_hour_interval_still_rejected(monkeypatch) -> None:
+ monkeypatch.setenv("FMP_API_KEY", "secret")
+ with patch.object(fl, "throttled_get_json") as mock_get:
+ out = DataLoader().fetch(["AAPL.US"], "2024-01-01", "2024-01-31", interval="1H")
+ assert out == {}
+ mock_get.assert_not_called()