"Vibe-Trading: Your Personal Trading Agent"
Python ai-agentalgorithmic-tradingbacktestingfintechllmmcpmulti-agentpythonquantitative-financetrading
fix(benchmark): give hong kong runs a fetchable 2828.HK benchmark
Rudy Celeklicae34d29f203
diff --git a/agent/backtest/benchmark.py b/agent/backtest/benchmark.pyindex da0ea29d6..0f1c69d3d 100644--- a/agent/backtest/benchmark.py+++ b/agent/backtest/benchmark.py@@ -23,7 +23,7 @@ from backtest.metrics import bar_returns, buy_and_hold_returnMARKET_BENCHMARKS: dict[str, Optional[str]] = {"us_equity": "SPY",- "hk_equity": "HK.03100", # Hang Seng China Enterprises ETF+ "hk_equity": "2828.HK", # Hang Seng China Enterprises Index ETF"ca_equity": "XIC.TO", # S&P/TSX Capped Composite ETF"br_equity": "BOVA11.SA", # iShares Ibovespa ETF"a_share": "000300.SH", # CSI 300 (China A-share core index)diff --git a/agent/tests/test_benchmark_hk_ticker.py b/agent/tests/test_benchmark_hk_ticker.pynew file mode 100644index 000000000..a01c20250--- /dev/null+++ b/agent/tests/test_benchmark_hk_ticker.py@@ -0,0 +1,37 @@+"""HK runs must ask the loader for a benchmark in project (suffix) form.++Loaders take ``700.HK``-style symbols; a Futu-style ``HK.03100`` passes+through the yfinance/Longbridge symbol mappers unchanged, Yahoo answers+"No data found", and every HK backtest silently loses its benchmark.+"""++import pandas as pd+import pytest++from backtest.benchmark import resolve_benchmark+from backtest.loaders.yfinance_loader import _to_yfinance_symbol++[email protected]("symbol", ["700.HK", "00700.HK", "9988.HK"])+def test_hk_strategy_benchmarks_against_hscei_etf_in_suffix_form(symbol):+ seen = []++ class Loader:+ name = "yfinance"++ def fetch(self, codes, *args, **kwargs):+ seen.extend(codes)+ return {+ codes[0]: pd.DataFrame(+ {"close": [10.0, 11.0]},+ index=pd.date_range("2025-01-01", periods=2),+ )+ }++ result = resolve_benchmark(+ [symbol], "yfinance", "2025-01-01", "2025-01-02", loader=Loader()+ )++ assert result is not None+ assert seen == [result.ticker]+ assert _to_yfinance_symbol(result.ticker) == "2828.HK"