Skip to content

"Vibe-Trading: Your Personal Trading Agent"

fix(llm): honor effort across compatible providers

cgycoreydeb60f4e63e3
diff --git a/agent/src/providers/llm.py b/agent/src/providers/llm.py
index beb4752b3..c1ee1ad40 100644
--- a/agent/src/providers/llm.py
+++ b/agent/src/providers/llm.py
@@ -18,6 +18,7 @@ from pydantic import PrivateAttr
from src.config.accessor import get_env_config, reset_env_config
from src.providers.capabilities import (
+ ProviderCapabilities,
get_llm_credentials,
get_provider_capabilities,
)
@@ -1028,21 +1029,8 @@ def _sync_provider_env() -> None:
os.environ["OPENAI_BASE_URL"] = base_url
-def _supports_top_level_reasoning_effort(provider: str) -> bool:
- """Report whether a provider accepts a top-level ``reasoning_effort`` field.
-
- An explicit ``openai`` provider selects the OpenAI-compatible wire contract,
- including gateway base URLs and model names that resemble third-party
- providers. Named providers remain responsible for their own mappings, such
- as relays that use ``extra_body.reasoning``.
-
- Args:
- provider: Configured ``LANGCHAIN_PROVIDER`` value.
-
- Returns:
- True for the default or explicitly configured OpenAI-compatible adapter.
- """
- return provider.strip().lower() in {"", "openai"}
+def _supports_top_level_reasoning_effort(caps: ProviderCapabilities) -> bool:
+ return caps.name not in {"anthropic", "openai-codex"} and not caps.openrouter_reasoning_body
def provider_diagnostics() -> dict[str, Any]:
@@ -1153,7 +1141,10 @@ def provider_diagnostics() -> dict[str, Any]:
"send_reasoning_content": caps.send_reasoning_content,
"gemini_thought_signatures": caps.gemini_thought_signatures,
"openrouter_reasoning_body": caps.openrouter_reasoning_body,
- "top_level_reasoning_effort": _supports_top_level_reasoning_effort(provider),
+ "top_level_reasoning_effort": (
+ adapter_type == "openai-compatible"
+ and _supports_top_level_reasoning_effort(caps)
+ ),
},
}
@@ -1256,16 +1247,12 @@ def build_llm(*, model_name: Optional[str] = None, callbacks: Any = None) -> Any
if effort and not use_responses_api and caps.openrouter_reasoning_body
else None
),
- # Direct OpenAI takes the effort as a top-level request field instead
- # (gpt-5.6-* require it, even "none", to accept function tools).
- # None is dropped by langchain-openai, so unsupported providers keep a
- # payload without the field.
"reasoning_effort": (
effort
if (
effort
and not use_responses_api
- and _supports_top_level_reasoning_effort(provider)
+ and _supports_top_level_reasoning_effort(caps)
)
else None
),
diff --git a/agent/tests/test_llm_reasoning_effort.py b/agent/tests/test_llm_reasoning_effort.py
index 18ee52cb6..a9aaac7cc 100644
--- a/agent/tests/test_llm_reasoning_effort.py
+++ b/agent/tests/test_llm_reasoning_effort.py
@@ -4,7 +4,7 @@ The setting has two mutually exclusive delivery paths:
* Relays that require an opt-in (OpenRouter, Requesty) receive
``extra_body={"reasoning": {"effort": ...}}``.
-* Direct OpenAI receives a top-level ``reasoning_effort``. Its ``gpt-5.6-*``
+* ChatOpenAI-compatible providers receive a top-level ``reasoning_effort``. Its ``gpt-5.6-*``
models reject function tools on ``/v1/chat/completions`` without one::
Function tools with reasoning_effort are not supported for gpt-5.6-sol
@@ -180,39 +180,35 @@ class TestDirectOpenAI:
class TestUnsupportedProviders:
- """A configured effort must never leak onto unverified providers."""
-
- def test_deepseek_never_receives_top_level_effort(self) -> None:
- """DeepSeek's documented invariant covers both delivery paths."""
+ def test_deepseek_openai_compatible_receives_top_level_effort(self) -> None:
kwargs = _capture_kwargs(
{
"LANGCHAIN_PROVIDER": "deepseek",
"DEEPSEEK_API_KEY": "ds-test",
- "DEEPSEEK_BASE_URL": "https://api.deepseek.com/v1",
- "LANGCHAIN_MODEL_NAME": "deepseek-v4-pro",
+ "DEEPSEEK_BASE_URL": "https://gateway.example/v1",
+ "LANGCHAIN_MODEL_NAME": "deepseek-v4-flash",
"LANGCHAIN_REASONING_EFFORT": "high",
"VIBE_TRADING_DEEPSEEK_ADAPTER": "openai-compatible",
"LANGCHAIN_USE_RESPONSES_API": "false",
}
)
- assert kwargs["reasoning_effort"] is None
+ assert kwargs["reasoning_effort"] == "high"
assert kwargs["extra_body"] is None
- def test_gemini_never_receives_top_level_effort(self) -> None:
- """Second unsupported provider: Gemini's OpenAI-compatible endpoint."""
+ def test_gemini_openai_compatible_receives_top_level_effort(self) -> None:
kwargs = _capture_kwargs(
{
"LANGCHAIN_PROVIDER": "gemini",
"GEMINI_API_KEY": "gm-test",
- "GEMINI_BASE_URL": "https://generativelanguage.googleapis.com/v1beta/openai",
+ "GEMINI_BASE_URL": "https://gateway.example/v1",
"LANGCHAIN_MODEL_NAME": "gemini-3.5-flash",
"LANGCHAIN_REASONING_EFFORT": "high",
"LANGCHAIN_USE_RESPONSES_API": "false",
}
)
- assert kwargs["reasoning_effort"] is None
+ assert kwargs["reasoning_effort"] == "high"
assert kwargs["extra_body"] is None
def test_explicit_openai_provider_keeps_effort_for_deepseek_model(self) -> None:
@@ -229,8 +225,9 @@ class TestUnsupportedProviders:
assert kwargs["reasoning_effort"] == "high"
- def test_unknown_provider_does_not_inherit_openai_fallback(self) -> None:
- """Unknown names fall back to OpenAI capabilities but stay unverified."""
+ def test_unknown_openai_compatible_provider_receives_top_level_effort(
+ self,
+ ) -> None:
kwargs = _capture_kwargs(
{
"LANGCHAIN_PROVIDER": "some-openai-compatible-gateway",
@@ -241,7 +238,7 @@ class TestUnsupportedProviders:
}
)
- assert kwargs["reasoning_effort"] is None
+ assert kwargs["reasoning_effort"] == "high"
class TestRelayOptIn:
@@ -348,14 +345,15 @@ class TestResponsesAPI:
assert kwargs["reasoning"] == {"effort": "high"}
assert kwargs["reasoning_effort"] is None
- def test_deepseek_flash_can_opt_into_responses_reasoning(self) -> None:
+ def test_named_deepseek_can_opt_into_responses_reasoning(self) -> None:
kwargs = _capture_kwargs(
{
- "LANGCHAIN_PROVIDER": "openai",
- "OPENAI_API_KEY": "sk-test",
- "OPENAI_BASE_URL": "https://gateway.example/v1",
- "LANGCHAIN_MODEL_NAME": "deepseek-v4-flash-0731",
+ "LANGCHAIN_PROVIDER": "deepseek",
+ "DEEPSEEK_API_KEY": "ds-test",
+ "DEEPSEEK_BASE_URL": "https://gateway.example/v1",
+ "LANGCHAIN_MODEL_NAME": "deepseek-v4-flash",
"LANGCHAIN_REASONING_EFFORT": "max",
+ "VIBE_TRADING_DEEPSEEK_ADAPTER": "openai-compatible",
"LANGCHAIN_USE_RESPONSES_API": "true",
}
)