Skip to content

VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.

fix(release): open the release notes with the installer signing table

velixio15addcb883e1
diff --git a/.github/workflows/electron-release.yml b/.github/workflows/electron-release.yml
index 0f84965dc..dce416a6d 100644
--- a/.github/workflows/electron-release.yml
+++ b/.github/workflows/electron-release.yml
@@ -347,7 +347,9 @@ jobs:
gh api -H "Accept: application/vnd.github.raw" \
"repos/$GITHUB_REPOSITORY/contents/scripts/release_signing_notes.py?ref=$GITHUB_SHA" \
> "$RUNNER_TEMP/release_signing_notes.py"
- python3 "$RUNNER_TEMP/release_signing_notes.py" release-signing >> release-assets/RELEASE_NOTES.md
+ # The table leads the notes so downloaders see it before the changelog.
+ { python3 "$RUNNER_TEMP/release_signing_notes.py" release-signing; echo; cat release-assets/RELEASE_NOTES.md; } > "$RUNNER_TEMP/RELEASE_NOTES.md"
+ mv "$RUNNER_TEMP/RELEASE_NOTES.md" release-assets/RELEASE_NOTES.md
- name: Create or update draft
run: |
# A beta is always a prerelease so GitHub never makes it `latest`.
diff --git a/CHANGELOG.md b/CHANGELOG.md
index fdbff65b2..1197a2e6e 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -105,6 +105,7 @@ metadata and the backend fallback mirror it.
### CI
+- Release notes open with the installer signing table, so you see which downloads are signed before the changelog (#PR)
- macOS release builds retry once when Apple's ticket server drops the notarization staple, instead of failing the whole release (#3244)
- Release notes list everyone who contributed since the last stable release automatically, instead of only the people thanked by hand (#3242)
- Release notes list each platform's installer signing as measured on the build, and a macOS build that would open as "damaged" can no longer be released, and macOS releases are signed with the Developer ID again (#3241, #3243)
diff --git a/docs/RELEASING.md b/docs/RELEASING.md
index 9884e59e1..03e7fc4fd 100644
--- a/docs/RELEASING.md
+++ b/docs/RELEASING.md
@@ -155,7 +155,7 @@ Dispatch `electron-release.yml` for the exact tag with `publish=true`. Signing
and notarization are required by default. The owner may explicitly set
`allow_unsigned=true`. Never select that exception without the owner's decision.
Every build, published or not, verifies what each platform leg actually ships
-and the release notes end with an **Installer signing** table built from those
+and the release notes open with an **Installer signing** table built from those
checks (✅ signed and notarized, ⚠️ unsigned or ad hoc, with what users will
see). A macOS bundle with an invalid signature always fails, and a platform
whose signing credentials are configured fails if its installers are not signed
diff --git a/tests/test_release_signing_notes.py b/tests/test_release_signing_notes.py
index e6af35c8b..dd8f28225 100644
--- a/tests/test_release_signing_notes.py
+++ b/tests/test_release_signing_notes.py
@@ -103,11 +103,15 @@ def test_release_notes_helper_comes_from_the_workflow_commit(tmp_path):
work = tmp_path / "tag-checkout"
(work / "release-signing").mkdir(parents=True)
(work / "release-assets").mkdir()
+ (work / "release-assets/RELEASE_NOTES.md").write_text("**Highlights**\n")
write(work / "release-signing", "linux", "x64", "not-applicable")
env = dict(os.environ, PATH=f"{fake}{os.pathsep}{os.environ['PATH']}", GITHUB_SHA="workflow-sha",
GITHUB_REPOSITORY="debpalash/VoiceStudio", RUNNER_TEMP=str(tmp_path))
subprocess.run(["bash", "-e", "-c", describe["run"]], cwd=work, env=env, check=True)
- assert "| Linux x64 |" in (work / "release-assets/RELEASE_NOTES.md").read_text()
+ text = (work / "release-assets/RELEASE_NOTES.md").read_text()
+ # The table leads the notes; the changelog follows unchanged.
+ assert "| Linux x64 |" in text
+ assert text.index("### Installer signing") < text.index("**Highlights**")
@pytest.mark.parametrize("failures,message,calls,ok", [