VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.
Python aiaudiobookcudadubbingelevenlabs-alternativehuggingfacelocal-firstmlxomnivoice-studiospeech-to-texttext-to-speechtranscriptiontranslatettsvoice-aivoice-cloningvoice-generationvoicestudioworkflow
fix(ios): give the OmniVoice framework the version keys App Store Connect requires
velixio290f158e845f
diff --git a/.github/workflows/ios-testflight.yml b/.github/workflows/ios-testflight.ymlindex ed7498cc5..ec4bdb5a3 100644--- a/.github/workflows/ios-testflight.yml+++ b/.github/workflows/ios-testflight.yml@@ -99,6 +99,13 @@ jobs:codesign --verify --deep --strict "$APP"codesign -dvv "$APP" 2>&1 | grep -qx "TeamIdentifier=$TEAM_ID"test "$(/usr/libexec/PlistBuddy -c 'Print CFBundleVersion' "$APP/Info.plist")" = "$VOICESTUDIO_IOS_BUILD_NUMBER"+ # App Store Connect rejects any embedded framework without both version keys.+ for plist in "$APP"/Frameworks/*.framework/Info.plist; do+ [ -e "$plist" ] || continue+ for key in CFBundleShortVersionString CFBundleVersion; do+ /usr/libexec/PlistBuddy -c "Print $key" "$plist" >/dev/null || { echo "$plist is missing $key"; exit 1; }+ done+ done- name: Upload to TestFlightenv:diff --git a/mobile/native/ios/build.py b/mobile/native/ios/build.pyindex 2f39acbae..6710ad7b7 100644--- a/mobile/native/ios/build.py+++ b/mobile/native/ios/build.py@@ -210,7 +210,7 @@ def framework(name, library, headers, output, platform_name):shutil.copy2(header, target / 'Headers' / header.name)(target / 'Modules').mkdir(exist_ok=True)(target / 'Modules/module.modulemap').write_text('framework module ' + name + ' { umbrella "../Headers" export * }\n')- (target / 'Info.plist').write_bytes(plistlib.dumps({'CFBundleIdentifier': 'com.voicestudio.native.' + name, 'CFBundleName': name, 'CFBundleExecutable': name, 'CFBundlePackageType': 'FMWK', 'CFBundleVersion': '1', 'MinimumOSVersion': '17.0', 'CFBundleSupportedPlatforms': [platform_name]}))+ (target / 'Info.plist').write_bytes(plistlib.dumps({'CFBundleIdentifier': 'com.voicestudio.native.' + name, 'CFBundleName': name, 'CFBundleExecutable': name, 'CFBundlePackageType': 'FMWK', 'CFBundleShortVersionString': '1.0', 'CFBundleVersion': '1', 'MinimumOSVersion': '17.0', 'CFBundleSupportedPlatforms': [platform_name]}))run('install_name_tool', '-id', '@rpath/' + name + '.framework/' + name, target / name)return targetdiff --git a/tests/test_ios_testflight.py b/tests/test_ios_testflight.pyindex 1b1109164..10861b79e 100644--- a/tests/test_ios_testflight.py+++ b/tests/test_ios_testflight.py@@ -163,3 +163,24 @@ def test_native_runtime_cache_survives_later_app_or_ui_failures(filename):assert "if" not in steps[build] # Cache hits still need generated headers restored.assert save["with"]["path"] == restore["with"]["path"]assert save["with"]["key"] == "${{ steps." + restore["id"] + ".outputs.cache-primary-key }}"+++def test_native_frameworks_carry_app_store_version_keys(tmp_path, monkeypatch):+ # Upload run 40004846857 was rejected: OmniVoice.framework lacked CFBundleShortVersionString.+ spec = importlib.util.spec_from_file_location("native_ios_build", ROOT / "mobile/native/ios/build.py")+ build = importlib.util.module_from_spec(spec)+ spec.loader.exec_module(build)+ monkeypatch.setattr(build, "run", lambda *args, **kwargs: None)+ library = tmp_path / "libomnivoice.dylib"+ library.write_bytes(b"")+ header = tmp_path / "omnivoice.h"+ header.write_text("")+ target = build.framework("OmniVoice", library, [header], tmp_path / "out", "iPhoneOS")+ info = plistlib.loads((target / "Info.plist").read_bytes())+ assert info["CFBundleShortVersionString"] and info["CFBundleVersion"]+++def test_upload_checks_every_embedded_framework_version():+ script = next(s["run"] for s in load_workflow()["jobs"]["testflight"]["steps"] if s.get("name") == "Verify archive signature and version")+ assert 'Frameworks/*.framework/Info.plist' in script+ assert "CFBundleShortVersionString CFBundleVersion" in script