Skip to content

VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.

ci: run the UI crawler as one job

velixio3299d3acdf0d
diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index 623b5c377..0e21baf0e 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -313,7 +313,7 @@ OMNIVOICE_PORT=3999 bun run --cwd electron smoke:server &
OMNIVOICE_PORT=3999 VOICESTUDIO_UI_URL=http://localhost:3912 PLAYWRIGHT_CHANNEL=chromium \
node electron/tests/run-renderer-smokes.mjs [name-filter ...]
-# UI crawler (the sharded "UI crawler" CI jobs), against the same smoke server:
+# UI crawler (the "UI crawler" CI job), against the same smoke server:
# clicks every enabled button on every route, then the buttons a filled-in form
# enables, then one level into each dialog, while API writes answer normally,
# with 500, with a network error, or with broken JSON. It fails on a spinner
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 0ddd31626..9c296bed7 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -193,17 +193,13 @@ jobs:
# Clicks every button on every route under four backend fault modes and fails
# on stuck spinners, buttons left disabled, silent failures, crashes and
# console errors
- # (electron/tests/ui-crawler.mjs). Sharded by route so the deep crawl runs
- # beside the main test job instead of lengthening it.
+ # (electron/tests/ui-crawler.mjs). One job, not a mode x shard matrix: the
+ # crawler runs every fault mode concurrently in one process, and a matrix of
+ # twelve jobs per push queued behind the runner limit for hours.
ui-crawler:
- name: UI crawler (${{ matrix.mode }} ${{ matrix.shard }})
+ name: UI crawler
runs-on: ubuntu-24.04
- timeout-minutes: 25
- strategy:
- fail-fast: false
- matrix:
- mode: [fixture, http-500, network-error, bad-json]
- shard: [1/3, 2/3, 3/3]
+ timeout-minutes: 45
steps:
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 # v4.4.0
@@ -236,8 +232,6 @@ jobs:
env:
OMNIVOICE_PORT: '3999'
VOICESTUDIO_UI_URL: http://localhost:3912
- VOICESTUDIO_CRAWL_MODES: ${{ matrix.mode }}
- VOICESTUDIO_CRAWL_SHARD: ${{ matrix.shard }}
run: |
set -euo pipefail
bun run --cwd electron smoke:server > /tmp/voicestudio-crawler-server.log 2>&1 &
diff --git a/electron/tests/ui-crawler.test.mjs b/electron/tests/ui-crawler.test.mjs
index bf7312726..da7586dc4 100644
--- a/electron/tests/ui-crawler.test.mjs
+++ b/electron/tests/ui-crawler.test.mjs
@@ -8,21 +8,19 @@ const dir = dirname(fileURLToPath(import.meta.url));
const crawler = readFileSync(join(dir, 'ui-crawler.mjs'), 'utf8');
const ci = readFileSync(join(dir, '../../.github/workflows/ci.yml'), 'utf8');
-const list = (source) => source.match(/'([^']+)'|[\w/-]+/g).map((item) => item.replaceAll("'", ''));
+const job = ci.match(/\n {2}ui-crawler:\n([\s\S]*?)\n {2}[\w-]+:\n/)[1];
-test('CI crawls every fault mode the crawler defines', () => {
- const modes = list(crawler.match(/const MODES = \[([^\]]+)\]/)[1]);
- const matrix = list(ci.match(/ui-crawler:[\s\S]*?mode: \[([^\]]+)\]/)[1]);
- assert.deepEqual(matrix, modes);
+test('CI crawls every fault mode in one job', () => {
+ // A matrix would multiply runner jobs per push; the crawler runs the modes concurrently itself.
+ assert.doesNotMatch(job, /strategy:|matrix\./, 'ui-crawler must stay a single job');
+ // Narrowing the modes or routes in CI would silently skip the faults this job exists for.
+ assert.doesNotMatch(job, /VOICESTUDIO_CRAWL_(MODES|ROUTES|SHARD)/);
+ assert.match(crawler, /const MODES = \['fixture', 'http-500', 'network-error', 'bad-json'\]/);
});
-test('CI shards cover every route exactly once', () => {
- const shards = list(ci.match(/ui-crawler:[\s\S]*?shard: \[([^\]]+)\]/)[1]);
- const total = Number(shards[0].split('/')[1]);
- assert.deepEqual(
- shards,
- Array.from({ length: total }, (_, index) => `${index + 1}/${total}`),
- );
+test('the single job leaves room for a full crawl', () => {
+ const minutes = Number(job.match(/timeout-minutes: (\d+)/)[1]);
+ assert.ok(minutes >= 30, `timeout-minutes ${minutes} is too short for every mode and route`);
});
test('crawler findings are fixed, not allowlisted', () => {