VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.
Python aiaudiobookcudadubbingelevenlabs-alternativehuggingfacelocal-firstmlxomnivoice-studiospeech-to-texttext-to-speechtranscriptiontranslatettsvoice-aivoice-cloningvoice-generationvoicestudioworkflow
fix(release): let electron-builder find the imported Developer ID identity
velixio405c439e3051
diff --git a/.github/workflows/electron-release.yml b/.github/workflows/electron-release.ymlindex f0e38bb69..f24b2dea8 100644--- a/.github/workflows/electron-release.yml+++ b/.github/workflows/electron-release.yml@@ -193,6 +193,11 @@ jobs:# signer. Omit absent credentials rather than passing empty strings.if [ -z "${CSC_LINK:-}" ]; thenunset CSC_LINK CSC_KEY_PASSWORD+ elif [ "${{ matrix.platform }}" = darwin ]; then+ # With discovery off and no identity name, electron-builder never looks in+ # the keychain it imported CSC_LINK into and skips signing (v0.5.7-beta.1).+ # Discovery is limited to that imported keychain, not the runner's.+ export CSC_IDENTITY_AUTO_DISCOVERY=truefibun x electron-builder --config electron-builder.config.mjs ${{ matrix.flags }} --publish neverif [ "$RUNNER_OS" = Linux ]; thendiff --git a/CHANGELOG.md b/CHANGELOG.mdindex 7770ab598..31dbadaf5 100644--- a/CHANGELOG.md+++ b/CHANGELOG.md@@ -106,7 +106,7 @@ metadata and the backend fallback mirror it.### CI- Release notes list everyone who contributed since the last stable release automatically, instead of only the people thanked by hand (#3242)-- Release notes list each platform's installer signing as measured on the build, and a macOS build that would open as "damaged" can no longer be released (#3241)+- Release notes list each platform's installer signing as measured on the build, and a macOS build that would open as "damaged" can no longer be released, and macOS releases are signed with the Developer ID again (#3241, #3243)- The owner can let named maintainers publish releases while Windows installers are still unsigned (#3236)- Android release and Play builds share an increasing version code to prevent reused or decreasing build numbers (#2969)- Phone build resources keep notice hashes and localized text intact on Windows (#2969)diff --git a/tests/test_release_signing_notes.py b/tests/test_release_signing_notes.pyindex 1c4291c56..a6120ad57 100644--- a/tests/test_release_signing_notes.py+++ b/tests/test_release_signing_notes.py@@ -65,6 +65,20 @@ def test_every_package_leg_reports_and_mac_check_ignores_allow_unsigned():assert steps["Save the signing report"]["with"]["name"] == "electron-signing-${{ matrix.platform }}-${{ matrix.arch }}"+def test_mac_package_discovers_the_imported_developer_id(tmp_path):+ # electron-builder's findIdentity returns null without a lookup when discovery is+ # off and no identity is named, so a supplied certificate was silently ignored.+ import os+ import subprocess+ package = next(s for s in load_workflow()["jobs"]["package"]["steps"] if s.get("name") == "Package without publishing")+ script = package["run"].split("bun x electron-builder")[0].replace("${{ matrix.platform }}", "darwin")+ for link, expected in [("base64-p12", "true"), ("", "false")]:+ env = dict(os.environ, CSC_LINK=link, CSC_KEY_PASSWORD="x", CSC_IDENTITY_AUTO_DISCOVERY="false", PUBLISH="false")+ out = subprocess.run(["bash", "-e", "-c", script + 'echo "$CSC_IDENTITY_AUTO_DISCOVERY"'],+ env=env, capture_output=True, text=True, check=True).stdout.strip()+ assert out == expected, link++def test_release_notes_are_built_from_the_reports():steps = load_workflow()["jobs"]["release"]["steps"]describe = next(step for step in steps if step.get("name") == "Describe installer signing per platform")