Skip to content

VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.

fix(android): preserve unpainted SVG paths in generated icons

debpalash584cf6bde6ee
diff --git a/.github/workflows/mobile.yml b/.github/workflows/mobile.yml
index 618ae6c82..299d3eb79 100644
--- a/.github/workflows/mobile.yml
+++ b/.github/workflows/mobile.yml
@@ -10,6 +10,7 @@ on:
pull_request:
paths:
- "mobile/**"
+ - "docs/logo.svg"
- "electron/src/renderer/src/i18n/locales/**"
- "electron/src/shared/languages.json"
- "package.json"
@@ -18,6 +19,7 @@ on:
branches: [main]
paths:
- "mobile/**"
+ - "docs/logo.svg"
- "electron/src/renderer/src/i18n/locales/**"
- "electron/src/shared/languages.json"
- "package.json"
diff --git a/CHANGELOG.md b/CHANGELOG.md
index 1616ef47b..8fff3c5a8 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -30,6 +30,7 @@ metadata and the backend fallback mirror it.
### Fixed
+- Android app icons preserve transparent waveform paths from the shared logo, including themed icons (#2969)
- Speak keeps your script when switching between the phone and computer on Android (#2969)
- Phone dubbing no longer speaks the wrong words when a quiet reference clip is not recognised (#2969)
- Refined iOS navigation, voice libraries, grouped creation forms and licence sheets with native controls, accessible text and explicit cancellation (#2969)
diff --git a/docs/branding.md b/docs/branding.md
index 2c7439bfd..979fc353d 100644
--- a/docs/branding.md
+++ b/docs/branding.md
@@ -27,6 +27,11 @@ It renders `docs/logo.svg` to the README PNGs and every PNG, ICO and ICNS under
the Electron packaging contract. Keep `fill="none"` on the waveform path in every
SVG copy of the mark; without it the curve fills black.
+Android generates its vectors from the same SVG with
+`mobile/android/scripts/generate_brand_resources.py`. SVG paint `none` becomes
+transparent Android color before applying the monochrome treatment, so the
+waveform stays unfilled in both standard and themed icons.
+
Do not redraw the waveform per screen. Use `VoiceStudioMark` in React and the
canonical SVG elsewhere so the silhouette stays recognizable at 16–512 px.
diff --git a/mobile/android/scripts/generate_brand_resources.py b/mobile/android/scripts/generate_brand_resources.py
index eba777fad..3f7f1838b 100644
--- a/mobile/android/scripts/generate_brand_resources.py
+++ b/mobile/android/scripts/generate_brand_resources.py
@@ -43,7 +43,11 @@ def generate(repository, output):
value = path.attrib.get(source)
if not value:
continue
- if monochrome:
+ if value == 'none':
+ # Android vectors need a color, and themed icons must keep
+ # deliberately unpainted SVG paths transparent too.
+ node.attrib.update(android(**{target: '#00000000'}))
+ elif monochrome:
node.attrib.update(android(**{target: '#FFFFFFFF'}))
elif value.startswith('url(#'):
gradient = gradients[value[5:-1]]
diff --git a/tests/test_voicestudio_branding.py b/tests/test_voicestudio_branding.py
index 201cbcbe9..985b06712 100644
--- a/tests/test_voicestudio_branding.py
+++ b/tests/test_voicestudio_branding.py
@@ -7,6 +7,7 @@ import re
import subprocess
from pathlib import Path
+import pytest
from packaging.version import Version
@@ -93,6 +94,33 @@ def test_raster_icons_have_no_black_band() -> None:
assert icon.getpixel((width // 2, int(height * 0.53)))[:3] != (0, 0, 0), name
[email protected]("name", ("vs_logo", "vs_launcher_foreground", "vs_launcher_monochrome"))
+def test_android_vectors_keep_unpainted_waveform_transparent(tmp_path: Path, name: str) -> None:
+ import runpy
+ import xml.etree.ElementTree as ET
+
+ generator = runpy.run_path(str(ROOT / "mobile/android/scripts/generate_brand_resources.py"))
+ generator["generate"](ROOT, tmp_path)
+ android = "{http://schemas.android.com/apk/res/android}"
+ vector = ET.parse(tmp_path / f"drawable/{name}.xml").getroot()
+ waveform = next(p for p in vector.iter("path") if p.get(android + "pathData", "").startswith("M6 34c4 0 5-7 9-7"))
+ # SVG's `none` is not an Android color; monochrome must preserve unpainted areas too.
+ assert waveform.get(android + "fillColor") in (None, "#00000000", "@android:color/transparent")
+ assert waveform.get(android + "strokeColor") or any(
+ attr.get("name") == "android:strokeColor" for attr in waveform
+ )
+
+
[email protected]("event", ("push", "pull_request"))
+def test_canonical_logo_changes_run_mobile_builds(event: str) -> None:
+ from fnmatch import fnmatchcase
+
+ import yaml
+
+ workflow = yaml.load((ROOT / ".github/workflows/mobile.yml").read_text(encoding="utf-8"), Loader=yaml.BaseLoader)
+ assert any(fnmatchcase("docs/logo.svg", pattern) for pattern in workflow["on"][event]["paths"])
+
+
def test_python_package_metadata_points_to_voicestudio() -> None:
pyproject = (ROOT / "pyproject.toml").read_text()
assert 'Homepage = "https://github.com/debpalash/VoiceStudio"' in pyproject