Skip to content

VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.

fix(audio): rebuild paused take previews

velixio7581366630ee
diff --git a/electron/src/renderer/src/components/audio-preview-button.test.tsx b/electron/src/renderer/src/components/audio-preview-button.test.tsx
index 0d622a99d..96e0c61e3 100644
--- a/electron/src/renderer/src/components/audio-preview-button.test.tsx
+++ b/electron/src/renderer/src/components/audio-preview-button.test.tsx
@@ -1,6 +1,10 @@
import { act, cleanup, fireEvent, render, screen } from '@testing-library/react';
import { afterEach, expect, it, vi } from 'vitest';
-type Handlers = Record<string, (() => void) | undefined> & { src: { src: string } };
+type MockPlayer = { play: ReturnType<typeof vi.fn> };
+type Handlers = Record<string, (() => void) | undefined> & {
+ src: { src: string };
+ playerRef: { current: MockPlayer | null };
+};
const players = vi.hoisted(() => ({ mounted: [] as Handlers[], live: null as Handlers | null }));
vi.mock('react-i18next', () => ({ useTranslation: () => ({ t: (key: string) => key }) }));
vi.mock('./media-player', async () => {
@@ -72,14 +76,17 @@ it('defers onReady until playback stops so a refetch cannot cut the clip', () =>
expect(onReady).toHaveBeenCalledTimes(1);
expect(screen.getByRole('button', { name: 'clone.preview_voice' })).toBeVisible();
});
-it('rebuilds a paused preview when its media instance was discarded', () => {
+it('rebuilds a paused preview instead of replaying its discarded media instance', () => {
render(<AudioPreviewButton src="/older-take.wav" source="take-older" />);
fireEvent.click(screen.getByRole('button'));
fire('onPlaying');
fire('onPause');
+ const stalePlay = vi.fn(async () => undefined);
+ players.live!.playerRef.current = { play: stalePlay };
fireEvent.click(screen.getByRole('button', { name: 'clone.preview_voice' }));
+ expect(stalePlay).not.toHaveBeenCalled();
expect(players.mounted).toHaveLength(2);
expect(screen.getByRole('button', { name: 'common.loading · common.cancel' })).toBeEnabled();
});
diff --git a/electron/src/renderer/src/components/audio-preview-button.tsx b/electron/src/renderer/src/components/audio-preview-button.tsx
index 88cfa8b40..f641af7a2 100644
--- a/electron/src/renderer/src/components/audio-preview-button.tsx
+++ b/electron/src/renderer/src/components/audio-preview-button.tsx
@@ -77,11 +77,9 @@ function PreviewButton({
else {
// History refreshes and another playback claim can leave the control in
// its valid paused state after Vidstack has discarded the old provider.
- // Rebuild lazily when that instance is gone (or rejects replay) instead
- // of leaving an older take's Play button as a no-op.
- const pausedPlayer = player.current;
- if (!pausedPlayer) start();
- else void pausedPlayer.play().catch(start);
+ // Rebuild synchronously from this click: trying the stale provider first
+ // loses the user gesture before the retry and Chromium rejects autoplay.
+ start();
}
};
const resolved = fallback && fallbackSrc ? fallbackSrc : src;