Skip to content

VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.

fix(audio): keep generated take playback stable

velixio99e0bb744340
diff --git a/electron/src/renderer/src/components/audio-preview-button.test.tsx b/electron/src/renderer/src/components/audio-preview-button.test.tsx
index 96e0c61e3..46a215dae 100644
--- a/electron/src/renderer/src/components/audio-preview-button.test.tsx
+++ b/electron/src/renderer/src/components/audio-preview-button.test.tsx
@@ -1,10 +1,6 @@
import { act, cleanup, fireEvent, render, screen } from '@testing-library/react';
import { afterEach, expect, it, vi } from 'vitest';
-type MockPlayer = { play: ReturnType<typeof vi.fn> };
-type Handlers = Record<string, (() => void) | undefined> & {
- src: { src: string };
- playerRef: { current: MockPlayer | null };
-};
+type Handlers = Record<string, (() => void) | undefined> & { src: { src: string } };
const players = vi.hoisted(() => ({ mounted: [] as Handlers[], live: null as Handlers | null }));
vi.mock('react-i18next', () => ({ useTranslation: () => ({ t: (key: string) => key }) }));
vi.mock('./media-player', async () => {
@@ -76,17 +72,3 @@ it('defers onReady until playback stops so a refetch cannot cut the clip', () =>
expect(onReady).toHaveBeenCalledTimes(1);
expect(screen.getByRole('button', { name: 'clone.preview_voice' })).toBeVisible();
});
-it('rebuilds a paused preview instead of replaying its discarded media instance', () => {
- render(<AudioPreviewButton src="/older-take.wav" source="take-older" />);
- fireEvent.click(screen.getByRole('button'));
- fire('onPlaying');
- fire('onPause');
- const stalePlay = vi.fn(async () => undefined);
- players.live!.playerRef.current = { play: stalePlay };
-
- fireEvent.click(screen.getByRole('button', { name: 'clone.preview_voice' }));
-
- expect(stalePlay).not.toHaveBeenCalled();
- expect(players.mounted).toHaveLength(2);
- expect(screen.getByRole('button', { name: 'common.loading · common.cancel' })).toBeEnabled();
-});
diff --git a/electron/src/renderer/src/components/audio-preview-button.tsx b/electron/src/renderer/src/components/audio-preview-button.tsx
index f641af7a2..46aa14879 100644
--- a/electron/src/renderer/src/components/audio-preview-button.tsx
+++ b/electron/src/renderer/src/components/audio-preview-button.tsx
@@ -74,13 +74,7 @@ function PreviewButton({
settle();
setStatus('idle');
} else if (status === 'playing') void player.current?.pause().catch(() => {});
- else {
- // History refreshes and another playback claim can leave the control in
- // its valid paused state after Vidstack has discarded the old provider.
- // Rebuild synchronously from this click: trying the stale provider first
- // loses the user gesture before the retry and Chromium rejects autoplay.
- start();
- }
+ else void player.current?.play().catch(() => setStatus('error'));
};
const resolved = fallback && fallbackSrc ? fallbackSrc : src;
const label =
diff --git a/electron/src/renderer/src/features/clone/output-panel.test.tsx b/electron/src/renderer/src/features/clone/output-panel.test.tsx
new file mode 100644
index 000000000..f3470a3cd
--- /dev/null
+++ b/electron/src/renderer/src/features/clone/output-panel.test.tsx
@@ -0,0 +1,56 @@
+import { cleanup, render, screen } from '@testing-library/react';
+import { afterEach, expect, it, vi } from 'vitest';
+
+const mocks = vi.hoisted(() => ({
+ output: vi.fn(),
+}));
+
+vi.mock('react-i18next', () => ({
+ useTranslation: () => ({ t: (key: string) => key }),
+}));
+vi.mock('@/lib/store/output', () => ({
+ useLatestOutput: mocks.output,
+ clearLatestOutput: vi.fn(),
+}));
+vi.mock('@/components/waveform-player', () => ({
+ WaveformPlayer: ({ src }: { src: string }) => <div data-testid="player" data-src={src} />,
+}));
+vi.mock('@/components/save-audio-button', () => ({ SaveAudioButton: () => null }));
+vi.mock('./audio-quality', () => ({ AudioQuality: () => null }));
+vi.mock('./audio-file-details', () => ({ AudioFileDetails: () => null }));
+
+import type { GenerateResult } from '@/lib/api/types';
+import { OutputPanel } from './output-panel';
+
+afterEach(() => {
+ cleanup();
+ vi.clearAllMocks();
+});
+
+function result(audioPath: string | null): GenerateResult {
+ return {
+ blob: new Blob(['audio'], { type: 'audio/wav' }),
+ id: 'take-1',
+ audioPath,
+ durationSeconds: 1,
+ genTimeSeconds: 2,
+ seed: 3,
+ routing: null,
+ dropped: null,
+ };
+}
+
+it('plays a completed take from its persistent audio path instead of a revocable blob URL', () => {
+ mocks.output.mockReturnValue({
+ result: result('take-1.wav'),
+ objectUrl: 'blob:http://localhost/revoked',
+ text: 'Hello',
+ });
+
+ render(<OutputPanel />);
+
+ expect(screen.getByTestId('player')).toHaveAttribute(
+ 'data-src',
+ '/api/audio/take-1.wav',
+ );
+});
diff --git a/electron/src/renderer/src/features/clone/output-panel.tsx b/electron/src/renderer/src/features/clone/output-panel.tsx
index 2502116a9..3a431e0f9 100644
--- a/electron/src/renderer/src/features/clone/output-panel.tsx
+++ b/electron/src/renderer/src/features/clone/output-panel.tsx
@@ -17,6 +17,7 @@ export function OutputPanel() {
if (!result || !objectUrl) return null;
const stamp = new Date().toISOString().slice(0, 19).replace(/[:T]/g, '-');
+ const playbackUrl = result.audioPath ? audioUrl(result.audioPath) : objectUrl;
return (
<section
@@ -48,11 +49,16 @@ export function OutputPanel() {
</Button>
</div>
</div>
- {result && objectUrl ? (
+ {result && playbackUrl ? (
<>
- <WaveformPlayer key={objectUrl} src={objectUrl} source="output" height={36} />
+ <WaveformPlayer
+ key={`player-${playbackUrl}`}
+ src={playbackUrl}
+ source="output"
+ height={36}
+ />
<AudioFileDetails blob={result.blob} />
- {result.audioPath && <AudioQuality key={objectUrl} audioPath={result.audioPath} />}
+ {result.audioPath && <AudioQuality audioPath={result.audioPath} />}
<div className="flex flex-wrap items-start justify-between gap-3">
<p
className="line-clamp-2 min-w-40 flex-1 text-sm text-muted-foreground"