Skip to content

VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.

fix(player): keep WaveSurfer off the media source so play state stays in sync

velixioa1adb7e6fa33
diff --git a/electron/src/renderer/src/components/waveform-player-source.test.tsx b/electron/src/renderer/src/components/waveform-player-source.test.tsx
new file mode 100644
index 000000000..dde02aa07
--- /dev/null
+++ b/electron/src/renderer/src/components/waveform-player-source.test.tsx
@@ -0,0 +1,51 @@
+import { afterEach, beforeEach, expect, it, vi } from 'vitest';
+import { cleanup, render } from '@testing-library/react';
+import { useEffect } from 'react';
+
+const mocks = vi.hoisted(() => ({ create: vi.fn() }));
+
+vi.mock('react-i18next', () => ({ useTranslation: () => ({ t: (key: string) => key }) }));
+vi.mock('@/hooks/use-theme', () => ({ useTheme: () => ({ theme: 'dark', paletteId: 'default' }) }));
+vi.mock('wavesurfer.js', () => ({ default: { create: mocks.create } }));
+vi.mock('@vidstack/react', () => ({ isAudioProvider: () => true }));
+vi.mock('./media-player', () => ({
+ audioSource: (src: string) => ({ src }),
+ audioLoaders: [],
+ MediaProvider: () => null,
+ useMediaState: (key: string) => (key === 'paused' ? true : 0),
+ StudioMediaPlayer: ({
+ children,
+ src,
+ onProviderChange,
+ }: {
+ children: React.ReactNode;
+ src: { src: string };
+ onProviderChange: (provider: { media: HTMLMediaElement }) => void;
+ }) => {
+ useEffect(() => {
+ const media = document.createElement('audio');
+ media.src = src.src; // what Vidstack's native provider does
+ onProviderChange({ media });
+ }, []);
+ return <>{children}</>;
+ },
+}));
+
+import { WaveformPlayer } from './waveform-player';
+
+beforeEach(() => {
+ mocks.create.mockImplementation(() => ({ on: vi.fn(), unAll: vi.fn(), destroy: vi.fn() }));
+});
+afterEach(() => {
+ cleanup();
+ vi.clearAllMocks();
+});
+
+it('never gives WaveSurfer a URL that differs from the loaded media source', () => {
+ render(<WaveformPlayer src="/api/audio/take-1.wav" />);
+
+ expect(mocks.create).toHaveBeenCalledTimes(1);
+ const { media, url } = mocks.create.mock.calls[0][0];
+ // A mismatch makes WaveSurfer replace the element's source behind Vidstack.
+ expect(url).toBe(media.currentSrc || media.src);
+});
diff --git a/electron/src/renderer/src/components/waveform-player.test.ts b/electron/src/renderer/src/components/waveform-player.test.ts
index 432f28ee3..05cfd353c 100644
--- a/electron/src/renderer/src/components/waveform-player.test.ts
+++ b/electron/src/renderer/src/components/waveform-player.test.ts
@@ -1,5 +1,5 @@
import { expect, it, vi } from 'vitest';
-import { subscribeMediaPaused } from './waveform-player';
+import { subscribeMediaPaused, waveformUrl } from './waveform-player';
it('tracks the native media element play and pause state for its button', () => {
const media = Object.assign(new EventTarget(), { paused: true });
@@ -18,3 +18,11 @@ it('tracks the native media element play and pause state for its button', () =>
media.dispatchEvent(new Event('playing'));
expect(onPaused).toHaveBeenCalledTimes(3);
});
+
+it('hands WaveSurfer the exact source the media element reports, so it never swaps it', () => {
+ const media = document.createElement('audio');
+ for (const src of ['/api/audio/take%201.wav', 'blob:http://localhost/abc', 'http://127.0.0.1:8000/api/audio/a.wav']) {
+ media.src = src;
+ expect(waveformUrl(src)).toBe(media.src);
+ }
+});
diff --git a/electron/src/renderer/src/components/waveform-player.tsx b/electron/src/renderer/src/components/waveform-player.tsx
index da139e2a3..defc5dc5f 100644
--- a/electron/src/renderer/src/components/waveform-player.tsx
+++ b/electron/src/renderer/src/components/waveform-player.tsx
@@ -49,6 +49,20 @@ export function waveColors(el: HTMLElement): { waveColor: string; progressColor:
return { waveColor: muted, progressColor: primary };
}
+/**
+ * The URL WaveSurfer must be given for a media element Vidstack already loaded.
+ * WaveSurfer compares it to `media.currentSrc`, which is always absolute; a
+ * relative `/api/audio/...` path never matches, so WaveSurfer swaps the element
+ * onto its own blob URL behind Vidstack and the play button and clock go stale.
+ */
+export function waveformUrl(src: string, base = document.baseURI): string {
+ try {
+ return new URL(src, base).href;
+ } catch {
+ return src;
+ }
+}
+
/** Keep controls aligned with the concrete audio element even if provider state is stale. */
export function subscribeMediaPaused(
media: HTMLMediaElement,
@@ -167,7 +181,7 @@ function WaveformControls({
const ws = WaveSurfer.create({
container: container.current,
media,
- url: src,
+ url: waveformUrl(src),
height,
...waveColors(container.current),
cursorWidth: 1,