Skip to content

VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.

fix(shell): follow the bell into the account corner in the sidebar smokes, keep a 12px gap

velixioe01dbdce73a5
diff --git a/electron/src/renderer/src/components/app-shell/account-corner.tsx b/electron/src/renderer/src/components/app-shell/account-corner.tsx
index 2976de3ea..294c6db65 100644
--- a/electron/src/renderer/src/components/app-shell/account-corner.tsx
+++ b/electron/src/renderer/src/components/app-shell/account-corner.tsx
@@ -5,6 +5,8 @@ import { AccountMenu } from './account-menu';
import { SystemNotifications } from './system-notifications';
const SPACE_VAR = '--corner-space';
+/** Clear space kept between a page's own title bar buttons and the corner. */
+const CORNER_GAP = 12;
/**
* The window's top-right corner, on every page: the account control (photo and
@@ -22,7 +24,7 @@ export function AccountCorner({ notificationsEnabled }: { notificationsEnabled:
const node = host.current;
const measure = () => {
if (node && node.childElementCount > 0)
- root.style.setProperty(SPACE_VAR, `${Math.ceil(node.offsetWidth) + 8}px`);
+ root.style.setProperty(SPACE_VAR, `${Math.ceil(node.offsetWidth) + CORNER_GAP}px`);
else root.style.removeProperty(SPACE_VAR);
};
measure();
diff --git a/electron/tests/native-bell-repro.mjs b/electron/tests/native-bell-repro.mjs
index 86f18b406..e3e2aabc5 100644
--- a/electron/tests/native-bell-repro.mjs
+++ b/electron/tests/native-bell-repro.mjs
@@ -35,7 +35,7 @@ try {
};
});
await page.goto((process.env.VOICESTUDIO_UI_URL || 'http://localhost:3902') + '/#/clone');
- const bell = page.locator('[data-slot=macos-system-notifications] button');
+ const bell = page.locator('[data-slot=account-corner] button:has(.lucide-bell)');
await bell.waitFor();
const rect = await bell.boundingBox();
const bounds = await app.evaluate(({ BrowserWindow }) => {
diff --git a/electron/tests/secondary-sidebar-smoke.mjs b/electron/tests/secondary-sidebar-smoke.mjs
index 8c9ee26ef..572e904b1 100644
--- a/electron/tests/secondary-sidebar-smoke.mjs
+++ b/electron/tests/secondary-sidebar-smoke.mjs
@@ -34,8 +34,11 @@ try {
if (width <= 1680) {
await compactMain.waitFor();
assert.equal(Math.round((await compactMain.boundingBox()).width), 48);
+ // The notifications bell lives in the top-right account corner on every page and
+ // platform, not in the sidebar.
+ assert.equal(await compactMain.locator("button .lucide-bell").count(), 0);
assert.equal(
- await compactMain.locator("button .lucide-bell").count(),
+ await page.locator('[data-slot="account-corner"] button .lucide-bell').count(),
1,
);
// Voice, Stories and Dubbing are flyout group buttons; the other five are direct links.
@@ -88,8 +91,9 @@ try {
.locator(".brand-sidebar")
.filter({ hasText: "Saved voices" });
assert.equal(await expandedMain.count(), 1);
+ assert.equal(await expandedMain.locator("button .lucide-bell").count(), 0);
assert.equal(
- await expandedMain.locator("button .lucide-bell").count(),
+ await page.locator('[data-slot="account-corner"] button .lucide-bell').count(),
1,
);
}
diff --git a/electron/tests/sidebar-layout-smoke.mjs b/electron/tests/sidebar-layout-smoke.mjs
index e9396f9ae..11727e84c 100644
--- a/electron/tests/sidebar-layout-smoke.mjs
+++ b/electron/tests/sidebar-layout-smoke.mjs
@@ -183,14 +183,14 @@ try {
});
await macPage.goto(ui + '/#/clone');
const macSidebar = macPage.locator('aside').first();
- const macNotifications = macPage.locator('[data-slot=macos-system-notifications]');
+ const macNotifications = macPage.locator('[data-slot=account-corner]');
const macNotificationBounds = await macNotifications.boundingBox();
assert.ok(
macNotificationBounds &&
macNotificationBounds.y < 20 &&
macNotificationBounds.x + macNotificationBounds.width >=
(await macPage.evaluate(() => window.innerWidth)) - 20,
- 'macOS notifications must sit in the top-right titlebar corner',
+ 'macOS account corner (account control and notifications) must sit in the top-right titlebar corner',
);
const titlebarActions = await macPage.locator('main .workspace-titlebar button').all();
const titlebarActionBounds = (
@@ -204,7 +204,7 @@ try {
),
'macOS titlebar actions must leave space before notifications',
);
- await macNotifications.getByRole('button').first().click();
+ await macNotifications.locator('button:has(.lucide-bell)').click();
await macPage.locator('[data-slot=popover-content][data-open]').waitFor({ state: 'visible' });
await macPage.keyboard.press('Escape');
const brandLink = macSidebar.getByRole('link', { name: /^VoiceStudio v\S+/ });