Skip to content

VoiceStudio is the open-source, fully-local ElevenLabs alternative — voice cloning, voice design, video dubbing, dictation, transcription & audiobook creation in 646 languages.

fix(ios): avoid duplicate app icons after merging App Store assets

debpalashfbf498454160
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 9c296bed7..f4cd199bf 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -495,7 +495,7 @@ jobs:
- name: Run smoke tests
# Exercise credential paths and the Windows accept guard natively.
if: matrix.backend_supported
- run: uv run --no-sync pytest tests/smoke/ tests/test_hf_token_cache_paths.py tests/test_win_accept_guard.py -q --tb=short
+ run: uv run --no-sync pytest tests/smoke/ tests/test_hf_token_cache_paths.py tests/test_win_accept_guard.py tests/test_ios_testflight.py -q --tb=short
env:
HF_HUB_OFFLINE: "1" # same no-silent-downloads guard as the main pytest job
HF_HUB_CACHE: ${{ runner.temp }}/pockettts-empty-hf-cache
diff --git a/docs/mobile.md b/docs/mobile.md
index c98890e0f..90cd5d7af 100644
--- a/docs/mobile.md
+++ b/docs/mobile.md
@@ -126,6 +126,8 @@ The workflow builds on the `macos-26` runner because App Store Connect accepts
only the current iOS SDK; the `mobile` workflow's iOS job uses the same runner.
The app icon is `Resources/Assets.xcassets/AppIcon.appiconset/AppIcon.png`, a
1024×1024 opaque PNG rendered from `mobile/ios/VoiceStudio/AppIcon.svg`.
+Generated `Brand.xcassets` supplies launch and Home artwork; it removes the former
+generated app icon so incremental builds also bundle exactly one icon catalog.
The version is the root `package.json` version without any `-beta.N` suffix
(App Store Connect accepts only `X.Y.Z`); the build number is the workflow run
diff --git a/mobile/ios/scripts/generate-brand-assets.swift b/mobile/ios/scripts/generate-brand-assets.swift
index 9d6d365b7..93c941ff7 100644
--- a/mobile/ios/scripts/generate-brand-assets.swift
+++ b/mobile/ios/scripts/generate-brand-assets.swift
@@ -1,4 +1,4 @@
-// Build-time rendering of the repository logo. No binary artwork is maintained in iOS.
+// Build-time launch artwork. The App Store icon lives in the app's bundled catalog.
import CoreGraphics
import Foundation
import ImageIO
@@ -46,8 +46,8 @@ func png(_ size: Int, at url: URL, background: String? = nil) throws {
let info: [String: Any] = ["author": "xcode", "version": 1]
try json(["info": info], at: output)
let icons = output.appendingPathComponent("AppIcon.appiconset")
-try json(["info": info, "images": [["filename": "AppIcon.png", "idiom": "universal", "platform": "ios", "size": "1024x1024"]]], at: icons)
-try png(1024, at: icons.appendingPathComponent("AppIcon.png"), background: colors["dark"]!["canvas"]!)
+// Remove the former generated icon too, so incremental builds do not retain two sets.
+if FileManager.default.fileExists(atPath: icons.path) { try FileManager.default.removeItem(at: icons) }
let launch = output.appendingPathComponent("LaunchLogo.imageset")
try json(["info": info, "images": (1...3).map { ["filename": "logo-\($0)x.png", "idiom": "universal", "scale": "\($0)x"] }], at: launch)
for scale in 1...3 { try png(128 * scale, at: launch.appendingPathComponent("logo-\(scale)x.png")) }
diff --git a/tests/test_ios_testflight.py b/tests/test_ios_testflight.py
index f84939481..c7e6c99d5 100644
--- a/tests/test_ios_testflight.py
+++ b/tests/test_ios_testflight.py
@@ -1,5 +1,6 @@
import importlib.util
import plistlib
+import sys
from pathlib import Path
import pytest
@@ -111,6 +112,18 @@ def test_app_icon_is_an_opaque_1024_png():
assert png[25] == 2, "App Store icons must be RGB without an alpha channel"
[email protected](sys.platform != "darwin", reason="Brand renderer uses macOS CoreGraphics")
+def test_generated_and_bundled_catalogs_have_one_app_icon(tmp_path):
+ generated = tmp_path / "Brand.xcassets"
+ # Simulate an incremental build made before the App Store icon was bundled.
+ (generated / "AppIcon.appiconset").mkdir(parents=True)
+ prepare_resources.prepare_brand_assets(generated)
+ icons = list((IOS / "Resources").rglob("AppIcon.appiconset"))
+ icons += list(generated.rglob("AppIcon.appiconset"))
+ assert len(icons) == 1, "Duplicate AppIcon catalogs make actool's icon selection ambiguous"
+ assert (generated / "LaunchLogo.imageset" / "logo-3x.png").is_file()
+
+
def test_mobile_ci_builds_ios_with_the_upload_toolchain():
mobile = yaml.load((ROOT / ".github/workflows/mobile.yml").read_text(), Loader=yaml.BaseLoader)
assert mobile["jobs"]["ios"]["runs-on"] == load_workflow()["jobs"]["testflight"]["runs-on"]