Skip to content

armgit / Vvveb

Public Imported from GitHub
0

Powerful and easy to use cms to build websites, blogs or ecommerce stores.

Check view_other_admin and edit_other_admin abilities for viewing and editing auth tokens role permission only for super admin, reported by @andy21190

givanz5adb8cde58b7
diff --git a/admin/controller/admin/auth-token.php b/admin/controller/admin/auth-token.php
index 44f2cdf..abfa606 100644
--- a/admin/controller/admin/auth-token.php
+++ b/admin/controller/admin/auth-token.php
@@ -35,30 +35,78 @@ class AuthToken extends Listing {
CrudTrait::delete as get;
}*/
- protected $type = 'admin_auth_token';
-
- protected $list = 'admin_auth_token';
-
- protected $listController = 'auth_token';
-
- protected $module = 'admin';
-
- function index() {
+ /**
+ * Auth token type identifier.
+ *
+ * @var string
+ */
+ protected string $type = 'admin_auth_token';
+
+ /**
+ * List key used to identify the data collection.
+ *
+ * @var string
+ */
+ protected string $list = 'admin_auth_token';
+
+ /**
+ * Plural controller name for listing views.
+ *
+ * @var string
+ */
+ protected string $listController = 'auth_token';
+
+ /**
+ * Module path this controller belongs to.
+ *
+ * @var string
+ */
+ protected string $module = 'admin';
+
+ /**
+ * Display the auth token list for a specific admin user.
+ *
+ * @return void
+ */
+ function index() : void {
$this->options['admin_id'] = $this->request->get['admin_id'] ?? false;
- $this->options['limit'] =1000;
+ $this->options['limit'] = 1000;
if (! $this->options['admin_id']) {
- return $this->notFound(__('User not found!'));
+ $this->notFound(__('User not found!'));
+ return;
}
+
+ if (!Admin::hasCapability('view_other_admin')) {
+ if ($this->options['admin_id'] || ($this->options['admin_id'] != $this->global['admin_id'])) {
+ $message = __('Permission denied!');
+ $this->view->errors[] = $message;
+ $this->notFound($message, 403, true);
+ }
+ }
+
$this->view->user_url = url(['module' => 'admin/user', 'admin_id' => $this->options['admin_id']]);
parent::index();
}
- function save() {
+ /**
+ * Save auth token data for a specific admin user.
+ *
+ * @return void
+ */
+ function save() : void {
$admin_auth_token = $this->request->post['admin_auth_token'] ?? [];
$admin_id = $this->request->get['admin_id'] ?? false;
+ $editCapability = 'edit_other_admin';
+ if (!Admin::hasCapability($editCapability)) {
+ if (! $admin_id || $admin_id != $this->global['admin_id']) {
+ $view->errors[] = __('Permission denied!');
+ return;
+ }
+ }
+
if ($admin_auth_token && $admin_id) {
foreach ($admin_auth_token as $key => $token) {
if ($key == '#') {