Skip to content

armgit / Vvveb

Public Imported from GitHub
0

Powerful and easy to use cms to build websites, blogs or ecommerce stores.

Added escape for menu items to avoid XSS for custom post types menu entries, vulnerability reported by @0xHamy

givanzb53c7161da60
diff --git a/admin/template/menu.tpl b/admin/template/menu.tpl
index cd14883..f8f856b 100755
--- a/admin/template/menu.tpl
+++ b/admin/template/menu.tpl
@@ -16,9 +16,9 @@ foreach($this->menu as $key => $menu_item) {
if (isset($menu_item['heading'])) $menu_item['url'] = 'javascript:void(0)';
?>
- @menu_item [data-v-menu-item-url]|href = $menu_item['url']
+ @menu_item [data-v-menu-item-url]|href = $menu_item['url']
@menu_item [data-v-menu-item-url]|title = $menu_item['name']
- @menu_item [data-v-menu-item-name] = $menu_item['name']
+ @menu_item [data-v-menu-item-name] = $menu_item['name']
@menu_item [data-v-menu-item-subtitle]|if_exists = $menu_item['subtitle']
@menu_item [data-v-menu-item-subtitle] = $menu_item['subtitle']
@@ -37,13 +37,13 @@ foreach($this->menu as $key => $menu_item) {
@menu_item|addClass = <?php
if (isset($menu_item['heading'])) echo 'heading';
- if (isset($menu_item['class'])) echo $menu_item['class'];
+ if (isset($menu_item['class'])) echo htmlspecialchars($menu_item['class']);
?>
@menu_item [data-v-menu-item-url]|addClass = <?php if (isset($menu_item['items'])) echo 'items';?>
@menu_item .mobile|addNewAttribute = <?php if (isset($menu_item['items'])) echo 'data-bs-toggle="dropdown"';?>
- @menu_item [data-v-menu-item-url]|data-target = <?php echo '#menu-' . $key;?>
+ @menu_item [data-v-menu-item-url]|data-target = <?php echo '#menu-' . htmlspecialchars($key);?>
- //@submenumenu_item|id = <?php echo '#menu-' . $key;?>
+ //@submenumenu_item|id = <?php echo '#menu-' . htmlspecialchars($key);?>
//@submenumenu_item|addClass = <?php echo 'dropdown-menu';?>
@submenumenu_item|addClass = <?php
if (isset($menu_item['show_on_modules']) && in_array($_GET['module'], $menu_item['show_on_modules'])) echo 'show';
@@ -58,7 +58,7 @@ foreach($this->menu as $key => $menu_item) {
@submenumenu_item [data-v-submenu-item]|addClass = <?php
if (isset($submenu_item['heading'])) echo ' heading';
- if (isset($submenu_item['class'])) echo $submenu_item['class'];
+ if (isset($submenu_item['class'])) echo htmlspecialchars($submenu_item['class']);
?>
@submenumenu_item [data-v-submenu-item]|before = <?php