Wallos: Open-source, self-hostable personal subscription tracker. Visualize your recurring expenses, manage your budget, and save money.
fix: sql injection vulnerability when using filters (#214)
Miguel Ribeirocbdc188e5e7a
diff --git a/endpoints/subscriptions/get.php b/endpoints/subscriptions/get.phpindex 1a0befb..4e3f5eb 100644--- a/endpoints/subscriptions/get.php+++ b/endpoints/subscriptions/get.php@@ -29,27 +29,33 @@}}+ $params = array();$sql = "SELECT * FROM subscriptions WHERE 1=1";if (isset($_GET['category']) && $_GET['category'] != "") {- $category = $_GET['category'];- $sql .= " AND category_id = $category";+ $sql .= " AND category_id = :category";+ $params[':category'] = $_GET['category'];}if (isset($_GET['payment']) && $_GET['payment'] != "") {- $payment = $_GET['payment'];- $sql .= " AND payment_method_id = $payment";+ $sql .= " AND payment_method_id = :payment";+ $params[':payment'] = $_GET['payment'];}if (isset($_GET['member']) && $_GET['member'] != "") {- $member = $_GET['member'];- $sql .= " AND payer_user_id = $member";+ $sql .= " AND payer_user_id = :member";+ $params[':member'] = $_GET['member'];}$sql .= " ORDER BY $sort $order, inactive ASC";-- $result = $db->query($sql);+ $stmt = $db->prepare($sql);++ foreach ($params as $key => $value) {+ $stmt->bindValue($key, $value);+ }++ $result = $stmt->execute();if ($result) {$subscriptions = array();while ($row = $result->fetchArray(SQLITE3_ASSOC)) {diff --git a/includes/version.php b/includes/version.phpindex aabf0f3..ac52646 100644--- a/includes/version.php+++ b/includes/version.php@@ -1,3 +1,3 @@<?php- $version = "v1.15.2";+ $version = "v1.15.3";?>\ No newline at end of file