Skip to content

Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.

9.7 KB
Raw Blame
package core

import (
	"strings"
	"testing"

	"github.com/stretchr/testify/require"
)

func TestClassifyCommandDetectsDeletes(t *testing.T) {
	const home = "/Users/dev"
	cases := []struct {
		command   string
		deletes   bool
		dangerous bool
	}{
		{"ls -la", false, false},
		{"echo hi > a.txt", false, false},
		{"docker run --rm alpine true", false, false},
		{"git status", false, false},
		{"rm a.txt", true, false},
		{"rm -f build/*.o", true, false},
		{"rmdir empty", true, false},
		{"unlink a.txt", true, false},
		{"/bin/rm a.txt", true, false},
		{"sudo rm a.txt", true, false},
		{"env FOO=1 rm a.txt", true, false},
		{"FOO=1 rm a.txt", true, false},
		{"find . -name '*.o' | xargs rm", true, false},
		{"git status && rm -rf dist", true, false},
		{"ls; rm a.txt", true, false},
		{"git rm a.txt", true, false},
		{"git -C repo rm a.txt", true, false},
		{"git clean -fdx", true, false},
		{`git -C "my repo" clean -fd`, true, false},
		{`git -C my\ repo clean -fd`, true, false},
		{"find . -name '*.tmp' -delete", true, false},
		{"find . -name '*.tmp' -exec rm {} +", true, false},
		{"find . -type f -print", false, false},
		{`bash -c "rm -rf out"`, true, false},
		{`bash -c "/bin/rm -rf out"`, true, false},
		{`bash -c "find . -delete"`, true, false},
		{`sh -c "git clean -fdx"`, true, false},
		{`eval "find /path -delete"`, true, false},
		{`zsh -lc "find . -exec rm {} +"`, true, false},
		{`bash -c "echo hi"`, false, false},
		{`bash -c "git status"`, false, false},
		{`bash -c "find . -type f -print"`, false, false},
		{`\rm -rf out`, true, false},
		{"rm a.txt; bash -c 'rm -rf .'", true, false},
		{`rm a.txt && sh -c "rm -rf ~"`, true, true},
		{"rm -rf ~", true, true},
		{"rm -rf ~/", true, true},
		{"rm -r $HOME", true, true},
		{"rm -Rf /Users/dev", true, true},
		{"rm --recursive /Users/dev/", true, true},
		{"rm -rf ~/*", true, true},
		{"rm -f ~", true, false},
		{"rm -rf ~/project/dist", true, false},
	}
	for _, tc := range cases {
		got := ClassifyCommand(tc.command, home)
		require.Equal(t, tc.deletes, got.Deletes, "deletes: %s", tc.command)
		require.Equal(t, tc.dangerous, got.Dangerous, "dangerous: %s", tc.command)
	}
}

func TestDeleteSegmentsKeepsOnlyTheDelete(t *testing.T) {
	got := DeleteSegments("git status && sudo rm -f a.txt && echo ok", "/Users/dev")
	require.Equal(t, []CommandSegment{{
		Text: "rm -f a.txt", Rule: DeleteRule{Program: "rm", Flags: []string{"-f"}},
	}}, got)
}

func TestDeleteSegmentsNormalizesTheProgramName(t *testing.T) {
	got := DeleteSegments("/bin/rm a.txt", "/Users/dev")
	require.Equal(t, []CommandSegment{{Text: "rm a.txt", Rule: DeleteRule{Program: "rm"}}}, got)
}

// The rule is the shape of the delete, like a Codex prefix rule: operands
// drop out, and option order or grouping does not matter.
func TestDeleteSegmentsDeriveARuleWithoutOperands(t *testing.T) {
	cases := []struct {
		command string
		rule    string
	}{
		{"rm a.txt", "rm"},
		{"rm a.txt b.txt", "rm"},
		{"rm -rf build", "rm -f -r"},
		{"rm -fr dist", "rm -f -r"},
		{"rm -r -f out", "rm -f -r"},
		{"sudo /bin/rm -f a", "rm -f"},
		{"rm --recursive --force a", "rm --force --recursive"},
		{"rm -- -f", "rm"},
		{"rmdir -p a/b", "rmdir -p"},
		{"unlink a", "unlink"},
		{"git rm --cached a.txt", "git rm --cached"},
		{"git -C repo clean -fdx", "git clean -d -f -x"},
		{`git -C "my repo" clean -fdx`, "git clean -d -f -x"},
		{"find . -name '*.o' -delete", "find -delete"},
		{"find src -type f -exec rm {} +", "find -exec rm"},
		{"ls | xargs -n 1 rm -f", "rm -f"},
	}
	for _, tc := range cases {
		got := DeleteSegments(tc.command, "/Users/dev")
		require.Len(t, got, 1, tc.command)
		require.Equal(t, tc.rule, got[0].Rule.String(), tc.command)
	}
}

// The sandbox needs to know where a delete lands before it runs, so a delete
// outside the workspace can ask for that directory on the same card.
func TestDeleteTargetsNamesTheOperandsOfVisibleDeletes(t *testing.T) {
	home := "/Users/dev"
	cases := []struct {
		command string
		want    []string
	}{
		{"rm a.txt", []string{"a.txt"}},
		{"rm -rf ~/Desktop/dir", []string{"/Users/dev/Desktop/dir"}},
		{"sudo rm -f $HOME/a ${HOME}/b ~", []string{"/Users/dev/a", "/Users/dev/b", "/Users/dev"}},
		{"rm -- -f", []string{"-f"}},
		{"ls && rmdir out && unlink /tmp/x", []string{"out", "/tmp/x"}},
		{"rm \"/Users/dev/My File.txt\" 'b c'", []string{"/Users/dev/My File.txt", "b c"}},
		{`rm my\ file.txt`, []string{"my file.txt"}},
		{"rm $TMPDIR/x", nil},
		{"git clean -fdx", nil},
		{"find . -delete", nil},
		{"echo hi", nil},
	}
	for _, tc := range cases {
		require.Equal(t, tc.want, DeleteTargets(tc.command, home), tc.command)
	}
}

func TestDeleteRuleCoversTheSameProgramWithFewerOptions(t *testing.T) {
	rf := DeleteRule{Program: "rm", Flags: []string{"-f", "-r"}}
	require.True(t, rf.Covers(DeleteRule{Program: "rm", Flags: []string{"-f", "-r"}}))
	require.True(t, rf.Covers(DeleteRule{Program: "rm", Flags: []string{"-r"}}))
	require.True(t, rf.Covers(DeleteRule{Program: "rm"}))
	require.False(t, rf.Covers(DeleteRule{Program: "rm", Flags: []string{"-f", "-r", "-v"}}))
	require.False(t, rf.Covers(DeleteRule{Program: "rmdir"}))
	require.False(t, DeleteRule{Program: "rm"}.Covers(rf), "a plain rm must not open a recursive one")
	require.False(t, DeleteRule{}.Covers(DeleteRule{}), "an empty rule covers nothing")
}

// Without these, an approved visible rm would let a hidden delete next to it
// run unasked.
func TestDeleteSegmentsTreatsSubstitutionsAndOtherShellsAsOpaque(t *testing.T) {
	for _, command := range []string{
		"rm a.txt; echo $(rm -rf .)",
		"rm a.txt; echo `rm -rf .`",
		"rm a.txt; cat <(rm -rf .)",
		"rm a.txt; dash -c 'rm -rf .'",
		"rm a.txt; ksh -c 'rm -rf .'",
		"echo $(rm -rf .)",
	} {
		got := DeleteSegments(command, "/Users/dev")
		require.Len(t, got, 1, command)
		require.True(t, got[0].Opaque, command)
		require.Equal(t, DeleteRule{}, got[0].Rule, command)
	}
}

// The shell assembles the program at run time, so the text cannot name it.
func TestDeleteSegmentsTreatsAnExpandedProgramAsOpaque(t *testing.T) {
	for _, command := range []string{
		"${RM:-rm} -rf build",
		"x=rm; $x -rf build",
		"$(printf rm) -rf build",
		"`echo rm` -rf build",
		"sudo $DEL_BIN unlink-me",
	} {
		got := DeleteSegments(command, "/Users/dev")
		require.Len(t, got, 1, command)
		require.True(t, got[0].Opaque, command)
		require.Nil(t, DeleteTargets(command, "/Users/dev"), command)
	}
	require.Empty(t, DeleteSegments("$PYTHON build.py", "/Users/dev"))
}

// A session rule ignores operands, so it may only cover deletes that stay
// strictly inside the cwd it was approved in.
func TestDeletesStayBelow(t *testing.T) {
	const home = "/Users/dev"
	const cwd = "/Users/dev/proj"
	cases := []struct {
		command string
		below   bool
	}{
		{"rm a.txt", true},
		{"rm -rf build dist/cache", true},
		{"rm -f *.log", true},
		{"rm -rf */node_modules", true},
		{"rm -rf /Users/dev/proj/build", true},
		{"ls | xargs rm -f", true},
		{"find . -name '*.tmp' -delete", true},
		{"find -name '*.tmp' -delete", true},
		{"find src -type f -exec rm {} +", true},
		{"git clean -fdx", true},
		{"git -C sub rm a.txt", true},
		{"echo hi", true},
		{"rm -rf .", false},
		{"rm -rf ./", false},
		{"rm -rf *", false},
		{"rm -rf .*", false},
		{"rm -rf ./*", false},
		{"rm -rf ..", false},
		{"rm -rf ../other", false},
		{"rm -rf build/../..", false},
		{"rm -rf /Users/dev/proj", false},
		{"rm -rf /Users/dev/Desktop/a", false},
		{"rm -rf ~/Desktop/*", false},
		{"rm -rf $DIR", false},
		{"rm a.txt && rm -rf ../x", false},
		{"find .. -delete", false},
		{"find /tmp -name x -delete", false},
		{"git -C .. clean -fdx", false},
		{"bash -c 'rm a.txt'", false},
	}
	for _, tc := range cases {
		require.Equal(t, tc.below, DeletesStayBelow(tc.command, cwd, home), tc.command)
	}
	require.False(t, DeletesStayBelow("rm a.txt", "", home))
}

func TestClassifyCommandProgramCaseFollowsTheFilesystem(t *testing.T) {
	const home = "/Users/dev"
	want := caseInsensitivePaths()
	for _, command := range []string{
		"RM -rf dir",
		"/bin/RM -rf dir",
		`BASH -c "find . -delete"`,
		"FIND . -delete",
		"GIT clean -fdx",
		"SUDO RM a.txt",
		`\RM -rf out`,
		"rm.exe a.txt",
		`RM.EXE -rf dir`,
	} {
		require.Equal(t, want, ClassifyCommand(command, home).Deletes, command)
	}
	require.Equal(t, want, ClassifyCommand("RM -rf ~", home).Dangerous)
	require.False(t, ClassifyCommand("docker run --RM alpine true", home).Deletes)
	require.False(t, ClassifyCommand("git CLEAN -fdx", home).Deletes)
	require.False(t, ClassifyCommand("FIND . -DELETE", home).Deletes)
	if want {
		require.Equal(t, []CommandSegment{{Text: "rm a.txt", Rule: DeleteRule{Program: "rm"}}},
			DeleteSegments("/bin/RM a.txt", home))
		require.Equal(t, []CommandSegment{{
			Text: "rm -rf ~", Dangerous: true, Rule: DeleteRule{Program: "rm", Flags: []string{"-f", "-r"}},
		}}, DeleteSegments("RM -rf ~", home))
	} else {
		require.Empty(t, DeleteSegments("/bin/RM a.txt", home))
	}
}

func TestDeleteSegmentsKeepsAQuotedDeleteAsTheWholeCommand(t *testing.T) {
	got := DeleteSegments(`bash -c "rm -rf out"`, "/Users/dev")
	require.Equal(t, []CommandSegment{{
		Text: `bash -c "rm -rf out"`, Opaque: true,
	}}, got)
}

func TestDeleteSegmentsDoesNotLetAVisibleRmCoverAHiddenOne(t *testing.T) {
	home := "/Users/dev"
	cases := []struct {
		command   string
		dangerous bool
	}{
		{"rm a.txt; bash -c 'rm -rf .'", false},
		{`rm a.txt && sh -c "rm -rf ~"`, true},
		{`bash -c "/bin/rm -rf out"`, false},
		{`\rm -rf out`, false},
		{`bash -c "find . -delete"`, false},
		{`sh -c "git clean -fdx"`, false},
		{`eval "find /path -delete"`, false},
		{"rm a.txt; bash -c 'find . -delete'", false},
	}
	for _, tc := range cases {
		got := DeleteSegments(tc.command, home)
		require.Equal(t, []CommandSegment{{
			Text:      strings.Join(strings.Fields(tc.command), " "),
			Dangerous: tc.dangerous,
			Opaque:    true,
		}}, got, tc.command)
	}
}