Skip to content

Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.

25.3 KB
Raw Blame
package sandbox

import (
	"context"
	"errors"
	"net/http"
	"testing"
	"time"

	cubesandbox "github.com/tencentcloud/CubeSandbox/sdk/go"

	"github.com/Tencent/WeKnora/internal/types"
	"github.com/stretchr/testify/require"
)

// newTestCubeRemoteClient wires a real CubeRemoteClient at the cubeMockServer.
// Tests exercise the adapter through its public RemoteSandboxClient surface
// only — no intermediate backend interfaces exist below CubeRemoteClient.
func newTestCubeRemoteClient(t *testing.T, mock *cubeMockServer) *CubeRemoteClient {
	t.Helper()
	client, err := NewCubeRemoteClient(testConfig(t, mock))
	require.NoError(t, err)
	return client
}

func TestCubeRemoteClientProviderAndCapabilities(t *testing.T) {
	client := newTestCubeRemoteClient(t, newCubeMockServer(t))

	require.Equal(t, SandboxTypeCube, client.Provider())
	require.Equal(t, RemoteSandboxCapabilities{
		SupportsReconnect:             true,
		SupportsMetadata:              true,
		SupportsListSandboxes:         true,
		SupportsPauseResume:           true,
		SupportsTimeoutRefresh:        true,
		SupportsFilesystemEnumeration: true,
		SupportsSnapshots:             true,
		SupportsTerminals:             true,
		SupportsDesktop:               true,
	}, client.Capabilities())
}

func TestCubeCommandTimeoutIsIndependentOfHTTPTimeout(t *testing.T) {
	mock := newCubeMockServer(t)
	mock.executor = func(string, string, []string) (string, string, int) {
		time.Sleep(300 * time.Millisecond)
		return "finished", "", 0
	}
	cfg := testConfig(t, mock)
	cfg.CubeHTTPTimeout = 100 * time.Millisecond
	client, err := NewCubeRemoteClient(cfg)
	require.NoError(t, err)
	handle, err := client.Create(context.Background(), RemoteCreateRequest{TemplateID: "template-a"})
	require.NoError(t, err)
	result, err := client.Exec(context.Background(), handle, RemoteExecRequest{
		Command: "slow command", Shell: true, Timeout: 2 * time.Second,
	})
	require.NoError(t, err)
	require.Equal(t, "finished", result.Stdout)
	require.False(t, result.Killed)
}

func TestCubeRemoteClientCreateSnapshot(t *testing.T) {
	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)
	ctx := context.Background()
	handle, err := client.Create(ctx, RemoteCreateRequest{TemplateID: "template-a"})
	require.NoError(t, err)

	ref, err := client.CreateSnapshot(ctx, handle.ID(), "weknora-sk-cfg1-g1")

	require.NoError(t, err)
	require.Equal(t, "snap-1", ref.ID)
	require.Equal(t, []string{"weknora-sk-cfg1-g1"}, ref.Names)
	mock.mu.Lock()
	body := mock.snapshotCreateBody
	mock.mu.Unlock()
	require.Equal(t, "weknora-sk-cfg1-g1", body["name"])
}

func TestCubeRemoteClientCreateSnapshotRejectsEmptySandboxID(t *testing.T) {
	client := newTestCubeRemoteClient(t, newCubeMockServer(t))

	_, err := client.CreateSnapshot(context.Background(), "  ", "n")

	require.Error(t, err)
	require.True(t, IsRemoteInvalidRequest(err))
}

func TestCubeRemoteClientDeleteSnapshotTreatsMissingAsSuccess(t *testing.T) {
	client := newTestCubeRemoteClient(t, newCubeMockServer(t))

	err := client.DeleteSnapshot(context.Background(), "snap-missing")

	require.NoError(t, err, "a missing snapshot must not fail the delete path")
}

func TestCubeRemoteClientDeleteSnapshotRejectsEmptySnapshotID(t *testing.T) {
	client := newTestCubeRemoteClient(t, newCubeMockServer(t))

	err := client.DeleteSnapshot(context.Background(), "  ")

	require.Error(t, err)
	require.True(t, IsRemoteInvalidRequest(err))
}

func TestCubeRemoteClientDeleteSnapshotReturnsUnexpectedErrors(t *testing.T) {
	mock := newCubeMockServer(t)
	mock.snapshotDeleteFailWith = http.StatusInternalServerError
	client := newTestCubeRemoteClient(t, mock)

	err := client.DeleteSnapshot(context.Background(), "snap-any")

	require.Error(t, err)
	require.False(t, IsRemoteNotFound(err))
}

func TestCubeRemoteClientListSnapshotsRejectsStuckPagination(t *testing.T) {
	mock := newCubeMockServer(t)
	mock.snapshotStuckPagination = true
	client := newTestCubeRemoteClient(t, mock)
	ctx, cancel := context.WithTimeout(context.Background(), 2*time.Second)
	defer cancel()

	_, err := client.ListSnapshots(ctx, "")

	require.Error(t, err)
	require.True(t, IsRemoteInvalidRequest(err))
}

func TestCubeRemoteClientListSnapshotsPagesAllResults(t *testing.T) {
	mock := newCubeMockServer(t)
	mock.snapshotPageSize = 1
	client := newTestCubeRemoteClient(t, mock)
	ctx := context.Background()
	first, err := client.Create(ctx, RemoteCreateRequest{TemplateID: "template-a"})
	require.NoError(t, err)
	second, err := client.Create(ctx, RemoteCreateRequest{TemplateID: "template-a"})
	require.NoError(t, err)
	firstRef, err := client.CreateSnapshot(ctx, first.ID(), "weknora-sk-cfg1-g1")
	require.NoError(t, err)
	secondRef, err := client.CreateSnapshot(ctx, first.ID(), "weknora-sk-cfg2-g1")
	require.NoError(t, err)
	_, err = client.CreateSnapshot(ctx, second.ID(), "other")
	require.NoError(t, err)

	list, err := client.ListSnapshots(ctx, first.ID())

	require.NoError(t, err)
	require.Equal(t, []RemoteSnapshotRef{firstRef, secondRef}, list)
}

func TestCubeRemoteClientCreateWritesLifecyclePayload(t *testing.T) {
	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)

	handle, err := client.Create(context.Background(), RemoteCreateRequest{
		TemplateID: "template-a",
		Timeout: RemoteTimeoutPolicy{
			Mode:       RemoteTimeoutExplicit,
			Value:      15 * time.Minute,
			Action:     RemoteOnTimeoutPause,
			AutoResume: true,
		},
		Metadata: map[string]string{"owner": "session-a"},
		EnvVars:  map[string]string{"LANG": "C.UTF-8"},
	})
	require.NoError(t, err)
	require.NotEmpty(t, handle.ID())
	require.Equal(t, SandboxTypeCube, handle.Provider())
	require.Equal(t, map[string]string{"owner": "session-a"}, handle.Metadata())

	mock.mu.Lock()
	body := mock.createBody
	mock.mu.Unlock()
	require.Equal(t, "template-a", body["templateID"])
	require.Equal(t, float64(900), body["timeout"])
	require.Equal(t, map[string]any{"owner": "session-a"}, body["metadata"])
	require.Equal(t, map[string]any{"LANG": "C.UTF-8"}, body["envVars"])
	require.Equal(t, map[string]any{
		"onTimeout":  "pause",
		"autoResume": true,
	}, body["lifecycle"])
}

// Counterpart to the E2B test of the same name. resolveNetworkPolicy
// materialises DenyEgressByDefault into an explicit deny-all entry, and both
// adapters must put it on the wire — otherwise the two providers drift and only
// one of them enforces what the admin ticked.
func TestCubeRemoteClientCreateSendsDenyAllForStoredDenyByDefault(t *testing.T) {
	tenantCfg := completeCubeTenantConfig()
	tenantCfg.Network = &types.SandboxNetworkPolicy{
		DenyEgressByDefault: true,
		AllowOut:            []string{"*.example.com"},
	}
	effective, err := ResolveEffectiveConfig(tenantCfg, DefaultConfig())
	require.NoError(t, err)

	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)

	_, err = client.Create(context.Background(), RemoteCreateRequest{
		TemplateID: "template-a",
		Network:    effective.Network,
	})
	require.NoError(t, err)

	mock.mu.Lock()
	body := mock.createBody
	mock.mu.Unlock()
	require.Equal(t, false, body["allowInternetAccess"])
	networkPayload := body["network"].(map[string]any)
	require.Equal(t, []any{"*.example.com"}, networkPayload["allowOut"])
	require.Equal(t, []any{"0.0.0.0/0"}, networkPayload["denyOut"])
}

func TestCubeRemoteClientCreateForwardsNetworkPolicy(t *testing.T) {
	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)
	deny := false
	privateSandbox := false

	_, err := client.Create(context.Background(), RemoteCreateRequest{
		TemplateID: "template-a",
		Network: RemoteNetworkPolicy{
			AllowInternetAccess: &deny,
			AllowPublicTraffic:  &privateSandbox,
			AllowOut:            []string{"*.example.com"},
			DenyOut:             []string{"0.0.0.0/0"},
			CubeRules: []RemoteCubeEgressRule{{
				Name:    "allow-payment-api",
				Scheme:  "https",
				SNI:     "pay.example.com",
				Host:    "pay.example.com",
				Methods: []string{"POST"},
				Path:    "/api/payments/*",
				Allow:   true,
				Audit:   "full",
				Inject: []RemoteHeaderInject{{
					Header: "Authorization",
					Secret: "tok",
					Format: "Bearer ${SECRET}",
				}},
			}, {
				Name:  "deny-uploads",
				SNI:   "uploads.example.com",
				Allow: false,
			}},
		},
	})
	require.NoError(t, err)

	mock.mu.Lock()
	body := mock.createBody
	mock.mu.Unlock()
	require.Equal(t, false, body["allowInternetAccess"])
	networkPayload, ok := body["network"].(map[string]any)
	require.True(t, ok, "network payload missing: %#v", body["network"])
	require.Equal(t, false, networkPayload["allowPublicTraffic"])
	require.Equal(t, []any{"*.example.com"}, networkPayload["allowOut"])
	require.Equal(t, []any{"0.0.0.0/0"}, networkPayload["denyOut"])

	rules, ok := networkPayload["rules"].([]any)
	require.True(t, ok, "rules payload missing: %#v", networkPayload["rules"])
	require.Len(t, rules, 2)

	first := rules[0].(map[string]any)
	require.Equal(t, "allow-payment-api", first["name"])
	match := first["match"].(map[string]any)
	require.Equal(t, "https", match["scheme"])
	require.Equal(t, "pay.example.com", match["sni"])
	require.Equal(t, "pay.example.com", match["host"])
	require.Equal(t, []any{"POST"}, match["method"])
	require.Equal(t, "/api/payments/*", match["path"])
	action := first["action"].(map[string]any)
	require.Equal(t, true, action["allow"])
	require.Equal(t, "full", action["audit"])
	inject := action["inject"].([]any)[0].(map[string]any)
	require.Equal(t, "Authorization", inject["header"])
	require.Equal(t, "tok", inject["secret"])
	require.Equal(t, "Bearer ${SECRET}", inject["format"])

	// A deny rule must still be sent: it is what gets the target into
	// CubeEgress so the proxy can answer 403 instead of the network dropping
	// the packet.
	second := rules[1].(map[string]any)
	require.Equal(t, false, second["action"].(map[string]any)["allow"])
}

// WeKnora's default deliberately differs from Cube's: an unspecified policy
// closes inbound access, because "anyone who knows the sandbox ID" used to be
// the only barrier in front of the sandbox URL. Egress stays open so skill
// installs keep working.
func TestCubeRemoteClientCreateDefaultsInboundClosed(t *testing.T) {
	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)

	_, err := client.Create(context.Background(), RemoteCreateRequest{TemplateID: "template-a"})
	require.NoError(t, err)

	mock.mu.Lock()
	body := mock.createBody
	mock.mu.Unlock()
	require.Equal(t, true, body["allowInternetAccess"])
	networkPayload := body["network"].(map[string]any)
	require.Equal(t, false, networkPayload["allowPublicTraffic"])
	require.NotContains(t, networkPayload, "rules")
}

func TestCubeRemoteHandleExposesTrafficAccessToken(t *testing.T) {
	mock := newCubeMockServer(t)
	mock.trafficAccessToken = "traffic-token"
	client := newTestCubeRemoteClient(t, mock)

	handle, err := client.Create(context.Background(), RemoteCreateRequest{TemplateID: "template-a"})
	require.NoError(t, err)

	require.Equal(t, "traffic-token", InboundTokenOf(handle))
	require.Empty(t, InboundTokenOf(
		&contractHandle{id: "e2b-1", provider: SandboxTypeE2B},
	))
}

// The provider issues the traffic token once, at create time. Everything that
// re-attaches later — auto-resume, a WeKnora restart, an artifact download —
// has to put it back or every data-plane call answers 403.
func TestCubeRemoteClientConnectRestoresTrafficAccessToken(t *testing.T) {
	mock := newCubeMockServer(t)
	// Deliberately empty: Cube does not repeat the token on connect.
	mock.trafficAccessToken = ""
	client := newTestCubeRemoteClient(t, mock)
	created, err := client.Create(context.Background(), RemoteCreateRequest{
		TemplateID: "template-a",
	})
	require.NoError(t, err)

	handle, err := client.Connect(context.Background(), RemoteConnectRequest{
		SandboxID:          created.ID(),
		TrafficAccessToken: "recovered-token",
	})
	require.NoError(t, err)

	carrier, ok := handle.(RemoteInboundTokenCarrier)
	require.True(t, ok)
	require.Equal(t, "recovered-token", carrier.TrafficAccessToken())
}

// A provider that does return one wins: it is fresher than our copy.
func TestCubeRemoteClientConnectKeepsProviderToken(t *testing.T) {
	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)
	created, err := client.Create(context.Background(), RemoteCreateRequest{
		TemplateID: "template-a",
	})
	require.NoError(t, err)
	mock.connectTrafficToken = "provider-token"

	handle, err := client.Connect(context.Background(), RemoteConnectRequest{
		SandboxID:          created.ID(),
		TrafficAccessToken: "recovered-token",
	})
	require.NoError(t, err)
	require.Equal(t, "provider-token",
		handle.(RemoteInboundTokenCarrier).TrafficAccessToken())
}

func TestCubeRemoteClientCreatePreservesTimeoutModes(t *testing.T) {
	t.Run("server default omits timeout", func(t *testing.T) {
		mock := newCubeMockServer(t)
		client := newTestCubeRemoteClient(t, mock)
		_, err := client.Create(context.Background(), RemoteCreateRequest{
			TemplateID: "template-a",
			Timeout: RemoteTimeoutPolicy{
				Mode:   RemoteTimeoutServerDefault,
				Action: RemoteOnTimeoutKill,
			},
		})
		require.NoError(t, err)
		mock.mu.Lock()
		body := mock.createBody
		mock.mu.Unlock()
		_, hasTimeout := body["timeout"]
		require.False(t, hasTimeout)
	})

	t.Run("negative means never", func(t *testing.T) {
		mock := newCubeMockServer(t)
		client := newTestCubeRemoteClient(t, mock)
		_, err := client.Create(context.Background(), RemoteCreateRequest{
			TemplateID: "template-a",
			Timeout: RemoteTimeoutPolicy{
				Mode:   RemoteTimeoutExplicit,
				Value:  -time.Hour,
				Action: RemoteOnTimeoutKill,
			},
		})
		require.NoError(t, err)
		mock.mu.Lock()
		body := mock.createBody
		mock.mu.Unlock()
		// Cube's three-value semantics send -1 verbatim as "never timeout".
		require.Equal(t, float64(-1), body["timeout"])
	})

	t.Run("auto resume requires pause", func(t *testing.T) {
		client := newTestCubeRemoteClient(t, newCubeMockServer(t))
		_, err := client.Create(context.Background(), RemoteCreateRequest{
			TemplateID: "template-a",
			Timeout: RemoteTimeoutPolicy{
				Mode:       RemoteTimeoutExplicit,
				Value:      time.Minute,
				Action:     RemoteOnTimeoutKill,
				AutoResume: true,
			},
		})
		require.True(t, IsRemoteInvalidRequest(err))
	})

	t.Run("missing template rejected before wire", func(t *testing.T) {
		mock := newCubeMockServer(t)
		client := newTestCubeRemoteClient(t, mock)
		_, err := client.Create(context.Background(), RemoteCreateRequest{})
		require.True(t, IsRemoteInvalidRequest(err))
		require.Zero(t, mock.createCount.Load())
	})
}

func TestCubeRemoteClientLifecycleRoundTrip(t *testing.T) {
	mock := newCubeMockServer(t)
	mock.trafficAccessToken = "create-only-traffic-token"
	client := newTestCubeRemoteClient(t, mock)
	ctx := context.Background()

	handle, err := client.Create(ctx, RemoteCreateRequest{
		TemplateID: "template-a",
		Timeout: RemoteTimeoutPolicy{
			Mode:   RemoteTimeoutExplicit,
			Value:  time.Minute,
			Action: RemoteOnTimeoutKill,
		},
	})
	require.NoError(t, err)

	summary, err := client.Get(ctx, handle.ID())
	require.NoError(t, err)
	require.Equal(t, handle.ID(), summary.ID)
	require.Equal(t, RemoteStateRunning, summary.State)

	list, err := client.List(ctx, RemoteListFilter{
		States: []RemoteSandboxState{RemoteStateRunning},
	})
	require.NoError(t, err)
	require.Len(t, list, 1)
	require.Equal(t, handle.ID(), list[0].ID)

	reconnected, err := client.Connect(ctx, RemoteConnectRequest{SandboxID: handle.ID()})
	require.NoError(t, err)
	require.Equal(t, handle.ID(), reconnected.ID())
	require.Empty(t, InboundTokenOf(reconnected),
		"Cube connect responses do not repeat the create-time traffic token")

	require.NoError(t, client.Delete(ctx, handle.ID()))
	require.Equal(t, int32(1), mock.killCount.Load())
	mock.mu.Lock()
	_, stillAlive := mock.sandboxes[handle.ID()]
	mock.mu.Unlock()
	require.False(t, stillAlive)
}

func TestCubeRemoteClientExecArgvAndShell(t *testing.T) {
	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)
	ctx := context.Background()

	var (
		gotCmd  string
		gotArgs []string
	)
	mock.SetExecutor(func(_, cmd string, args []string) (string, string, int) {
		gotCmd = cmd
		gotArgs = args
		return "ok\n", "", 0
	})

	handle, err := client.Create(ctx, RemoteCreateRequest{
		TemplateID: "template-a",
		Timeout: RemoteTimeoutPolicy{
			Mode:   RemoteTimeoutServerDefault,
			Action: RemoteOnTimeoutKill,
		},
	})
	require.NoError(t, err)

	// Argv → cubeClient assembles /bin/bash -l -c "<shell-quoted argv>". The
	// mock records the wrapper argv, which lets us assert both the wrapper
	// shape and that the caller's arguments are shell-quoted (not lost).
	result, err := client.Exec(ctx, handle, RemoteExecRequest{
		Command: "python3",
		Args:    []string{"script.py", "argument with spaces"},
	})
	require.NoError(t, err)
	require.Equal(t, 0, result.ExitCode)
	require.Contains(t, result.Stdout, "ok")
	require.Equal(t, "/bin/bash", gotCmd)
	require.Len(t, gotArgs, 3)
	require.Equal(t, "-l", gotArgs[0])
	require.Equal(t, "-c", gotArgs[1])
	require.Contains(t, gotArgs[2], "python3")
	require.Contains(t, gotArgs[2], "'argument with spaces'")

	// Shell → the caller's raw expression is passed through verbatim.
	gotCmd, gotArgs = "", nil
	mock.SetExecutor(func(_, cmd string, args []string) (string, string, int) {
		gotCmd = cmd
		gotArgs = args
		return "shell\n", "", 0
	})
	_, err = client.Exec(ctx, handle, RemoteExecRequest{
		Command: "printf '%s' ok | cat",
		Shell:   true,
	})
	require.NoError(t, err)
	require.Equal(t, "/bin/bash", gotCmd)
	require.Equal(t, "printf '%s' ok | cat", gotArgs[2])

	// Shell + argv is mutually exclusive.
	_, err = client.Exec(ctx, handle, RemoteExecRequest{
		Command: "echo",
		Args:    []string{"unsafe ambiguity"},
		Shell:   true,
	})
	require.True(t, IsRemoteInvalidRequest(err))
}

func TestCubeRemoteClientExecForwardsBufferedOutput(t *testing.T) {
	mock := newCubeMockServer(t)
	mock.SetExecutor(func(string, string, []string) (string, string, int) {
		return "out-line\n", "err-line\n", 0
	})
	client := newTestCubeRemoteClient(t, mock)
	ctx := context.Background()
	handle, err := client.Create(ctx, RemoteCreateRequest{TemplateID: "template-a"})
	require.NoError(t, err)

	var got []string
	result, err := client.Exec(ctx, handle, RemoteExecRequest{
		Command: "printf '%s' ok",
		Shell:   true,
		OnOutput: func(stream string, chunk []byte) {
			got = append(got, stream+":"+string(chunk))
		},
	})
	require.NoError(t, err)
	require.Equal(t, "out-line\n", result.Stdout)
	require.Equal(t, "err-line\n", result.Stderr)
	require.Equal(t, []string{"stdout:out-line\n", "stderr:err-line\n"}, got)
}

func TestCubeRemoteClientExecTimeoutIsKilled(t *testing.T) {
	mock := newCubeMockServer(t)
	// A slow executor lets the outer request timeout fire before the mock
	// returns a stream. cubeClient's RunCommand cancellation path then
	// synthesises Killed=true, ExitCode=-1.
	mock.SetExecutor(func(string, string, []string) (string, string, int) {
		time.Sleep(200 * time.Millisecond)
		return "", "", 0
	})
	client := newTestCubeRemoteClient(t, mock)
	ctx := context.Background()

	handle, err := client.Create(ctx, RemoteCreateRequest{
		TemplateID: "template-a",
	})
	require.NoError(t, err)

	result, err := client.Exec(ctx, handle, RemoteExecRequest{
		Command: "sleep",
		Args:    []string{"10"},
		Timeout: 20 * time.Millisecond,
	})
	require.NoError(t, err)
	require.NotNil(t, result)
	require.True(t, result.Killed)
	require.Equal(t, -1, result.ExitCode)
}

func TestCubeRemoteClientFileWriteRoundTrip(t *testing.T) {
	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)
	ctx := context.Background()

	handle, err := client.Create(ctx, RemoteCreateRequest{TemplateID: "template-a"})
	require.NoError(t, err)

	require.NoError(t, client.WriteFile(ctx, handle, "/workspace/hello.txt", []byte("hi")))
	require.NoError(t, client.MakeDir(ctx, handle, "/workspace/nested"))

	mock.mu.Lock()
	files := mock.files[handle.ID()]
	mock.mu.Unlock()
	require.Equal(t, "hi", string(files["/workspace/hello.txt"]))
}

func TestCubeRemoteClientRejectsForeignHandle(t *testing.T) {
	client := newTestCubeRemoteClient(t, newCubeMockServer(t))
	_, err := client.ReadFile(
		context.Background(),
		&contractHandle{id: "e2b-1", provider: SandboxTypeE2B},
		"/workspace/file",
	)
	require.True(t, IsRemoteInvalidRequest(err))
}

func TestCubeRemoteClientListFilters(t *testing.T) {
	mock := newCubeMockServer(t)
	client := newTestCubeRemoteClient(t, mock)
	ctx := context.Background()

	handle, err := client.Create(ctx, RemoteCreateRequest{
		TemplateID: "template-a",
		Metadata:   map[string]string{"owner": "keep"},
	})
	require.NoError(t, err)
	_, err = client.Create(ctx, RemoteCreateRequest{
		TemplateID: "template-a",
		Metadata:   map[string]string{"owner": "other"},
	})
	require.NoError(t, err)

	list, err := client.List(ctx, RemoteListFilter{
		Metadata: map[string]string{"owner": "keep"},
	})
	require.NoError(t, err)
	require.Len(t, list, 1)
	require.Equal(t, handle.ID(), list[0].ID)
}

func TestNormalizeCubeState(t *testing.T) {
	tests := map[string]RemoteSandboxState{
		"running":    RemoteStateRunning,
		"paused":     RemoteStatePaused,
		"pausing":    RemoteStateTransitioning,
		"resuming":   RemoteStateTransitioning,
		"pending":    RemoteStateTransitioning,
		"killing":    RemoteStateTerminal,
		"killed":     RemoteStateTerminal,
		"terminated": RemoteStateTerminal,
		"deleted":    RemoteStateTerminal,
		"failed":     RemoteStateTerminal,
		"":           RemoteStateUnknown,
		"weird":      RemoteStateUnknown,
	}
	for raw, want := range tests {
		require.Equalf(t, want, normalizeCubeState(raw), "state %q", raw)
	}
}

func TestNormalizeCubeError(t *testing.T) {
	tests := []struct {
		name string
		op   string
		err  error
		kind RemoteErrorKind
	}{
		{"sandbox not found", "Get", cubesandbox.ErrSandboxNotFound, RemoteErrorKindNotFound},
		{"template not found", "Create", cubesandbox.ErrTemplateNotFound, RemoteErrorKindInvalidRequest},
		{"authentication", "Health", cubesandbox.ErrAuthentication, RemoteErrorKindAuthentication},
		{"path not found", "Stat", &cubesandbox.NotFoundError{Path: "/x"}, RemoteErrorKindNotFound},
		{"list missing session dir", "ListDir", errors.New(
			"failed to list /workspace/sessions/f2e82fcb-abf8-4677-9567-5e20d6cbcb1f/input: " +
				"path not found: lstat /workspace/sessions/f2e82fcb-abf8-4677-9567-5e20d6cbcb1f: " +
				"no such file or directory"), RemoteErrorKindNotFound},
		{"gone", "Get", &cubesandbox.APIError{StatusCode: http.StatusGone}, RemoteErrorKindTerminal},
		{"conflict", "Connect", &cubesandbox.APIError{StatusCode: http.StatusConflict}, RemoteErrorKindConflict},
		{"rate limited", "Create", &cubesandbox.APIError{StatusCode: http.StatusTooManyRequests}, RemoteErrorKindCapacity},
		{"bad gateway", "List", &cubesandbox.APIError{StatusCode: http.StatusBadGateway}, RemoteErrorKindUnavailable},
		{"deadline", "Exec", context.DeadlineExceeded, RemoteErrorKindTimeout},
		{"unknown", "List", errors.New("unknown"), RemoteErrorKindInternal},
		{"delete snapshot in use", "DeleteSnapshot", &cubesandbox.APIError{
			StatusCode: http.StatusBadRequest,
			Message:    "cannot delete template x because there are paused sandboxes using it",
		}, RemoteErrorKindConflict},
		{"delete snapshot runtime refs", "DeleteSnapshot", &cubesandbox.APIError{
			StatusCode: http.StatusInternalServerError,
			Message: "CubeMaster returned error code 130409: template attempt is already in progress: " +
				"snapshot snap-x still has 2 active runtime ref(s): a@host, b@host",
		}, RemoteErrorKindConflict},
		{"delete snapshot bad id", "DeleteSnapshot", &cubesandbox.APIError{
			StatusCode: http.StatusBadRequest,
			Message:    "invalid snapshot id",
		}, RemoteErrorKindInvalidRequest},
	}

	for _, tt := range tests {
		t.Run(tt.name, func(t *testing.T) {
			err := normalizeCubeError(tt.op, tt.err)
			var remoteErr *RemoteError
			require.ErrorAs(t, err, &remoteErr)
			require.Equal(t, tt.kind, remoteErr.Kind)
			require.Equal(t, SandboxTypeCube, remoteErr.Provider)
			require.ErrorIs(t, err, tt.err)
		})
	}
}

func TestCubeDesktopTemplateSpecDoesNotNatWebsockify(t *testing.T) {
	spec := cubeDesktopTemplateSpec(nil)

	require.Equal(t, DefaultCubeDesktopTemplateImage, spec["image"])
	require.Equal(t, DesktopTemplateName, spec["name"])
	// envd stays in exposedPorts so the template probe can reach :49983.
	// 6080 must not: Cube NATs that list onto the host NIC and bypasses
	// CubeProxy. The desktop relay dials 6080 through CubeProxy instead.
	require.Equal(t, []uint16{CubeEnvdPort}, spec["exposedPorts"])
	require.Equal(t, uint16(CubeEnvdPort), spec["probePort"])
	require.Equal(t, CubeEnvdHealthPath, spec["probePath"])
	// 1G (the standard value) is too small once XFCE is installed.
	require.Equal(t, "8G", spec["writableLayerSize"])
	require.Equal(t, true, spec["allowInternetAccess"])
	require.Equal(t, []string{"/usr/bin/envd"}, spec["command"])
	require.Equal(t, []string{"-port", "49983", "-isnotfc"}, spec["args"])
}

func TestCubeStandardTemplateSpecStillExposesOnlyEnvd(t *testing.T) {
	// Host ports are a finite resource (CubeVS allocates 20000-29999). Neither
	// the CLI nor the desktop template may NAT extra guest ports onto the host.
	spec := cubeStandardTemplateSpec(nil)
	require.Equal(t, []uint16{CubeEnvdPort}, spec["exposedPorts"])
}

func TestDesktopReadyCmdDoesNotUseSS(t *testing.T) {
	// e2b.WaitForPort generates `ss -tln`, and iproute2 is not in the image:
	// ss exits 127, the loop never terminates, and the template build hangs
	// instead of failing. Keep the python3 probe.
	require.NotContains(t, desktopReadyCmd, "ss ")
	require.Contains(t, desktopReadyCmd, "python3")
	require.Contains(t, desktopReadyCmd, "6080")
}