Skip to content

Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.

fix(sandbox): treat E2B in_progress template builds as building (#4108)

lyingbug0c71fff2a387
diff --git a/internal/sandbox/e2b_remote_client.go b/internal/sandbox/e2b_remote_client.go
index da03071fa..6b0ef8be9 100644
--- a/internal/sandbox/e2b_remote_client.go
+++ b/internal/sandbox/e2b_remote_client.go
@@ -399,7 +399,7 @@ func normalizeE2BTemplateBuildStatus(status string) string {
switch strings.ToLower(strings.TrimSpace(status)) {
case "ready", "success", "succeeded", "complete", "completed":
return "ready"
- case "building", "processing":
+ case "building", "processing", "in_progress":
return "building"
case "waiting", "queued", "pending", "uploaded":
return "waiting"
diff --git a/internal/sandbox/e2b_remote_client_test.go b/internal/sandbox/e2b_remote_client_test.go
index a9eeacab1..2d82c9b99 100644
--- a/internal/sandbox/e2b_remote_client_test.go
+++ b/internal/sandbox/e2b_remote_client_test.go
@@ -499,6 +499,60 @@ func TestE2BRemoteClientListSnapshotsPagesAllResults(t *testing.T) {
require.Equal(t, "1", mock.snapshotQueries[1].Get("nextToken"))
}
+func TestE2BRemoteClientListTemplatesInProgress(t *testing.T) {
+ for _, tc := range []struct {
+ name string
+ buildID string
+ buildStatus string
+ wantStatus string
+ wantRequests int32
+ }{
+ {"no build reference", "00000000-0000-0000-0000-000000000000", "", "building", 0},
+ {"build in progress", "build-current", "in_progress", "building", 1},
+ {"build ready", "build-current", "ready", "ready", 1},
+ } {
+ t.Run(tc.name, func(t *testing.T) {
+ var statusRequests atomic.Int32
+ server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ switch r.URL.Path {
+ case "/templates":
+ writeJSON(w, http.StatusOK, []map[string]any{{
+ "templateID": "template-weagentbox",
+ "buildID": tc.buildID,
+ "names": []string{"project/weknora"},
+ "buildStatus": "in_progress",
+ }})
+ case "/templates/template-weagentbox/builds/" + tc.buildID + "/status":
+ statusRequests.Add(1)
+ writeJSON(w, http.StatusOK, map[string]any{
+ "templateID": "template-weagentbox",
+ "buildID": tc.buildID,
+ "status": tc.buildStatus,
+ })
+ default:
+ http.NotFound(w, r)
+ }
+ }))
+ t.Cleanup(server.Close)
+ client, err := NewE2BRemoteClient(&Config{
+ E2BAPIKey: "key-test",
+ E2BAPIURL: server.URL,
+ E2BSandboxTTL: time.Minute,
+ })
+ require.NoError(t, err)
+
+ templates, err := client.ListTemplates(context.Background())
+ require.NoError(t, err)
+ require.Len(t, templates, 1)
+ require.True(t, templates[0].Standard)
+ require.Equal(t, tc.wantStatus, templates[0].Status)
+ require.Equal(t, tc.wantRequests, statusRequests.Load())
+ require.Equal(t, tc.wantStatus == "building", isE2BTemplateBuildPending(templates[0].Status))
+ require.Equal(t, tc.wantStatus == "ready", IsTemplateReady(templates[0].Status))
+ })
+ }
+}
+
func TestE2BRemoteClientListTemplatesReconcilesStandardTemplateBuildStatus(t *testing.T) {
var statusRequests atomic.Int32
server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
@@ -948,13 +1002,15 @@ func TestE2BEnsureDesktopTemplateBuildsDesktopImage(t *testing.T) {
func TestNormalizeE2BTemplateBuildStatus(t *testing.T) {
tests := map[string]string{
- "READY": "ready",
- "success": "ready",
- "completed": "ready",
- "processing": "building",
- "uploaded": "waiting",
- "failed": "error",
- "custom": "custom",
+ "READY": "ready",
+ "success": "ready",
+ "completed": "ready",
+ "processing": "building",
+ "in_progress": "building",
+ " IN_PROGRESS ": "building",
+ "uploaded": "waiting",
+ "failed": "error",
+ "custom": "custom",
}
for raw, want := range tests {
require.Equalf(t, want, normalizeE2BTemplateBuildStatus(raw), "status %q", raw)