Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.
Go agentagenticaichatbotdsh-pluginembeddingsevaluationgenerative-aigolangknowledge-basellmmulti-tenantollamaopenaiquestion-answeringragrerankingsemantic-searchvector-searchwiki
fix(feishu): stop logging tenant access token fragments (#4399)
davien2c0d8384398c
diff --git a/internal/datasource/connector/feishu/core/client.go b/internal/datasource/connector/feishu/core/client.goindex 2bc342ba3..52ec80fdd 100644--- a/internal/datasource/connector/feishu/core/client.go+++ b/internal/datasource/connector/feishu/core/client.go@@ -151,16 +151,8 @@ func (c *Client) GetTenantAccessToken(ctx context.Context) (string, error) {}c.tokenExpAt = time.Now().Add(ttl)- prefixLen := 8- if len(result.TenantAccessToken) < prefixLen {- prefixLen = len(result.TenantAccessToken)- }- suffixLen := 4- if len(result.TenantAccessToken) < suffixLen {- suffixLen = len(result.TenantAccessToken)- }- logger.Infof(ctx, "[Feishu] got tenant_access_token: %s...%s expire=%ds",- result.TenantAccessToken[:prefixLen], result.TenantAccessToken[len(result.TenantAccessToken)-suffixLen:], result.Expire)+ // Never log token material: even a prefix/suffix narrows the bearer credential.+ logger.Infof(ctx, "[Feishu] tenant access token refreshed expire=%ds", result.Expire)return c.tokenCache, nil}diff --git a/internal/datasource/connector/feishu/core/token_log_test.go b/internal/datasource/connector/feishu/core/token_log_test.gonew file mode 100644index 000000000..422c7eb8a--- /dev/null+++ b/internal/datasource/connector/feishu/core/token_log_test.go@@ -0,0 +1,60 @@+package core++import (+ "bytes"+ "context"+ "encoding/json"+ "net/http"+ "net/http/httptest"+ "strings"+ "testing"++ "github.com/Tencent/WeKnora/internal/types"+ "github.com/sirupsen/logrus"+)++func TestTenantAccessTokenNeverAppearsInLogs(t *testing.T) {+ for _, token := range []string{"synthetic-access-value-for-logging-test", "xyz"} {+ t.Run(token, func(t *testing.T) {+ var logs bytes.Buffer+ recorder := logrus.New()+ recorder.SetOutput(&logs)+ recorder.SetLevel(logrus.DebugLevel)+ ctx := context.WithValue(context.Background(), types.LoggerContextKey, logrus.NewEntry(recorder))+ calls := 0+ server := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {+ calls+++ if r.URL.Path != "/open-apis/auth/v3/tenant_access_token/internal" || r.Method != http.MethodPost {+ t.Errorf("unexpected token request")+ }+ w.Header().Set("Content-Type", "application/json")+ _ = json.NewEncoder(w).Encode(map[string]any{"code": 0, "tenant_access_token": token, "expire": 7200})+ }))+ defer server.Close()+ client := &Client{+ baseURL: server.URL,+ appID: "test-app",+ appSecret: "synthetic-credential",+ httpClient: server.Client(),+ }+ for i := 0; i < 2; i++ {+ got, err := client.GetTenantAccessToken(ctx)+ if err != nil || got != token {+ t.Fatalf("token retrieval or cache failed: %v", err)+ }+ }+ if calls != 1 {+ t.Errorf("cached token should avoid a second request; got %d", calls)+ }+ prefix, suffix := token[:min(8, len(token))], token[max(0, len(token)-4):]+ for _, secret := range []string{token, prefix, suffix, "synthetic-credential"} {+ if strings.Contains(logs.String(), secret) {+ t.Error("authentication secret or fragment was logged")+ }+ }+ if !strings.Contains(logs.String(), "expire=7200s") {+ t.Error("safe token expiry diagnostics must remain")+ }+ })+ }+}