Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.
Go agentagenticaichatbotdsh-pluginembeddingsevaluationgenerative-aigolangknowledge-basellmmulti-tenantollamaopenaiquestion-answeringragrerankingsemantic-searchvector-searchwiki
fix(session): reject invalid QA queries before session lookup (#3477)
徐少2c6ae0c262fa
diff --git a/internal/handler/session/qa.go b/internal/handler/session/qa.goindex a1a56bcf1..8c49eb532 100644--- a/internal/handler/session/qa.go+++ b/internal/handler/session/qa.go@@ -151,8 +151,15 @@ func (h *Handler) parseQARequest(c *gin.Context, logPrefix string) (*qaRequestCoreturn nil, nil, errors.NewBadRequestError(err.Error())}- // Validate query content- if request.Query == "" {+ // Validate syntax before session lookup or QA work, preserving the original+ // query text. KnowledgeQA applies its XSS-pattern check later in the chat+ // pipeline; AgentQA must allow frontend code in conversation text.+ validatedQuery, valid := secutils.ValidateInputSyntax(request.Query)+ if !valid {+ logger.Error(ctx, "Query content is invalid")+ return nil, nil, errors.NewBadRequestError("Query content contains invalid content")+ }+ if validatedQuery == "" {logger.Error(ctx, "Query content is empty")return nil, nil, errors.NewBadRequestError("Query content cannot be empty")}diff --git a/internal/handler/session/qa_query_validation_test.go b/internal/handler/session/qa_query_validation_test.gonew file mode 100644index 000000000..323a3b4d8--- /dev/null+++ b/internal/handler/session/qa_query_validation_test.go@@ -0,0 +1,84 @@+package session++import (+ "bytes"+ "context"+ "encoding/json"+ "errors"+ "net/http"+ "net/http/httptest"+ "testing"++ "github.com/Tencent/WeKnora/internal/middleware"+ "github.com/Tencent/WeKnora/internal/types"+ "github.com/Tencent/WeKnora/internal/types/interfaces"+ "github.com/gin-gonic/gin"+ "github.com/stretchr/testify/assert"+ "github.com/stretchr/testify/require"+)++type queryValidationSessionStub struct {+ interfaces.SessionService+ lookupCalls int+}++func (s *queryValidationSessionStub) GetOwnedSession(context.Context, string) (*types.Session, error) {+ s.lookupCalls+++ return nil, errors.New("stop at session lookup")+}++func TestQAQueryValidation(t *testing.T) {+ gin.SetMode(gin.TestMode)+ tests := []struct {+ name string+ query string+ rejectBeforeLookup bool+ }{+ {name: "empty", rejectBeforeLookup: true},+ {name: "whitespace", query: " \t\r\n ", rejectBeforeLookup: true},+ {name: "unicode whitespace", query: "\u3000\u00a0", rejectBeforeLookup: true},+ {name: "null byte", query: "hello\x00world", rejectBeforeLookup: true},+ {name: "escape character", query: "hello\x1bworld", rejectBeforeLookup: true},+ {name: "script element", query: "<script>alert(1)</script>"},+ {name: "event handler", query: `<img src=x onerror="alert(1)">`},+ {name: "script URL", query: "javascript:alert(1)"},+ {name: "agent frontend snippet", query: `Why doesn't my <button onclick="save()">Save</button> fire?`},+ {name: "agent javascript snippet", query: "What does javascript:void(0) do?"},+ {name: "English", query: "What is retrieval augmented generation?"},+ {name: "Unicode", query: "请解释厄尔尼诺现象 🌊"},+ {name: "multiline", query: "Compare:\n\tGo\r\n\tPython"},+ {name: "padded text", query: " Explain retrieval.\n"},+ }+ for _, endpoint := range []string{"knowledge-chat", "agent-chat"} {+ t.Run(endpoint, func(t *testing.T) {+ for _, tt := range tests {+ t.Run(tt.name, func(t *testing.T) {+ sessions := &queryValidationSessionStub{}+ h := &Handler{sessionService: sessions}+ router := gin.New()+ router.Use(middleware.ErrorHandler())+ router.POST("/knowledge-chat/:session_id", h.KnowledgeQA)+ router.POST("/agent-chat/:session_id", h.AgentQA)++ body, err := json.Marshal(CreateKnowledgeQARequest{Query: tt.query})+ require.NoError(t, err)+ request := httptest.NewRequest(http.MethodPost, "/"+endpoint+"/session-1", bytes.NewReader(body))+ request.Header.Set("Content-Type", "application/json")+ response := httptest.NewRecorder()+ router.ServeHTTP(response, request)++ if tt.rejectBeforeLookup {+ assert.Equal(t, http.StatusBadRequest, response.Code, response.Body.String())+ assert.Contains(t, response.Header().Get("Content-Type"), "application/json")+ assert.Zero(t, sessions.lookupCalls, "reject the query before session lookup or QA work")+ } else {+ // Stop at a controlled not-found response: valid queries must+ // reach the ordinary session lookup without invoking a model.+ assert.Equal(t, http.StatusNotFound, response.Code, response.Body.String())+ assert.Equal(t, 1, sessions.lookupCalls)+ }+ })+ }+ })+ }+}diff --git a/internal/utils/security.go b/internal/utils/security.goindex 2a9d8ef54..de52a6e39 100644--- a/internal/utils/security.go+++ b/internal/utils/security.go@@ -77,12 +77,10 @@ func EscapeHTML(input string) string {return html.EscapeString(input)}-// ValidateInput 验证用户输入-func ValidateInput(input string) (string, bool) {- if input == "" {- return "", true- }-+// ValidateInputSyntax checks the input properties shared by all user-query+// entry points. It deliberately does not apply the XSS pattern list because+// some callers, such as AgentQA, accept frontend code as conversation text.+func ValidateInputSyntax(input string) (string, bool) {// 检查是否包含控制字符for _, r := range input {if r < 32 && r != 9 && r != 10 && r != 13 {@@ -95,6 +93,16 @@ func ValidateInput(input string) (string, bool) {return "", false}+ return strings.TrimSpace(input), true+}++// ValidateInput 验证用户输入+func ValidateInput(input string) (string, bool) {+ validatedInput, valid := ValidateInputSyntax(input)+ if !valid {+ return "", false+ }+// 检查是否包含潜在的 XSS 攻击for _, pattern := range xssPatterns {if pattern.MatchString(input) {@@ -102,7 +110,7 @@ func ValidateInput(input string) (string, bool) {}}- return strings.TrimSpace(input), true+ return validatedInput, true}// SafePathUnderBase 校验 filePath 是否落在 baseDir 下,防止路径遍历(如 ../../)。