Skip to content

Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.

fix(agent): discard failed stream drafts before retry (#4780)

Sun Shihao3d76b486e438
diff --git a/internal/agent/stream_retry_partial_test.go b/internal/agent/stream_retry_partial_test.go
new file mode 100644
index 000000000..aa92f8570
--- /dev/null
+++ b/internal/agent/stream_retry_partial_test.go
@@ -0,0 +1,103 @@
+package agent
+
+import (
+ "context"
+ "testing"
+
+ "github.com/Tencent/WeKnora/internal/types"
+ "github.com/stretchr/testify/require"
+)
+
+func TestStreamRetryReplacesFailedPartialAnswer(t *testing.T) {
+ model := &mockChat{responses: []mockResponse{
+ {chunks: []types.StreamResponse{
+ {ResponseType: types.ResponseTypeAnswer, Content: "partial draft"},
+ {ResponseType: types.ResponseTypeError, Content: "upstream 503", Done: true},
+ }},
+ {chunks: []types.StreamResponse{
+ {ResponseType: types.ResponseTypeAnswer, Content: "final answer"},
+ {ResponseType: types.ResponseTypeAnswer, Done: true, FinishReason: "stop"},
+ }},
+ }}
+ engine := newTestEngine(t, model)
+ recorder := &truncationRecorder{}
+ recorder.attach(engine.eventBus)
+
+ state := &types.AgentState{}
+ messages := emptyMessages()
+ _, err := engine.callLLMWithRetry(
+ context.Background(), &messages, emptyTools(), state, "question", 0, "session",
+ )
+ require.NoError(t, err)
+
+ var rendered string
+ replaces := 0
+ for _, data := range recorder.snapshot() {
+ if data.Replace {
+ rendered = ""
+ replaces++
+ }
+ rendered += data.Content
+ }
+ require.Equal(t, "final answer", rendered)
+ require.Equal(t, 1, replaces)
+}
+
+func TestStreamFailureWithoutAnswerDoesNotEmitReplace(t *testing.T) {
+ model := &mockChat{responses: []mockResponse{{chunks: []types.StreamResponse{
+ {ResponseType: types.ResponseTypeError, Content: "upstream 503", Done: true},
+ }}}}
+ engine := newTestEngine(t, model)
+ recorder := &truncationRecorder{}
+ recorder.attach(engine.eventBus)
+
+ messages := emptyMessages()
+ _, err := engine.callLLMWithRetry(
+ context.Background(), &messages, emptyTools(), &types.AgentState{}, "question", 0, "session",
+ )
+ require.Error(t, err)
+ for _, data := range recorder.snapshot() {
+ require.False(t, data.Replace, "a failed attempt with no visible answer has nothing to replace")
+ }
+}
+
+func TestStreamCancellationKeepsPartialAnswer(t *testing.T) {
+ model := &mockChat{responses: []mockResponse{{chunks: []types.StreamResponse{
+ {ResponseType: types.ResponseTypeAnswer, Content: "partial draft"},
+ {ResponseType: types.ResponseTypeError, Content: "context canceled", Done: true},
+ }}}}
+ engine := newTestEngine(t, model)
+ recorder := &truncationRecorder{}
+ recorder.attach(engine.eventBus)
+
+ ctx, cancel := context.WithCancel(context.Background())
+ cancel()
+ messages := emptyMessages()
+ _, err := engine.callLLMWithRetry(
+ ctx, &messages, emptyTools(), &types.AgentState{}, "question", 0, "session",
+ )
+ require.Error(t, err)
+ for _, data := range recorder.snapshot() {
+ require.False(t, data.Replace, "cancellation has no retry; keep the partial answer")
+ }
+}
+
+func TestStreamSuccessDoesNotEmitReplace(t *testing.T) {
+ model := &mockChat{responses: []mockResponse{{chunks: []types.StreamResponse{
+ {ResponseType: types.ResponseTypeAnswer, Content: "final answer"},
+ {ResponseType: types.ResponseTypeAnswer, Done: true, FinishReason: "stop"},
+ }}}}
+ engine := newTestEngine(t, model)
+ recorder := &truncationRecorder{}
+ recorder.attach(engine.eventBus)
+
+ messages := emptyMessages()
+ response, err := engine.callLLMWithRetry(
+ context.Background(), &messages, emptyTools(), &types.AgentState{}, "question", 0, "session",
+ )
+ require.NoError(t, err)
+ require.Equal(t, "final answer", response.Content)
+ for _, data := range recorder.snapshot() {
+ require.False(t, data.Replace)
+ }
+}
diff --git a/internal/agent/think.go b/internal/agent/think.go
index d1523c4a8..d60b31961 100644
--- a/internal/agent/think.go
+++ b/internal/agent/think.go
@@ -508,6 +508,19 @@ func (e *AgentEngine) streamThinkingToEventBus(
},
)
if err != nil {
+ // A failed attempt may already have streamed answer text. The retry
+ // starts a new answer event, so leaving this draft live would make the
+ // final message concatenate the failed attempt with the recovered one.
+ // A user cancellation is the exception: there is no retry, and the
+ // partial text is the only answer the user has.
+ if ctx.Err() == nil && answerStreamed {
+ _ = e.eventBus.Emit(ctx, event.Event{
+ ID: answerID,
+ Type: event.EventAgentFinalAnswer,
+ SessionID: sessionID,
+ Data: event.AgentFinalAnswerData{Replace: true},
+ })
+ }
logger.Errorf(ctx, "[Agent][Thinking] Iteration-%d failed: %v", iteration+1, err)
return nil, err
}