Skip to content

Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.

fix(chat): clear stale file and tool selections on session restore (#3802)

林SO412ce63f0b00
diff --git a/frontend/src/stores/sessionInputState.test.ts b/frontend/src/stores/sessionInputState.test.ts
new file mode 100644
index 000000000..ad0ee0499
--- /dev/null
+++ b/frontend/src/stores/sessionInputState.test.ts
@@ -0,0 +1,192 @@
+import assert from 'node:assert/strict'
+import { after, before, beforeEach, test } from 'node:test'
+import { fileURLToPath } from 'node:url'
+import { createServer, type ViteDevServer } from 'vite'
+import { createPinia } from 'pinia'
+import type { SessionLastRequestStatePayload } from './settings'
+
+let server: ViteDevServer
+let useSettingsStore: typeof import('./settings').useSettingsStore
+const savedStorage = Object.getOwnPropertyDescriptor(globalThis, 'localStorage')
+const items = new Map<string, string>()
+
+before(async () => {
+ Object.defineProperty(globalThis, 'localStorage', { configurable: true, value: {
+ getItem: (key: string) => items.get(key) ?? null,
+ setItem: (key: string, value: string) => items.set(key, value),
+ removeItem: (key: string) => items.delete(key),
+ } })
+ server = await createServer({
+ configFile: false,
+ plugins: [{ name: 'offline-store-test', enforce: 'pre',
+ resolveId(id) { if (id.endsWith('/utils/request')) return '\0offline-request' },
+ load(id) { if (id === '\0offline-request') return 'const request = () => { throw new Error("Unexpected network request") }; export { request as get, request as post, request as put, request as del };' },
+ }],
+ optimizeDeps: { noDiscovery: true, entries: [] },
+ resolve: { alias: { '@': fileURLToPath(new URL('../', import.meta.url)) } },
+ server: { middlewareMode: true, hmr: false }, appType: 'custom',
+ })
+ ;({ useSettingsStore } = await server.ssrLoadModule('/src/stores/settings.ts'))
+})
+
+beforeEach(() => items.clear())
+
+after(async () => {
+ await server?.close()
+ if (savedStorage) Object.defineProperty(globalThis, 'localStorage', savedStorage)
+ else Reflect.deleteProperty(globalThis, 'localStorage')
+})
+
+function selectDefaults(store: ReturnType<typeof useSettingsStore>) {
+ store.settings.selectedFiles = ['default-file']
+ store.settings.selectedFileKbMap = { 'default-file': 'default-kb' }
+ store.settings.selectedTags = [{ id: 'default-tag', name: 'Default tag', kbId: 'default-kb' }]
+ store.settings.selectedMCPServices = ['default-mcp']
+ store.settings.selectedSkills = ['default-skill']
+ store.selectKnowledgeBases(['default-kb'])
+}
+
+const emptySelections: SessionLastRequestStatePayload = {
+ knowledge_base_ids: [], knowledge_ids: [], tag_ids: [], mcp_service_ids: [], skill_names: [],
+}
+
+for (const state of [{ agent_enabled: true, knowledge_base_ids: [] }, emptySelections]) {
+ test(`session hydration clears stale file, tag, and tool selections when saved lists are ${'knowledge_ids' in state ? 'empty' : 'omitted'}`, () => {
+ const store = useSettingsStore(createPinia())
+ selectDefaults(store)
+ const storedDefaults = items.get('WeKnora_settings')
+
+ store.hydrateSessionInputState(state)
+
+ assert.deepEqual(store.getSelectedKnowledgeBases(), [])
+ assert.deepEqual(store.getSelectedFiles(), [])
+ assert.deepEqual(store.settings.selectedFileKbMap, {})
+ assert.deepEqual(store.settings.selectedTags, [])
+ assert.deepEqual(store.settings.selectedMCPServices, [])
+ assert.deepEqual(store.settings.selectedSkills, [])
+ assert.deepEqual(store.getSuggestedQuestionsParams(), {
+ knowledge_base_ids: undefined, knowledge_ids: undefined, tag_scopes: undefined, limit: undefined,
+ })
+ assert.equal(items.get('WeKnora_settings'), storedDefaults, 'hydration must not overwrite browser defaults')
+ store.restoreDefaultsIfSnapshotted()
+ assert.deepEqual(JSON.parse(JSON.stringify(store.settings)), JSON.parse(storedDefaults!))
+ })
+}
+
+test('switching back to a session without mentions clears file and tool selections from browser defaults', () => {
+ const store = useSettingsStore(createPinia())
+ selectDefaults(store)
+ store.hydrateSessionInputState({ knowledge_base_ids: [] })
+
+ // The chat route restores defaults before loading every other session.
+ store.restoreDefaultsIfSnapshotted()
+ store.hydrateSessionInputState({
+ knowledge_ids: ['other-session-file'], mcp_service_ids: ['other-session-mcp'], skill_names: ['other-session-skill'],
+ })
+ assert.deepEqual(store.getSelectedFiles(), ['other-session-file'])
+ assert.deepEqual(store.settings.selectedMCPServices, ['other-session-mcp'])
+ assert.deepEqual(store.settings.selectedSkills, ['other-session-skill'])
+ store.restoreDefaultsIfSnapshotted()
+ store.hydrateSessionInputState({ knowledge_base_ids: [] })
+
+ assert.deepEqual(store.getSelectedFiles(), [])
+ assert.deepEqual(store.settings.selectedTags, [])
+ assert.deepEqual(store.settings.selectedMCPServices, [])
+ assert.deepEqual(store.settings.selectedSkills, [])
+ store.restoreDefaultsIfSnapshotted()
+ assert.deepEqual(store.getSelectedFiles(), ['default-file'])
+ assert.deepEqual(store.settings.selectedTags, [{ id: 'default-tag', name: 'Default tag', kbId: 'default-kb' }])
+ assert.deepEqual(store.settings.selectedMCPServices, ['default-mcp'])
+ assert.deepEqual(store.settings.selectedSkills, ['default-skill'])
+})
+
+test('session hydration copies explicit selections and retains only selected files in the KB map', () => {
+ const store = useSettingsStore(createPinia())
+ selectDefaults(store)
+ const state = {
+ knowledge_base_ids: ['session-kb'], knowledge_ids: ['session-file', 'default-file'],
+ mcp_service_ids: ['session-mcp'], skill_names: ['session-skill'],
+ }
+ store.settings.selectedFileKbMap['unselected-file'] = 'another-kb'
+
+ store.hydrateSessionInputState(state)
+ assert.deepEqual(store.getSelectedKnowledgeBases(), ['session-kb'])
+ assert.deepEqual(store.getSelectedFiles(), ['session-file', 'default-file'])
+ assert.deepEqual(store.settings.selectedFileKbMap, { 'default-file': 'default-kb' })
+ assert.deepEqual(store.settings.selectedMCPServices, ['session-mcp'])
+ assert.deepEqual(store.settings.selectedSkills, ['session-skill'])
+ store.settings.selectedKnowledgeBases.push('another-kb')
+ store.settings.selectedFiles.push('another-file')
+ store.settings.selectedMCPServices.push('another-mcp')
+ store.settings.selectedSkills.push('another-skill')
+
+ assert.deepEqual(state.knowledge_base_ids, ['session-kb'])
+ assert.deepEqual(state.knowledge_ids, ['session-file', 'default-file'])
+ assert.deepEqual(state.mcp_service_ids, ['session-mcp'])
+ assert.deepEqual(state.skill_names, ['session-skill'])
+ store.restoreDefaultsIfSnapshotted()
+ assert.deepEqual(store.getSelectedKnowledgeBases(), ['default-kb'])
+})
+
+test('session hydration restores tags and tool selections from mentions when ID lists are omitted', () => {
+ const store = useSettingsStore(createPinia())
+ selectDefaults(store)
+ store.hydrateSessionInputState({
+ knowledge_base_ids: ['session-kb'],
+ mentioned_items: [
+ { id: 'tag', type: 'tag', name: 'Saved tag', kb_id: 'session-kb', kb_name: 'Saved KB' },
+ { id: 'mcp', type: 'mcp' },
+ { id: 'skill-id', type: 'skill', skill_name: 'saved-skill' },
+ ],
+ })
+
+ assert.deepEqual(store.settings.selectedTags, [{ id: 'tag', name: 'Saved tag', kbId: 'session-kb', kbName: 'Saved KB' }])
+ assert.deepEqual(store.settings.selectedMCPServices, ['mcp'])
+ assert.deepEqual(store.settings.selectedSkills, ['saved-skill'])
+})
+
+test('explicit empty ID lists override stale tag and tool mentions', () => {
+ const store = useSettingsStore(createPinia())
+ selectDefaults(store)
+ store.hydrateSessionInputState({
+ ...emptySelections,
+ mentioned_items: [
+ { id: 'tag', type: 'tag', kb_id: 'old-kb' },
+ { id: 'mcp', type: 'mcp' },
+ { id: 'skill', type: 'skill' },
+ ],
+ })
+
+ assert.deepEqual(store.settings.selectedTags, [])
+ assert.deepEqual(store.settings.selectedMCPServices, [])
+ assert.deepEqual(store.settings.selectedSkills, [])
+})
+
+test('explicit tag IDs filter mentions and preserve the single-KB fallback for missing metadata', () => {
+ const store = useSettingsStore(createPinia())
+ store.hydrateSessionInputState({
+ knowledge_base_ids: ['session-kb'], tag_ids: ['selected-tag', 'orphan-tag'],
+ mentioned_items: [
+ { id: 'selected-tag', type: 'tag', name: 'Saved tag', kb_id: 'session-kb' },
+ { id: 'unselected-tag', type: 'tag', kb_id: 'other-kb' },
+ ],
+ })
+
+ assert.deepEqual(store.settings.selectedTags, [
+ { id: 'selected-tag', name: 'Saved tag', kbId: 'session-kb', kbName: undefined },
+ { id: 'orphan-tag', name: 'orphan-tag', kbId: 'session-kb', kbName: undefined },
+ ])
+})
+
+test('missing session state and first-send hydration preserve the current draft selections', () => {
+ const store = useSettingsStore(createPinia())
+ selectDefaults(store)
+ const draft = JSON.stringify(store.settings)
+
+ store.hydrateSessionInputState(null)
+ store.hydrateSessionInputState(undefined)
+ store.hydrateSessionInputState({ agent_enabled: true }, true)
+
+ assert.equal(JSON.stringify(store.settings), draft)
+ assert.equal(store._defaultsSnapshot, null)
+})
diff --git a/frontend/src/stores/settings.ts b/frontend/src/stores/settings.ts
index bb0d87206..5547f4a0e 100644
--- a/frontend/src/stores/settings.ts
+++ b/frontend/src/stores/settings.ts
@@ -526,7 +526,7 @@ export const useSettingsStore = defineStore("settings", {
// 根据 session.last_request_state 覆盖输入栏相关字段。
// 只触碰本次记录的字段,**不**清空 store 中其它无关字段(如模型列表)。
- // 一般字段缺失时做"尽力恢复";知识库范围例外,缺失代表本会话未选中知识库。
+ // 按字段语义恢复,不将会话选择写入用户默认设置。
applyLastRequestState(state: SessionLastRequestStatePayload | null | undefined) {
if (!state) return;
this._isApplyingSessionState = true;
@@ -550,14 +550,18 @@ export const useSettingsStore = defineStore("settings", {
this.settings.selectedKnowledgeBases = Array.isArray(state.knowledge_base_ids)
? [...state.knowledge_base_ids]
: [];
- if (Array.isArray(state.knowledge_ids)) {
- this.settings.selectedFiles = [...state.knowledge_ids];
- // selectedFileKbMap 此时无法重建(state 里没存 KB 归属),交给前端按
- // 需要 lazy 拉取。保留 store 现值,避免误删用户刚加进来的文件映射。
- }
+ // 服务端省略空的选择项列表;保留现值会把其它会话或全局默认的
+ // 文件、标签和工具选择带入本会话。
+ this.settings.selectedFiles = Array.isArray(state.knowledge_ids) ? [...state.knowledge_ids] : [];
+ // 保留仍选中文件的已知 KB 归属(共享文件需要它);其它文件的缓存不跨会话带入。
+ this.settings.selectedFileKbMap = Object.fromEntries(
+ Object.entries(this.settings.selectedFileKbMap || {})
+ .filter(([id]) => this.settings.selectedFiles.includes(id))
+ );
if (Array.isArray(state.mentioned_items)) {
const fromMentions = state.mentioned_items
.filter(item => item.type === "tag" && item.id && item.kb_id)
+ .filter(item => !Array.isArray(state.tag_ids) || state.tag_ids.includes(item.id))
.map(item => ({ id: item.id, name: item.name || item.id, kbId: item.kb_id!, kbName: item.kb_name }));
const covered = new Set(fromMentions.map(t => t.id));
const orphanTagIds = (state.tag_ids || []).filter(id => id && !covered.has(id));
@@ -571,6 +575,8 @@ export const useSettingsStore = defineStore("settings", {
} else if (Array.isArray(state.tag_ids)) {
const existing = this.settings.selectedTags || [];
this.settings.selectedTags = existing.filter(tag => state.tag_ids?.includes(tag.id));
+ } else {
+ this.settings.selectedTags = [];
}
if (Array.isArray(state.mcp_service_ids)) {
this.settings.selectedMCPServices = [...state.mcp_service_ids];
@@ -578,6 +584,8 @@ export const useSettingsStore = defineStore("settings", {
this.settings.selectedMCPServices = state.mentioned_items
.filter(item => item.type === "mcp" && item.id)
.map(item => item.id);
+ } else {
+ this.settings.selectedMCPServices = [];
}
if (Array.isArray(state.skill_names)) {
this.settings.selectedSkills = [...state.skill_names];
@@ -585,6 +593,8 @@ export const useSettingsStore = defineStore("settings", {
this.settings.selectedSkills = state.mentioned_items
.filter(item => item.type === "skill" && item.id)
.map(item => item.skill_name || item.id);
+ } else {
+ this.settings.selectedSkills = [];
}
this.settings.localBrowserEnabled = state.local_browser_enabled === true;
if (typeof state.web_search_enabled === "boolean") {