Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.
Go agentagenticaichatbotdsh-pluginembeddingsevaluationgenerative-aigolangknowledge-basellmmulti-tenantollamaopenaiquestion-answeringragrerankingsemantic-searchvector-searchwiki
style: trim the comments added in this branch to the repo's cap
Ankit Jha5f1b7a2b3bdf
diff --git a/internal/handler/knowledge.go b/internal/handler/knowledge.goindex a35fff357..52d5c00f8 100644--- a/internal/handler/knowledge.go+++ b/internal/handler/knowledge.go@@ -731,22 +731,8 @@ func knowledgeSpansLastError(}}-// missingStageStatusFunc decides what a canonical stage with no row should-// render as. The parse_status-derived fallback cannot tell "this stage ran and-// failed" from "this stage never ran", so once a stage actually recorded a-// failure it paints every rows-less stage `failed` too: the UI picks the first-// failed stage in canonical order and names the wrong one, and the blast radius-// looks total rather than "one stage broke, the rest never started" (#3452).-//-// With a real stage failure on record the position of that failure is known, so:-//-// - downstream of it, per StageDependencies or canonical order → cancelled-// ("not run because an upstream span failed")-// - before it → skipped; the stage either did not apply (a text passage has no-// docreader step) or its row was never written, and neither is a failure-//-// Without one, the parse_status fallback stands unchanged, which is the case it-// was written for: legacy knowledge parsed before span tracking existed.+// missingStageStatusFunc resolves a rowless stage against the real failure:+// earlier → skipped, downstream → cancelled, none → the parse_status fallback (#3452).func missingStageStatusFunc(stageRowByName map[string]*types.KnowledgeProcessingSpan, fallback string,) func(string) string {@@ -761,10 +747,7 @@ func missingStageStatusFunc(return func(string) string { return fallback }}- // Transitive dependents of the failed stage. Today these are always later- // in AllStages too, so the canonical-order check below already covers them;- // consulting the DAG keeps the answer right if the stage list is ever- // reordered or a stage gains an upstream that is not its predecessor.+ // Redundant with canonical order today; keeps holding if stages are reordered.cancelled := map[string]bool{}var markDependents func(string)markDependents = func(stage string) {diff --git a/internal/handler/knowledge_spans_test.go b/internal/handler/knowledge_spans_test.goindex 29afdddf5..782baead7 100644--- a/internal/handler/knowledge_spans_test.go+++ b/internal/handler/knowledge_spans_test.go@@ -184,13 +184,8 @@ func stageStatuses(t *testing.T, tree *types.SpanTreeNode) map[string]string {return got}-// TestBuildSpanTree_MissingStagesAroundRealFailure records #3452: a text-// passage is chunked without ever opening a docreader stage, so when-// embedding fails the rows-less stages used to synthesize as "failed" too.-// The frontend names the failed stage by taking the first failed one in-// canonical order, so it reported docreader — a stage that never ran, for-// content that has no document to parse — and four of five segments showed-// as broken.+// #3452: a text passage has no docreader stage, so an embedding failure used to+// synthesize docreader as failed and the UI named it as the broken step.func TestBuildSpanTree_MissingStagesAroundRealFailure(t *testing.T) {now := time.Now()finished := now.Add(2 * time.Second)@@ -213,8 +208,7 @@ func TestBuildSpanTree_MissingStagesAroundRealFailure(t *testing.T) {a.Equal(types.SpanStatusCancelled, got[types.StagePostProcess],"postprocess depends on embedding, so it is cancelled rather than failed")- // The frontend picks the focused stage with the first `failed` in- // canonical order; embedding must be the only candidate.+ // The UI focuses the first failed stage in canonical order.var firstFailed stringfor _, name := range types.AllStages {if got[name] == types.SpanStatusFailed {@@ -228,9 +222,7 @@ func TestBuildSpanTree_MissingStagesAroundRealFailure(t *testing.T) {a.Equal(types.StageEmbedding, lastFail.Name)}-// TestBuildSpanTree_MissingStagesWithoutFailureKeepFallback pins the case the-// parse_status rule was written for: no stage recorded a failure, so there is-// no position to reason from and the inferred terminal state still applies.+// No failed row means no position to reason from, so the fallback still applies.func TestBuildSpanTree_MissingStagesWithoutFailureKeepFallback(t *testing.T) {now := time.Now()rows := []types.KnowledgeProcessingSpan{@@ -246,9 +238,8 @@ func TestBuildSpanTree_MissingStagesWithoutFailureKeepFallback(t *testing.T) {a.Equal(types.SpanStatusPending, got[types.StagePostProcess])}-// TestBuildSpanTree_CancelledParseRendersCancelled records that a cancelled-// document no longer shows pending spinners for the stages it never reached:-// parse_status "cancelled" used to fall through the switch to pending.+// parse_status "cancelled" fell through to pending, leaving spinners on+// stages the document never reached.func TestBuildSpanTree_CancelledParseRendersCancelled(t *testing.T) {tree, _, _ := buildSpanTree("kid-cancelled", 0, nil, types.ParseStatusCancelled)a := assert.New(t)@@ -260,9 +251,7 @@ func TestBuildSpanTree_CancelledParseRendersCancelled(t *testing.T) {}}-// TestBuildSpanTree_DocReaderFailureCancelsEverythingAfter covers the failure-// at the first stage: nothing precedes it, so no stage should be skipped and-// every later rows-less stage is cancelled.+// Failure at the first stage: nothing precedes it, so nothing is skipped.func TestBuildSpanTree_DocReaderFailureCancelsEverythingAfter(t *testing.T) {now := time.Now()rows := []types.KnowledgeProcessingSpan{