Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.
Go agentagenticaichatbotdsh-pluginembeddingsevaluationgenerative-aigolangknowledge-basellmmulti-tenantollamaopenaiquestion-answeringragrerankingsemantic-searchvector-searchwiki
fix(agent): invalidate context checkpoints when rewinding steered turns (#4143)
诉说晚秋6c57449d6d72
diff --git a/internal/application/repository/message.go b/internal/application/repository/message.goindex c00f8bfa6..e9a83219f 100644--- a/internal/application/repository/message.go+++ b/internal/application/repository/message.go@@ -264,7 +264,7 @@ func (r *messageRepository) UpdateMessage(ctx context.Context, message *types.Mereturn r.db.WithContext(ctx).Transaction(func(tx *gorm.DB) error {if err := tx.Model(&types.Message{}).Where("id = ? AND session_id = ?", message.ID, message.SessionID,- ).Updates(message).Error; err != nil {+ ).Omit("context_checkpoint").Updates(message).Error; err != nil {return err}// Updates skips zero values; written on its own so a resumed or@@ -312,6 +312,9 @@ func (r *messageRepository) DeleteMessagesFrom(if len(deleted) == 0 {return nil}+ if err := invalidateDependentCheckpoints(tx, deleted[0]); err != nil {+ return err+ }return scope().Delete(&types.Message{}).Error})if err != nil {diff --git a/internal/application/repository/message_checkpoint_deletion.go b/internal/application/repository/message_checkpoint_deletion.gonew file mode 100644index 000000000..c4c7c1cc7--- /dev/null+++ b/internal/application/repository/message_checkpoint_deletion.go@@ -0,0 +1,25 @@+package repository++import (+ "github.com/Tencent/WeKnora/internal/types"+ "gorm.io/gorm"+)++// invalidateDependentCheckpoints clears summaries covering the first deleted+// turn. The caller's transaction also deletes the rewound messages.+func invalidateDependentCheckpoints(tx *gorm.DB, message *types.Message) error {+ boundary := *message+ if message.RequestID != "" {+ // A steered user message can be newer than its assistant row. The+ // checkpoint on that row still covers it, so invalidate from the turn.+ boundary = types.Message{}+ if err := tx.Where("session_id = ? AND request_id = ?", message.SessionID, message.RequestID).+ Order("created_at ASC, id ASC").First(&boundary).Error; err != nil {+ return err+ }+ }+ return tx.Model(&types.Message{}).+ Where("session_id = ? AND role = 'assistant' AND context_checkpoint IS NOT NULL", message.SessionID).+ Where("created_at > ? OR (created_at = ? AND id >= ?)", boundary.CreatedAt, boundary.CreatedAt, boundary.ID).+ UpdateColumn("context_checkpoint", nil).Error+}diff --git a/internal/application/repository/message_checkpoint_deletion_test.go b/internal/application/repository/message_checkpoint_deletion_test.gonew file mode 100644index 000000000..4705f98d8--- /dev/null+++ b/internal/application/repository/message_checkpoint_deletion_test.go@@ -0,0 +1,137 @@+package repository++import (+ "testing"+ "time"++ "github.com/Tencent/WeKnora/internal/types"+ "github.com/stretchr/testify/require"+ "gorm.io/gorm"+)++func seedSteeredCheckpoint(t *testing.T, repo *messageRepository, db *gorm.DB) time.Time {+ t.Helper()+ at := time.Date(2026, 10, 10, 12, 0, 0, 0, time.UTC)+ seedMessage(t, db, "user", "s", "user", at)+ seedMessage(t, db, "assistant", "s", "assistant", at.Add(time.Second))+ seedMessage(t, db, "steer", "s", "user", at.Add(time.Minute))+ require.NoError(t, db.Model(&types.Message{}).Where("session_id = ?", "s").+ Update("request_id", "turn").Error)+ require.NoError(t, repo.UpdateMessageContextCheckpoint(t.Context(), "s", "assistant",+ &types.ContextCheckpoint{Summary: "includes steer"}))+ return at.Add(time.Minute)+}++func TestRewindSteeredMessageInvalidatesEarlierAssistantCheckpoint(t *testing.T) {+ repo, db := newMessageRepositoryForForkTest(t)+ ctx := t.Context()+ cut := seedSteeredCheckpoint(t, repo, db)+ seedMessage(t, db, "before", "s", "assistant", cut.Add(-2*time.Minute))+ seedMessage(t, db, "other", "other", "assistant", cut)+ for _, pair := range [][2]string{{"s", "before"}, {"other", "other"}} {+ require.NoError(t, repo.UpdateMessageContextCheckpoint(ctx, pair[0], pair[1],+ &types.ContextCheckpoint{Summary: pair[1]}))+ }+ // A reused request ID in another session must not move this boundary.+ require.NoError(t, db.Model(&types.Message{}).Where("id = ?", "other").+ Updates(map[string]any{"request_id": "turn", "created_at": cut.Add(-3 * time.Minute)}).Error)+ deleted, err := repo.DeleteMessagesFrom(ctx, "s", cut, "steer", true)+ require.NoError(t, err)+ require.Len(t, deleted, 1)+ require.Equal(t, "steer", deleted[0].ID)+ assistant, err := repo.GetMessage(ctx, "s", "assistant")+ require.NoError(t, err)+ require.Nil(t, assistant.ContextCheckpoint)+ checkpoint, err := repo.GetLatestContextCheckpoint(ctx, "s")+ require.NoError(t, err)+ require.NotNil(t, checkpoint)+ require.Equal(t, "before", checkpoint.ID)+ other, err := repo.GetLatestContextCheckpoint(ctx, "other")+ require.NoError(t, err)+ require.NotNil(t, other)+ require.Equal(t, "other", other.ID)+}++func TestRewindCheckpointUsesCompositeBoundary(t *testing.T) {+ for _, inclusive := range []bool{false, true} {+ name := map[bool]string{false: "assistant_exclusive", true: "user_inclusive"}[inclusive]+ t.Run(name, func(t *testing.T) { checkRewindCompositeBoundary(t, inclusive) })+ }+}++func checkRewindCompositeBoundary(t *testing.T, inclusive bool) {+ t.Helper()+ repo, db := newMessageRepositoryForForkTest(t)+ at := time.Date(2026, 10, 10, 12, 0, 0, 0, time.UTC)+ for _, id := range []string{"a", "b", "c", "d"} {+ role := "assistant"+ if id == "d" {+ role = "user"+ }+ seedMessage(t, db, id, "s", role, at)+ }+ // c survives a cut at d, but its checkpoint covers that steered turn.+ require.NoError(t, db.Model(&types.Message{}).Where("id IN ?", []string{"c", "d"}).+ Update("request_id", "steered-turn").Error)+ for _, id := range []string{"a", "b", "c"} {+ require.NoError(t, repo.UpdateMessageContextCheckpoint(t.Context(), "s", id,+ &types.ContextCheckpoint{Summary: id}))+ }+ boundary, count := "b", 2+ if inclusive {+ boundary, count = "d", 1+ }+ deleted, err := repo.DeleteMessagesFrom(t.Context(), "s", at, boundary, inclusive)+ require.NoError(t, err)+ require.Len(t, deleted, count)+ checkpoint, err := repo.GetLatestContextCheckpoint(t.Context(), "s")+ require.NoError(t, err)+ require.NotNil(t, checkpoint)+ require.Equal(t, "b", checkpoint.ID)+}++func TestRewindSkipsAssistantWithoutCheckpoint(t *testing.T) {+ repo, db := newMessageRepositoryForForkTest(t)+ cut := seedSteeredCheckpoint(t, repo, db)+ seedMessage(t, db, "no-checkpoint", "s", "assistant", cut.Add(-time.Second))+ require.NoError(t, db.Exec(`CREATE TRIGGER reject_empty_checkpoint_update+ BEFORE UPDATE OF context_checkpoint ON messages WHEN OLD.context_checkpoint IS NULL+ BEGIN SELECT RAISE(ABORT, 'unnecessary checkpoint update'); END`).Error)+ _, err := repo.DeleteMessagesFrom(t.Context(), "s", cut, "steer", true)+ require.NoError(t, err)+ assistant, err := repo.GetMessage(t.Context(), "s", "assistant")+ require.NoError(t, err)+ require.Nil(t, assistant.ContextCheckpoint)+}++func TestRewindRollsBackWhenCheckpointInvalidationFails(t *testing.T) {+ repo, db := newMessageRepositoryForForkTest(t)+ cut := seedSteeredCheckpoint(t, repo, db)+ require.NoError(t, db.Exec(`CREATE TRIGGER fail_checkpoint BEFORE UPDATE OF context_checkpoint ON messages+ BEGIN SELECT RAISE(ABORT, 'injected checkpoint failure'); END`).Error)+ _, err := repo.DeleteMessagesFrom(t.Context(), "s", cut, "steer", true)+ require.Error(t, err)+ steer, err := repo.GetMessage(t.Context(), "s", "steer")+ require.NoError(t, err)+ require.Equal(t, "steer", steer.ID)+ assistant, err := repo.GetMessage(t.Context(), "s", "assistant")+ require.NoError(t, err)+ require.NotNil(t, assistant.ContextCheckpoint)+}++func TestMessageUpdateCannotRestoreRewoundCheckpoint(t *testing.T) {+ repo, db := newMessageRepositoryForForkTest(t)+ ctx := t.Context()+ cut := seedSteeredCheckpoint(t, repo, db)+ stale, err := repo.GetMessage(ctx, "s", "assistant")+ require.NoError(t, err)+ require.NotNil(t, stale.ContextCheckpoint)+ _, err = repo.DeleteMessagesFrom(ctx, "s", cut, "steer", true)+ require.NoError(t, err)+ stale.Content = "updated answer"+ require.NoError(t, repo.UpdateMessage(ctx, stale))+ updated, err := repo.GetMessage(ctx, "s", "assistant")+ require.NoError(t, err)+ require.Equal(t, "updated answer", updated.Content)+ require.Nil(t, updated.ContextCheckpoint)+}diff --git a/internal/application/service/agent_history_deletion_test.go b/internal/application/service/agent_history_deletion_test.gonew file mode 100644index 000000000..6819e59f0--- /dev/null+++ b/internal/application/service/agent_history_deletion_test.go@@ -0,0 +1,67 @@+package service++import (+ "path/filepath"+ "strings"+ "testing"+ "time"++ "github.com/Tencent/WeKnora/internal/application/repository"+ "github.com/Tencent/WeKnora/internal/types"+ "github.com/stretchr/testify/require"+ "gorm.io/driver/sqlite"+ "gorm.io/gorm"+ "gorm.io/gorm/logger"+)++func TestLoadAgentHistoryAfterRewindingSteer(t *testing.T) {+ for _, checkpointed := range []bool{false, true} {+ name := "raw_history"+ if checkpointed {+ name = "checkpoint_history"+ }+ t.Run(name, func(t *testing.T) { checkRewoundSteerHistory(t, checkpointed) })+ }+}++func checkRewoundSteerHistory(t *testing.T, checkpointed bool) {+ db, err := gorm.Open(sqlite.Open(filepath.Join(t.TempDir(), "history.db")), &gorm.Config{Logger: logger.Discard})+ require.NoError(t, err)+ sqlDB, err := db.DB()+ require.NoError(t, err)+ t.Cleanup(func() { _ = sqlDB.Close() })+ require.NoError(t, db.AutoMigrate(&types.Message{}, &types.MessageArtifactRecord{}))+ repo := repository.NewMessageRepository(db)+ ctx := t.Context()+ const session = "rewind-session"+ const marker = "REVOKED_PROJECT_CODENAME_ORCHID"+ rows := storedTurns(3)+ steer := &types.Message{+ SessionID: session, RequestID: rows[3].RequestID, Role: "user",+ Content: "Use project codename " + marker, CreatedAt: rows[3].CreatedAt.Add(time.Second),+ }+ rows = append(rows, steer)+ for _, row := range rows {+ row.SessionID = session+ require.NoError(t, db.Create(row).Error)+ }+ if checkpointed {+ require.NoError(t, repo.UpdateMessageContextCheckpoint(ctx, session, rows[3].ID, &types.ContextCheckpoint{+ Summary: "The user requested project codename " + marker + " in turn 2.",+ }))+ }+ deleted, err := repo.DeleteMessagesFrom(ctx, session, steer.CreatedAt, steer.ID, true)+ require.NoError(t, err)+ require.Len(t, deleted, 3)+ var remaining int64+ require.NoError(t, db.Model(&types.Message{}).+ Where("id = ?", steer.ID).Count(&remaining).Error)+ require.Zero(t, remaining)+ history, _, err := LoadAgentHistory(ctx, repo, session, unlimitedBudget, false)+ require.NoError(t, err)+ text := strings.Join(contents(history), "\n")+ t.Logf("checkpointed=%t active_steer_rows=%d marker_in_next_context=%t",+ checkpointed, remaining, strings.Contains(text, marker))+ require.NotContains(t, text, marker, "rewound steer must not survive in a derived context checkpoint")+ require.Contains(t, text, "question 2", "retained history must remain available")+}