Skip to content

Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.

fix(client): encode file type filters as a comma-separated value (#4240)

惜理72d68653d0d6
diff --git a/client/knowledge.go b/client/knowledge.go
index 44fd47157..01a3e5287 100644
--- a/client/knowledge.go
+++ b/client/knowledge.go
@@ -17,6 +17,7 @@ import (
"net/url"
"os"
"strconv"
+ "strings"
"time"
)
@@ -918,9 +919,7 @@ func (c *Client) FilterKnowledge(ctx context.Context, keyword string, offset, li
queryParams.Set("offset", strconv.Itoa(offset))
queryParams.Set("limit", strconv.Itoa(limit))
if len(fileTypes) > 0 {
- for _, ft := range fileTypes {
- queryParams.Add("file_types", ft)
- }
+ queryParams.Set("file_types", strings.Join(fileTypes, ","))
}
if agentID != "" {
queryParams.Set("agent_id", agentID)
diff --git a/client/knowledge_filter_test.go b/client/knowledge_filter_test.go
new file mode 100644
index 000000000..39d625e33
--- /dev/null
+++ b/client/knowledge_filter_test.go
@@ -0,0 +1,57 @@
+package client
+
+import (
+ "context"
+ "net/http"
+ "net/http/httptest"
+ "net/url"
+ "reflect"
+ "testing"
+)
+
+func TestFilterKnowledgeFileTypes(t *testing.T) {
+ for _, tc := range []struct {
+ name string
+ fileTypes []string
+ want string
+ }{
+ {name: "nil"},
+ {name: "empty", fileTypes: []string{}},
+ {name: "single", fileTypes: []string{"csv"}, want: "csv"},
+ {name: "multiple", fileTypes: []string{"csv", "xlsx"}, want: "csv,xlsx"},
+ {name: "reversed", fileTypes: []string{"xlsx", "csv"}, want: "xlsx,csv"},
+ } {
+ t.Run(tc.name, func(t *testing.T) {
+ srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
+ if r.Method != http.MethodGet || r.URL.Path != "/api/v1/knowledge/search" {
+ t.Errorf("request = %s %s, want GET /api/v1/knowledge/search", r.Method, r.URL.Path)
+ }
+ wantQuery := url.Values{
+ "keyword": {"budget & notes"},
+ "offset": {"3"},
+ "limit": {"20"},
+ "agent_id": {"agent-1"},
+ }
+ if tc.want != "" {
+ wantQuery.Set("file_types", tc.want)
+ }
+ if got := r.URL.Query(); !reflect.DeepEqual(got, wantQuery) {
+ t.Errorf("query = %v, want %v", got, wantQuery)
+ }
+ w.Header().Set("Content-Type", "application/json")
+ _, _ = w.Write([]byte(`{"success":true,"data":[{"id":"knowledge-1"}],"has_more":true}`))
+ }))
+ defer srv.Close()
+
+ c := NewClient(srv.URL)
+ results, hasMore, err := c.FilterKnowledge(context.Background(), "budget & notes", 3, 20,
+ tc.fileTypes, "agent-1")
+ if err != nil {
+ t.Fatalf("FilterKnowledge() error = %v", err)
+ }
+ if len(results) != 1 || results[0].ID != "knowledge-1" || !hasMore {
+ t.Errorf("FilterKnowledge() = %v, %v; want knowledge-1 and has_more", results, hasMore)
+ }
+ })
+ }
+}