Open-source LLM knowledge platform: turn raw documents into a queryable RAG, an autonomous reasoning agent, and a self-maintaining Wiki.
Go agentagenticaichatbotdsh-pluginembeddingsevaluationgenerative-aigolangknowledge-basellmmulti-tenantollamaopenaiquestion-answeringragrerankingsemantic-searchvector-searchwiki
fix(sandbox): pass desktop slot timing to the renew goroutine
Victor Maznyukbad7afa6ae31
diff --git a/internal/handler/session/sandbox_desktop_ws.go b/internal/handler/session/sandbox_desktop_ws.goindex 586d8aa89..72af0b005 100644--- a/internal/handler/session/sandbox_desktop_ws.go+++ b/internal/handler/session/sandbox_desktop_ws.go@@ -450,7 +450,9 @@ func (h *Handler) acquireDesktopSlot(hold, cancelHold := context.WithCancelCause(context.Background())renewCtx, stopRenew := context.WithCancel(context.WithoutCancel(ctx))- go renewDesktopSlot(renewCtx, cancelHold, h.redis, key, token)+ // The timing is read here, before the goroutine starts, so the renew loop+ // never reads the package-level settings concurrently with a writer.+ go renewDesktopSlot(renewCtx, cancelHold, h.redis, key, token, desktopSlotRenew, desktopSlotLease)var once sync.Oncereturn func() {@@ -469,8 +471,9 @@ func renewDesktopSlot(cancelHold context.CancelCauseFunc,client redis.UniversalClient,key, token string,+ renewEvery, lease time.Duration,) {- ticker := time.NewTicker(desktopSlotRenew)+ ticker := time.NewTicker(renewEvery)defer ticker.Stop()lastOK := time.Now()for {@@ -478,13 +481,13 @@ func renewDesktopSlot(case <-ctx.Done():returncase <-ticker.C:- ok, rerr := redislock.Renew(ctx, client, key, token, desktopSlotLease)+ ok, rerr := redislock.Renew(ctx, client, key, token, lease)if rerr != nil {if stderrors.Is(rerr, context.Canceled) && ctx.Err() != nil {return}logger.Warnf(ctx, "[sandbox-desktop] slot renew failed key=%s: %v", key, rerr)- if time.Since(lastOK) >= desktopSlotLease {+ if time.Since(lastOK) >= lease {cancelHold(rerr)return}