Skip to content

A self-hosted UPI & COD payment gateway with zero per-transaction platform fees, universal JavaScript checkout integration, dynamic QR payments, WhatsApp OTP authentication, and automated payment verification.

JavaScript

fix(mcp): validate webhook signature hex format and add regression test

ArunGupta15260fd47daec319
diff --git a/packages/youpi-mcp/src/__tests__/mcp-server.test.js b/packages/youpi-mcp/src/__tests__/mcp-server.test.js
index 5c22c72..1a9ee6b 100644
--- a/packages/youpi-mcp/src/__tests__/mcp-server.test.js
+++ b/packages/youpi-mcp/src/__tests__/mcp-server.test.js
@@ -62,6 +62,17 @@ describe('YouPI MCP Server', () => {
assert.equal(result.error, 'INVALID_SIGNATURE');
});
+ test('rejects malformed or non-hex webhook signature', async () => {
+ const result = verifyWebhookSignature({
+ rawPayload: '{"test":1}',
+ signature: 'sha256=not-a-valid-hex-signature!',
+ secret: 'test-secret'
+ });
+
+ assert.equal(result.valid, false);
+ assert.equal(result.error, 'INVALID_SIGNATURE_FORMAT');
+ });
+
test('rejects webhook timestamp beyond maxAgeSeconds', async () => {
const secret = 'test-secret-12345';
const payload = JSON.stringify({ event: 'SUCCESS' });
diff --git a/packages/youpi-mcp/src/tools.js b/packages/youpi-mcp/src/tools.js
index 43c184b..bf2f647 100644
--- a/packages/youpi-mcp/src/tools.js
+++ b/packages/youpi-mcp/src/tools.js
@@ -99,6 +99,9 @@ export function verifyWebhookSignature({ rawPayload, signature, secret, timestam
}
const sig = signature.startsWith('sha256=') ? signature.slice(7) : signature;
+ if (!/^[0-9a-fA-F]+$/.test(sig) || sig.length % 2 !== 0) {
+ return { valid: false, error: 'INVALID_SIGNATURE_FORMAT' };
+ }
const hmac = crypto.createHmac('sha256', secret);
hmac.update(rawPayload, 'utf8');
const expected = hmac.digest('hex');