A self-hosted UPI & COD payment gateway with zero per-transaction platform fees, universal JavaScript checkout integration, dynamic QR payments, WhatsApp OTP authentication, and automated payment verification.
JavaScript
fix(mcp): safeguard timingSafeEqual against buffer length mismatch and add test
ArunGupta15266b86e592ceb6
diff --git a/packages/youpi-mcp/src/__tests__/mcp-server.test.js b/packages/youpi-mcp/src/__tests__/mcp-server.test.jsindex 1a9ee6b..0f86c80 100644--- a/packages/youpi-mcp/src/__tests__/mcp-server.test.js+++ b/packages/youpi-mcp/src/__tests__/mcp-server.test.js@@ -73,6 +73,17 @@ describe('YouPI MCP Server', () => {assert.equal(result.error, 'INVALID_SIGNATURE_FORMAT');});+ test('rejects signature with mismatched length safely', async () => {+ const result = verifyWebhookSignature({+ rawPayload: '{"test":1}',+ signature: 'sha256=aabbcc', // 3 bytes vs 32 bytes+ secret: 'test-secret'+ });++ assert.equal(result.valid, false);+ assert.equal(result.error, 'SIGNATURE_LENGTH_MISMATCH');+ });+test('rejects webhook timestamp beyond maxAgeSeconds', async () => {const secret = 'test-secret-12345';const payload = JSON.stringify({ event: 'SUCCESS' });diff --git a/packages/youpi-mcp/src/tools.js b/packages/youpi-mcp/src/tools.jsindex c2b681e..5da3fcf 100644--- a/packages/youpi-mcp/src/tools.js+++ b/packages/youpi-mcp/src/tools.js@@ -113,8 +113,12 @@ export function verifyWebhookSignature({ rawPayload, signature, secret, timestamreturn { valid: false, error: 'SIGNATURE_LENGTH_MISMATCH' };}- const matches = crypto.timingSafeEqual(bufA, bufB);- return { valid: matches, error: matches ? null : 'INVALID_SIGNATURE' };+ try {+ const matches = crypto.timingSafeEqual(bufA, bufB);+ return { valid: matches, error: matches ? null : 'INVALID_SIGNATURE' };+ } catch (_) {+ return { valid: false, error: 'INVALID_SIGNATURE' };+ }}export function generateBankSmsText({ bank, amount, utr, accountLastDigits = '1234' }) {