Skip to content

A cross platform Audiobookshelf client for Android and iOS

Dart

Fix transcribing a bookmark failing on iPhone and iPad

Barnabas24ce12e6645b
diff --git a/packages/whisper_ggml_plus/ios/Classes/whisper_flutter_plus.cpp b/packages/whisper_ggml_plus/ios/Classes/whisper_flutter_plus.cpp
index 50d0a9c8..5fb80924 100644
--- a/packages/whisper_ggml_plus/ios/Classes/whisper_flutter_plus.cpp
+++ b/packages/whisper_ggml_plus/ios/Classes/whisper_flutter_plus.cpp
@@ -153,7 +153,11 @@ json transcribe(json jsonBody)
params.diarize = jsonBody["diarize"];
params.speed_up = jsonBody["speed_up"];
params.vad_mode = parse_vad_mode(jsonBody);
- params.vad_model_path = jsonBody.value("vad_model_path", std::string(""));
+ // Dart always sends the key and it is null whenever VAD is off, and
+ // value() only falls back for a MISSING key - a present null throws.
+ if (jsonBody.contains("vad_model_path") && jsonBody["vad_model_path"].is_string()) {
+ params.vad_model_path = jsonBody["vad_model_path"].get<std::string>();
+ }
json jsonResult;
jsonResult["@type"] = "transcribe";
diff --git a/packages/whisper_ggml_plus/macos/Classes/whisper_ggml.cpp b/packages/whisper_ggml_plus/macos/Classes/whisper_ggml.cpp
index a643b713..696ac925 100644
--- a/packages/whisper_ggml_plus/macos/Classes/whisper_ggml.cpp
+++ b/packages/whisper_ggml_plus/macos/Classes/whisper_ggml.cpp
@@ -146,7 +146,11 @@ json transcribe(json jsonBody)
params.diarize = jsonBody["diarize"];
params.speed_up = jsonBody["speed_up"];
params.vad_mode = parse_vad_mode(jsonBody);
- params.vad_model_path = jsonBody.value("vad_model_path", std::string(""));
+ // Dart always sends the key and it is null whenever VAD is off, and
+ // value() only falls back for a MISSING key - a present null throws.
+ if (jsonBody.contains("vad_model_path") && jsonBody["vad_model_path"].is_string()) {
+ params.vad_model_path = jsonBody["vad_model_path"].get<std::string>();
+ }
json jsonResult;
jsonResult["@type"] = "transcribe";