A cross platform Audiobookshelf client for Android and iOS
Dart
Improve download location permissions and error messages
Nathan Poulsona5b42941158c
diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xmlindex 322816f2..7ded2f48 100644--- a/android/app/src/main/AndroidManifest.xml+++ b/android/app/src/main/AndroidManifest.xml@@ -9,6 +9,10 @@<uses-permission android:name="android.permission.POST_NOTIFICATIONS"/><uses-permission android:name="android.permission.REQUEST_IGNORE_BATTERY_OPTIMIZATIONS"/>+ <!-- External storage write access (Android 9 and below) -->+ <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" android:maxSdkVersion="29"/>+ <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" android:maxSdkVersion="29"/>+<!-- Block permissions pulled in by dependencies --><uses-permission android:name="android.permission.READ_MEDIA_IMAGES" tools:node="remove"/><uses-permission android:name="android.permission.READ_MEDIA_VIDEO" tools:node="remove"/>diff --git a/lib/screens/settings_screen.dart b/lib/screens/settings_screen.dartindex 7351533c..032f2499 100644--- a/lib/screens/settings_screen.dart+++ b/lib/screens/settings_screen.dart@@ -1844,6 +1844,31 @@ class _SettingsScreenState extends State<SettingsScreen> {label: const Text('Choose folder'),onPressed: () async {Navigator.pop(ctx);+ // Request storage permission (needed on Android 9 and below).+ // On Android 10+, this permission is deprecated - we skip blocking+ // and let the write test below catch any actual access issues.+ if (Platform.isAndroid) {+ final status = await Permission.storage.status;+ if (status.isPermanentlyDenied) {+ if (mounted) {+ ScaffoldMessenger.of(context).showSnackBar(SnackBar(+ content: const Text('Storage permission permanently denied - enable it in app settings'),+ behavior: SnackBarBehavior.floating,+ shape: RoundedRectangleBorder(+ borderRadius: BorderRadius.circular(12)),+ action: SnackBarAction(+ label: 'Open Settings',+ onPressed: openAppSettings,+ ),+ ));+ }+ return;+ }+ if (!status.isGranted) {+ await Permission.storage.request();+ // Don't block - proceed regardless+ }+ }final result = await FilePicker.platform.getDirectoryPath(dialogTitle: 'Choose download folder',);diff --git a/lib/services/download_service.dart b/lib/services/download_service.dartindex f9c04d84..ee1fc7f7 100644--- a/lib/services/download_service.dart+++ b/lib/services/download_service.dart@@ -786,9 +786,13 @@ class DownloadService extends ChangeNotifier {} else {final isStorageFull = e.toString().contains('No space left') ||e.toString().contains('ENOSPC');+ final isPermissionDenied = e.toString().contains('Permission denied') ||+ e.toString().contains('error = 13');final errorMsg = isStorageFull? 'Not enough storage space'- : 'Download failed';+ : isPermissionDenied+ ? 'Permission denied - check download location in Settings'+ : 'Download failed';debugPrint('[Download] Error: $e');_downloads[itemId] = DownloadInfo(itemId: itemId,