A cross platform Audiobookshelf client for Android and iOS
Dart
Fix EQ silencing audio when band frequency exceeds Nyquist
Barnabasc0fa3ca5d17b
diff --git a/packages/just_audio/darwin/just_audio/Sources/just_audio/AudioEQProcessor.m b/packages/just_audio/darwin/just_audio/Sources/just_audio/AudioEQProcessor.mindex d16a83a6..9760af51 100644--- a/packages/just_audio/darwin/just_audio/Sources/just_audio/AudioEQProcessor.m+++ b/packages/just_audio/darwin/just_audio/Sources/just_audio/AudioEQProcessor.m@@ -116,15 +116,34 @@ static inline float processBiquad(BiquadCoeffs *c, BiquadDelay *d, float x) {static void rebuildCoefficients(TapContext *ctx) {float Fs = ctx->sampleRate;+ // Clamp band frequencies below Nyquist with 5% headroom. Computing a+ // peaking biquad at f0 >= Fs/2 puts the filter poles outside the unit+ // circle, the filter blows up, samples turn into NaN, and the output+ // goes silent. This was the root cause of "Red Rising plays but no+ // sound" reports - low-bitrate AAC m4b decodes to 22050Hz so the+ // 14kHz band tripped the instability.+ float maxBandHz = (Fs * 0.5f) * 0.95f;for (int i = 0; i < EQ_NUM_BANDS; i++) {float dBGain = (float)atomic_load_explicit(&sParams.bandLevels[i], memory_order_relaxed) / 100.0f;- ctx->coeffs[i] = peakingEQ(kBandFrequencies[i], dBGain, kDefaultQ, Fs);+ float bandHz = kBandFrequencies[i];+ if (bandHz >= maxBandHz) {+ // Above Nyquist - use unity (passthrough) so the filter is stable.+ BiquadCoeffs unity = {1.0f, 0.0f, 0.0f, 0.0f, 0.0f};+ ctx->coeffs[i] = unity;+ } else {+ ctx->coeffs[i] = peakingEQ(bandHz, dBGain, kDefaultQ, Fs);+ }}// Bass boost: low shelf at 120 Hz, gain 0-12 dB mapped from strength 0-1000int bassStrength = atomic_load_explicit(&sParams.bassBoostStrength, memory_order_relaxed);float bassdB = (float)bassStrength / 1000.0f * 12.0f;- ctx->bassCoeffs = lowShelf(120.0f, bassdB, Fs);+ if (120.0f >= maxBandHz) {+ BiquadCoeffs unity = {1.0f, 0.0f, 0.0f, 0.0f, 0.0f};+ ctx->bassCoeffs = unity;+ } else {+ ctx->bassCoeffs = lowShelf(120.0f, bassdB, Fs);+ }ctx->lastCoeffVersion = atomic_load_explicit(&sParams.coeffVersion, memory_order_relaxed);}diff --git a/pubspec.yaml b/pubspec.yamlindex 0b8a3be7..1e22fe77 100644--- a/pubspec.yaml+++ b/pubspec.yaml@@ -1,7 +1,7 @@name: absorbdescription: An Audiobookshelf Clientpublish_to: 'none'-version: 1.8.78+109+version: 1.8.78+110environment:sdk: '>=3.1.0 <4.0.0'