Skip to content

A cross platform Audiobookshelf client for Android and iOS

Dart

fix: Add backout and failure for socket reconnection

Morgan Crouchfc85f19f8daa
diff --git a/lib/providers/library_provider.dart b/lib/providers/library_provider.dart
index 69d93ad0..0952273f 100644
--- a/lib/providers/library_provider.dart
+++ b/lib/providers/library_provider.dart
@@ -703,7 +703,13 @@ class LibraryProvider extends ChangeNotifier {
}
void _softReconnectSocket() {
- if (!_socketSoftDisconnected || _manualOffline) return;
+ if (_manualOffline) return;
+ // If socket died on its own (reconnection exhausted), reset the flag
+ // so we can attempt a fresh connection.
+ if (!_socketSoftDisconnected && !SocketService().hasSocket) {
+ _socketSoftDisconnected = true;
+ }
+ if (!_socketSoftDisconnected) return;
_socketSoftDisconnected = false;
SocketService().softReconnect();
}
diff --git a/lib/services/socket_service.dart b/lib/services/socket_service.dart
index 7d8d946f..cd3afc19 100644
--- a/lib/services/socket_service.dart
+++ b/lib/services/socket_service.dart
@@ -11,6 +11,17 @@ class SocketService {
String? _serverUrl;
bool get isConnected => _socket?.connected ?? false;
+ bool get hasSocket => _socket != null;
+
+ /// Build socket.io options with capped reconnection to avoid
+ /// hammering an unreachable server (and draining battery).
+ Map<String, dynamic> _buildOptions() => IO.OptionBuilder()
+ .setTransports(['websocket'])
+ .enableReconnection()
+ .setReconnectionDelay(1000)
+ .setReconnectionDelayMax(30000)
+ .setReconnectionAttempts(5)
+ .build();
/// Called when the server pushes a progress update (cross-device sync).
void Function(Map<String, dynamic> progress)? onProgressUpdated;
@@ -37,10 +48,7 @@ class SocketService {
_serverUrl = serverUrl;
try {
- _socket = IO.io(serverUrl, IO.OptionBuilder()
- .setTransports(['websocket'])
- .enableReconnection()
- .build());
+ _socket = IO.io(serverUrl, _buildOptions());
// onConnect fires on initial connect AND every reconnect
_socket!.onConnect((_) {
@@ -122,6 +130,12 @@ class SocketService {
_socket!.onConnectError((err) {
debugPrint('[Socket] Connect error: $err');
});
+
+ _socket!.on('reconnect_failed', (_) {
+ debugPrint('[Socket] Reconnection attempts exhausted — giving up');
+ _socket?.dispose();
+ _socket = null;
+ });
} catch (e) {
debugPrint('[Socket] Failed to connect: $e');
_socket = null;
@@ -175,10 +189,7 @@ class SocketService {
debugPrint('[Socket] Soft reconnect');
try {
- _socket = IO.io(url, IO.OptionBuilder()
- .setTransports(['websocket'])
- .enableReconnection()
- .build());
+ _socket = IO.io(url, _buildOptions());
_socket!.onConnect((_) {
debugPrint('[Socket] Connected, sending auth');
@@ -230,6 +241,12 @@ class SocketService {
_socket!.onConnectError((err) {
debugPrint('[Socket] Connect error: $err');
});
+
+ _socket!.on('reconnect_failed', (_) {
+ debugPrint('[Socket] Reconnection attempts exhausted — giving up');
+ _socket?.dispose();
+ _socket = null;
+ });
} catch (e) {
debugPrint('[Socket] Failed to reconnect: $e');
_socket = null;