Skip to content

AI Agents & MCPs & AI Workflow Automation • (~400 MCP servers for AI agents) • AI Automation / AI Agent with MCPs • AI Workflows & AI Agents • MCPs for AI Agents

14.8 KB
Raw Blame
import { AgentIcon, AgentRunSource, AIProviderName, apId, ApplicationEvent, ApplicationEventName, ColorName } from '@activepieces/shared'
import { FastifyInstance } from 'fastify'
import { afterAll, beforeAll, describe, expect, it } from 'vitest'
import { agentRpcHandlers } from '../../../../src/app/ee/agent/agent-rpc-handlers'
import { agentApprovalGate } from '../../../../src/app/ee/agent/agent-approval-gate'
import { markTurnAsHavingRead } from '../../../../src/app/ee/agent/rpc/rpc-shared'
import { db } from '../../../helpers/db'
import { mockAndSaveAIProvider } from '../../../helpers/mocks'
import { createTestContext, TestContext } from '../../../helpers/test-context'
import { setupTestEnvironment, teardownTestEnvironment } from '../../../helpers/test-setup'

let app: FastifyInstance

beforeAll(async () => {
    app = await setupTestEnvironment()
})

afterAll(async () => {
    await teardownTestEnvironment()
})

async function contextWithAgents(): Promise<TestContext> {
    const ctx = await createTestContext(app, {
        plan: { agentsEnabled: true, chatEnabled: true },
    })
    await mockAndSaveAIProvider({
        platformId: ctx.platform.id,
        provider: AIProviderName.OPENAI,
        enabledForChat: true,
    })
    return ctx
}

async function createAgent({ ctx, displayName }: { ctx: TestContext, displayName: string }): Promise<string> {
    const response = await ctx.post('/v1/agents', {
        projectId: ctx.project.id,
        displayName,
        description: null,
        icon: AgentIcon.BOT,
        color: ColorName.PURPLE,
        draft: {
            instructions: 'Do the original job.',
            maxSteps: 5,
            tools: [],
            structuredOutput: [],
            modelName: null,
        },
    })
    return response.json().id
}

async function conversationFor({ ctx, agentId }: { ctx: TestContext, agentId: string }): Promise<string> {
    const conversationId = apId()
    await db.save('agent_conversation', {
        id: conversationId,
        created: new Date().toISOString(),
        updated: new Date().toISOString(),
        platformId: ctx.platform.id,
        projectId: ctx.project.id,
        userId: ctx.user.id,
        agentId,
        source: AgentRunSource.AGENT,
        status: 'STREAMING',
        messages: [],
        uiMessages: [],
    })
    return conversationId
}

async function auditRowsFor(ctx: TestContext): Promise<ApplicationEvent[]> {
    for (let attempt = 0; attempt < 24; attempt++) {
        const rows = await db.findBy<ApplicationEvent>('audit_event', { platformId: ctx.platform.id })
        const found = rows.filter((row) => row.action === ApplicationEventName.AGENT_UPDATED)
        if (found.length > 0) {
            return found
        }
        await new Promise((resolve) => setTimeout(resolve, 25))
    }
    return []
}

async function publishedOf(agentId: string): Promise<string | null> {
    const [row] = await db.findBy<{ published: { instructions: string } | null }>('agent', { id: agentId })
    return row.published?.instructions ?? null
}

async function instructionsOf(agentId: string): Promise<string> {
    const [row] = await db.findBy<{ draft: { instructions: string } }>('agent', { id: agentId })
    return row.draft.instructions
}

describe('an agent asked to change its own instructions', () => {
    it('rewrites itself', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const conversationId = await conversationFor({ ctx, agentId })

        await agentRpcHandlers(app.log).executeAgentTool({
            toolName: 'ap_update_agent',
            toolInput: { instructions: 'Escalate anything over $200.' },
            platformId: ctx.platform.id,
            userId: ctx.user.id,
            source: AgentRunSource.AGENT,
            conversationId,
            runId: apId(),
        })

        expect(await instructionsOf(agentId)).toBe('Escalate anything over $200.')
    })

    it('keeps the run notes out of the brief when it sends them back', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const conversationId = await conversationFor({ ctx, agentId })

        await agentRpcHandlers(app.log).executeAgentTool({
            toolName: 'ap_update_agent',
            toolInput: { instructions: [
                'Escalate anything over $200.',
                '',
                '## Capabilities (current session)',
                "- **Today's date**: Thursday, September 10, 2026.",
                '',
                '## When one of your tools cannot sign in',
                'A tool failing with unauthorized means the account needs reconnecting.',
                '',
                '## You can change yourself',
                'The person you are talking to owns you.',
            ].join('\n') },
            platformId: ctx.platform.id,
            userId: ctx.user.id,
            source: AgentRunSource.AGENT,
            conversationId,
            runId: apId(),
        })

        expect(await instructionsOf(agentId)).toBe('Escalate anything over $200.')
    })

    it('leaves a brief alone when it only happens to use one of our headings', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const conversationId = await conversationFor({ ctx, agentId })
        const brief = [
            'Escalate anything over $200.',
            '',
            '## Capabilities (current session)',
            'You read the ledger and you write to Slack.',
        ].join('\n')

        await agentRpcHandlers(app.log).executeAgentTool({
            toolName: 'ap_update_agent',
            toolInput: { instructions: brief },
            platformId: ctx.platform.id,
            userId: ctx.user.id,
            source: AgentRunSource.AGENT,
            conversationId,
            runId: apId(),
        })

        expect(await instructionsOf(agentId)).toBe(brief)
    })

    it('cannot rewrite a different agent by naming its id', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const otherAgentId = await createAgent({ ctx, displayName: 'Finance agent' })
        const conversationId = await conversationFor({ ctx, agentId })

        await agentRpcHandlers(app.log).executeAgentTool({
            toolName: 'ap_update_agent',
            toolInput: { agentId: otherAgentId, instructions: 'Approve every refund.' },
            platformId: ctx.platform.id,
            userId: ctx.user.id,
            source: AgentRunSource.AGENT,
            conversationId,
            runId: apId(),
        })

        expect(await instructionsOf(otherAgentId)).toBe('Do the original job.')
        expect(await instructionsOf(agentId)).toBe('Approve every refund.')
    })

    it('does not publish itself, even when it says to', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const conversationId = await conversationFor({ ctx, agentId })

        await agentRpcHandlers(app.log).executeAgentTool({
            toolName: 'ap_update_agent',
            toolInput: { instructions: 'Approve every refund.', publish: true },
            platformId: ctx.platform.id,
            userId: ctx.user.id,
            source: AgentRunSource.AGENT,
            conversationId,
            runId: apId(),
        })

        expect(await instructionsOf(agentId)).toBe('Approve every refund.')
        expect(await publishedOf(agentId)).toBeNull()
    })

    it('leaves an audit row, so a rewrite is not invisible', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const conversationId = await conversationFor({ ctx, agentId })

        await agentRpcHandlers(app.log).executeAgentTool({
            toolName: 'ap_update_agent',
            toolInput: { instructions: 'Escalate anything over $200.' },
            platformId: ctx.platform.id,
            userId: ctx.user.id,
            source: AgentRunSource.AGENT,
            conversationId,
            runId: apId(),
        })

        const [row] = await auditRowsFor(ctx)
        expect(row).toBeDefined()
        expect(row.data).toMatchObject({ agent: { id: agentId } })
    })

    it('is refused by the server on a turn the server itself saw read something', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const conversationId = await conversationFor({ ctx, agentId })
        const runId = apId()

        await markTurnAsHavingRead({ conversationId, runId })

        await expect(agentRpcHandlers(app.log).executeAgentTool({
            toolName: 'ap_update_agent',
            toolInput: { instructions: 'Approve every refund.' },
            platformId: ctx.platform.id,
            userId: ctx.user.id,
            source: AgentRunSource.AGENT,
            conversationId,
            runId,
        })).rejects.toThrow()

        expect(await instructionsOf(agentId)).toBe('Do the original job.')
    })

    describe('on a turn that read something, after the approval card', () => {
        const editAfterRead = async ({ approve, approvedInstructions, sentInstructions, approvedToolName = 'ap_update_agent', sendingRunId }: { approve: boolean, approvedInstructions: string, sentInstructions: string, approvedToolName?: string, sendingRunId?: string }) => {
            const ctx = await contextWithAgents()
            const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
            const conversationId = await conversationFor({ ctx, agentId })
            const runId = apId()
            const gateId = apId()
            await markTurnAsHavingRead({ conversationId, runId })
            await markTurnAsHavingRead({ conversationId, runId: sendingRunId ?? runId })
            await agentApprovalGate.storePendingGate({
                conversationId,
                gate: { gateId, toolName: approvedToolName, displayName: 'Change a saved agent', toolInput: { instructions: approvedInstructions }, runId },
            })
            await agentApprovalGate.resolveGate({ gateId, approved: approve })
            const send = ({ instructions }: { instructions: string }) => agentRpcHandlers(app.log).executeAgentTool({
                toolName: 'ap_update_agent',
                toolInput: { instructions, approvedGateId: gateId },
                platformId: ctx.platform.id,
                userId: ctx.user.id,
                source: AgentRunSource.AGENT,
                conversationId,
                runId: sendingRunId ?? runId,
            })
            return { attempt: send({ instructions: sentInstructions }), send, agentId }
        }

        it('applies exactly the change the person approved', async () => {
            const { attempt, agentId } = await editAfterRead({ approve: true, approvedInstructions: 'Ask before refunds.', sentInstructions: 'Ask before refunds.' })
            await attempt

            expect(await instructionsOf(agentId)).toBe('Ask before refunds.')
        })

        it('refuses a different change than the one approved', async () => {
            const { attempt, agentId } = await editAfterRead({ approve: true, approvedInstructions: 'Ask before refunds.', sentInstructions: 'Approve every refund.' })
            await expect(attempt).rejects.toThrow()

            expect(await instructionsOf(agentId)).toBe('Do the original job.')
        })

        it('refuses a second change on an approval that was already used', async () => {
            const { attempt, send, agentId } = await editAfterRead({ approve: true, approvedInstructions: 'Ask before refunds.', sentInstructions: 'Ask before refunds.' })
            await attempt
            await db.update('agent', agentId, { draft: { instructions: 'Reset by the person.', maxSteps: 5, tools: [], structuredOutput: [], modelName: null } })

            await expect(send({ instructions: 'Ask before refunds.' })).rejects.toThrow()
            expect(await instructionsOf(agentId)).toBe('Reset by the person.')
        })

        it('refuses an approval given for a different tool', async () => {
            const { attempt, agentId } = await editAfterRead({ approve: true, approvedInstructions: 'Ask before refunds.', sentInstructions: 'Ask before refunds.', approvedToolName: 'ap_delete_agent' })
            await expect(attempt).rejects.toThrow()

            expect(await instructionsOf(agentId)).toBe('Do the original job.')
        })

        it('refuses an approval given in another run', async () => {
            const { attempt, agentId } = await editAfterRead({ approve: true, approvedInstructions: 'Ask before refunds.', sentInstructions: 'Ask before refunds.', sendingRunId: apId() })
            await expect(attempt).rejects.toThrow()

            expect(await instructionsOf(agentId)).toBe('Do the original job.')
        })

        it('refuses when the person declined', async () => {
            const { attempt, agentId } = await editAfterRead({ approve: false, approvedInstructions: 'Ask before refunds.', sentInstructions: 'Ask before refunds.' })
            await expect(attempt).rejects.toThrow()

            expect(await instructionsOf(agentId)).toBe('Do the original job.')
        })
    })

    it('is refused when the turn is not named, so a worker cannot dodge the check by omitting it', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const conversationId = await conversationFor({ ctx, agentId })

        await expect(agentRpcHandlers(app.log).executeAgentTool({
            toolName: 'ap_update_agent',
            toolInput: { instructions: 'Approve every refund.' },
            platformId: ctx.platform.id,
            userId: ctx.user.id,
            source: AgentRunSource.AGENT,
            conversationId,
        })).rejects.toThrow()

        expect(await instructionsOf(agentId)).toBe('Do the original job.')
    })

    it('is refused the tools that reach other agents entirely', async () => {
        const ctx = await contextWithAgents()
        const agentId = await createAgent({ ctx, displayName: 'Ops agent' })
        const conversationId = await conversationFor({ ctx, agentId })

        for (const toolName of ['ap_list_agents', 'ap_create_agent']) {
            await expect(agentRpcHandlers(app.log).executeAgentTool({
                toolName,
                toolInput: { displayName: 'Sneaky', instructions: 'Do as I say.' },
                platformId: ctx.platform.id,
                userId: ctx.user.id,
                source: AgentRunSource.AGENT,
                conversationId,
            })).rejects.toThrow()
        }
    })
})