AI Agents & MCPs & AI Workflow Automation • (~400 MCP servers for AI agents) • AI Automation / AI Agent with MCPs • AI Workflows & AI Agents • MCPs for AI Agents
TypeScript ai-agentai-agent-toolsai-agentsai-agents-frameworkmcpmcp-servermcp-toolsmcpsn8n-alternativeno-code-automationworkflowworkflow-automationworkflows
fix(sandbox): code steps can import node: builtins again (#15980)
Chaker Atallah112cac0f2606
diff --git a/packages/server/sandbox/src/lib/utils/esbuild-build-options.ts b/packages/server/sandbox/src/lib/utils/esbuild-build-options.tsindex 3963fa1b306..6973c0b030a 100644--- a/packages/server/sandbox/src/lib/utils/esbuild-build-options.ts+++ b/packages/server/sandbox/src/lib/utils/esbuild-build-options.ts@@ -34,6 +34,9 @@ export function stepFolderResolvePlugin(rootDir: string): Plugin {if (args.kind === 'entry-point' || isBareSpecifier(args.path)) {return null}+ if (args.path.startsWith('node:')) {+ return { external: true }+ }if (/^[a-z][a-z0-9+.-]*:/i.test(args.path)) {return { errors: [{ text: IMPORT_OUT_OF_SCOPE_MESSAGE }] }}diff --git a/packages/server/sandbox/test/lib/utils/esbuild-build-options.test.ts b/packages/server/sandbox/test/lib/utils/esbuild-build-options.test.tsindex b5b0f24d539..fdf2413efda 100644--- a/packages/server/sandbox/test/lib/utils/esbuild-build-options.test.ts+++ b/packages/server/sandbox/test/lib/utils/esbuild-build-options.test.ts@@ -90,6 +90,22 @@ describe('stepFolderResolvePlugin', () => {expect(result.bundle).not.toContain(SECRET)})+ it('allows a node:-prefixed builtin import', async () => {+ const result = await compile({+ code: `import { createHash } from 'node:crypto'; export const code = async () => createHash('md5').update('x').digest('hex')`,+ })+ expect(result.built).toBe(true)+ expect(result.bundle).toContain('node:crypto')+ })++ it('still blocks non-node scheme imports', async () => {+ const result = await compile({+ code: `import s from 'file://${secretDir}/secret.js'; export const code = async () => ({ s })`,+ })+ expect(result.built).toBe(false)+ expect(result.error).toContain(IMPORT_OUT_OF_SCOPE_MESSAGE)+ })+it('allows a legitimate relative import inside the step folder', async () => {const result = await compile({code: `import s from './helper'; export const code = async () => ({ s })`,