Skip to content

AI Agents & MCPs & AI Workflow Automation • (~400 MCP servers for AI agents) • AI Automation / AI Agent with MCPs • AI Workflows & AI Agents • MCPs for AI Agents

fix(engine): match the legacy per-mode memory semantics for deno code steps (#16400)

Chaker Atallah52d5759bd638
diff --git a/packages/core/utils/src/lib/deno.ts b/packages/core/utils/src/lib/deno.ts
index 7788831efe4..fba714d0a92 100644
--- a/packages/core/utils/src/lib/deno.ts
+++ b/packages/core/utils/src/lib/deno.ts
@@ -287,7 +287,7 @@ async function spawnDeno({ entry, permissions, cwd, memoryLimitMb, allowReadPath
'--no-lock',
'--no-remote',
resolveNodeModules ? '--node-modules-dir=manual' : '--no-npm',
- `--v8-flags=--max-old-space-size=${memoryLimitMb}`,
+ ...(memoryLimitMb === null ? [] : [`--v8-flags=--max-old-space-size=${memoryLimitMb}`]),
...toPermissionFlags({ permissions, tmpDir: os.tmpdir() }),
...permissions.includes(DenoPermission.ALL) ? [] : allowReadPaths.map((path) => `--allow-read=${path}`),
entryArg,
@@ -495,7 +495,7 @@ type DenoProgramParams = {
body: string
permissions: DenoPermission[]
cwd?: string
- memoryLimitMb?: number
+ memoryLimitMb?: number | null
allowReadPaths?: string[]
resolveNodeModules?: boolean
env?: Record<string, string>
@@ -545,7 +545,7 @@ type SpawnDenoParams = {
entry: string | { body: string }
permissions: DenoPermission[]
cwd?: string
- memoryLimitMb: number
+ memoryLimitMb: number | null
allowReadPaths: string[]
resolveNodeModules: boolean
env: Record<string, string>
diff --git a/packages/server/engine/src/lib/core/code/code-sandbox.ts b/packages/server/engine/src/lib/core/code/code-sandbox.ts
index 52916d04fde..1630a212372 100644
--- a/packages/server/engine/src/lib/core/code/code-sandbox.ts
+++ b/packages/server/engine/src/lib/core/code/code-sandbox.ts
@@ -15,29 +15,37 @@ const loadV8IsolateSandbox = async (): Promise<CodeSandbox> => {
return v8IsolateCodeSandboxModule.v8IsolateCodeSandbox
}
-const loadDenoCodeSandbox = async (permissions: DenoPermission[]): Promise<CodeSandbox> => {
+const loadDenoCodeSandbox = async ({ permissions, codeStepMemoryLimitMb }: LoadDenoCodeSandboxParams): Promise<CodeSandbox> => {
const denoCodeSandboxModule = await import('./deno-code-sandbox')
- return denoCodeSandboxModule.denoCodeSandbox(permissions)
+ return denoCodeSandboxModule.denoCodeSandbox({ permissions, codeStepMemoryLimitMb })
}
+const CODE_ONLY_SANDBOX_MEMORY_LIMIT_MB = 128
+
const loadCodeSandbox = async ({ useDeno }: { useDeno: boolean }): Promise<CodeSandbox> => {
const denoLoaders = {
- [ExecutionMode.UNSANDBOXED]: () => loadDenoCodeSandbox([
- DenoPermission.WRITE_TMP,
- DenoPermission.READ_TMP,
- DenoPermission.NET,
- DenoPermission.ENV,
- DenoPermission.SYS,
- ]),
- [ExecutionMode.SANDBOX_PROCESS]: () => loadDenoCodeSandbox([
- DenoPermission.WRITE_TMP,
- DenoPermission.READ_TMP,
- DenoPermission.NET,
- DenoPermission.ENV,
- DenoPermission.SYS,
- ]),
- [ExecutionMode.SANDBOX_CODE_ONLY]: () => loadDenoCodeSandbox([]),
- [ExecutionMode.SANDBOX_CODE_AND_PROCESS]: () => loadDenoCodeSandbox([]),
+ [ExecutionMode.UNSANDBOXED]: () => loadDenoCodeSandbox({
+ permissions: [
+ DenoPermission.WRITE_TMP,
+ DenoPermission.READ_TMP,
+ DenoPermission.NET,
+ DenoPermission.ENV,
+ DenoPermission.SYS,
+ ],
+ codeStepMemoryLimitMb: null,
+ }),
+ [ExecutionMode.SANDBOX_PROCESS]: () => loadDenoCodeSandbox({
+ permissions: [
+ DenoPermission.WRITE_TMP,
+ DenoPermission.READ_TMP,
+ DenoPermission.NET,
+ DenoPermission.ENV,
+ DenoPermission.SYS,
+ ],
+ codeStepMemoryLimitMb: null,
+ }),
+ [ExecutionMode.SANDBOX_CODE_ONLY]: () => loadDenoCodeSandbox({ permissions: [], codeStepMemoryLimitMb: CODE_ONLY_SANDBOX_MEMORY_LIMIT_MB }),
+ [ExecutionMode.SANDBOX_CODE_AND_PROCESS]: () => loadDenoCodeSandbox({ permissions: [], codeStepMemoryLimitMb: CODE_ONLY_SANDBOX_MEMORY_LIMIT_MB }),
}
const legacyLoaders = {
@@ -72,3 +80,8 @@ export const initCodeSandbox = async ({ useDeno }: { useDeno: boolean }): Promis
return instances[kind]
}
+
+type LoadDenoCodeSandboxParams = {
+ permissions: DenoPermission[]
+ codeStepMemoryLimitMb: number | null
+}
diff --git a/packages/server/engine/src/lib/core/code/deno-code-sandbox.ts b/packages/server/engine/src/lib/core/code/deno-code-sandbox.ts
index 2a6cf08a142..cc36cc70fa0 100644
--- a/packages/server/engine/src/lib/core/code/deno-code-sandbox.ts
+++ b/packages/server/engine/src/lib/core/code/deno-code-sandbox.ts
@@ -9,7 +9,7 @@ import { CodeSandbox } from './code-sandbox-common'
export { DenoPermission } from '@activepieces/core-utils'
-export function denoCodeSandbox(permissions: DenoPermission[]): CodeSandbox {
+export function denoCodeSandbox({ permissions, codeStepMemoryLimitMb }: DenoCodeSandboxParams): CodeSandbox {
const sandbox: CodeSandbox = {
async runCodeModule({ codeFilePath, inputs }) {
// Deno compares permission paths after resolving symlinks (e.g. macOS
@@ -61,6 +61,7 @@ export function denoCodeSandbox(permissions: DenoPermission[]): CodeSandbox {
`,
permissions,
cwd: stepDir,
+ memoryLimitMb: codeStepMemoryLimitMb,
allowReadPaths: [stepDir],
resolveNodeModules: true,
env: buildPropagatedEnv(permissions),
@@ -188,3 +189,8 @@ type LiveScriptSession = {
session: DenoSession
sentGlobals: Map<string, SentGlobal>
}
+
+type DenoCodeSandboxParams = {
+ permissions: DenoPermission[]
+ codeStepMemoryLimitMb: number | null
+}
diff --git a/packages/server/engine/test/core/code/code-sandbox-error-contract.test.ts b/packages/server/engine/test/core/code/code-sandbox-error-contract.test.ts
index 040e5844a3d..8c89c61eb13 100644
--- a/packages/server/engine/test/core/code/code-sandbox-error-contract.test.ts
+++ b/packages/server/engine/test/core/code/code-sandbox-error-contract.test.ts
@@ -11,7 +11,7 @@ import { v8IsolateCodeSandbox } from '../../../src/lib/core/code/v8-isolate-code
const SANDBOXES: SandboxUnderTest[] = [
{ name: 'noOp', sandbox: noOpCodeSandbox, wrap: (body) => `exports.code = async () => { ${body} }`, extension: 'js' },
{ name: 'v8Isolate', sandbox: v8IsolateCodeSandbox, wrap: (body) => `exports.code = async () => { ${body} }`, extension: 'js' },
- { name: 'deno', sandbox: denoCodeSandbox([DenoPermission.NET]), wrap: (body) => `export const code = async () => { ${body} }`, extension: 'ts' },
+ { name: 'deno', sandbox: denoCodeSandbox({ permissions: [DenoPermission.NET], codeStepMemoryLimitMb: null }), wrap: (body) => `export const code = async () => { ${body} }`, extension: 'ts' },
]
const CHILD_PROCESS_SANDBOXES = SANDBOXES.filter((entry) => entry.name !== 'v8Isolate')
diff --git a/packages/server/engine/test/core/code/deno-code-sandbox.test.ts b/packages/server/engine/test/core/code/deno-code-sandbox.test.ts
index 0db6ee24e53..c6900e7d756 100644
--- a/packages/server/engine/test/core/code/deno-code-sandbox.test.ts
+++ b/packages/server/engine/test/core/code/deno-code-sandbox.test.ts
@@ -20,7 +20,7 @@ beforeAll(async () => {
// The boundary suite asserts the locked profile (the code-only modes) — an
// empty permission set, so beyond the step-dir read grant every syscall
// (fs/net/env/run) is denied.
- denoCodeSandbox = denoModule.denoCodeSandbox([])
+ denoCodeSandbox = denoModule.denoCodeSandbox({ permissions: [], codeStepMemoryLimitMb: 128 })
stepDir = await mkdtemp(path.join(tmpdir(), 'ap-deno-test-'))
})
@@ -57,7 +57,7 @@ describe('denoCodeSandbox permission boundary', () => {
})
it('gives each run its own DENO_DIR and removes it after the run', async () => {
- const envSandbox = denoModule.denoCodeSandbox([denoModule.DenoPermission.ENV])
+ const envSandbox = denoModule.denoCodeSandbox({ permissions: [denoModule.DenoPermission.ENV], codeStepMemoryLimitMb: 128 })
const codeFilePath = path.join(stepDir, 'index.ts')
await writeFile(codeFilePath, 'export const code = async () => Deno.env.get(\'DENO_DIR\')')
@@ -76,7 +76,7 @@ describe('denoCodeSandbox permission boundary', () => {
const originalMode = process.env.AP_EXECUTION_MODE
try {
process.env.AP_EXECUTION_MODE = 'SANDBOX_CODE_ONLY'
- const envSandbox = denoModule.denoCodeSandbox([denoModule.DenoPermission.ENV])
+ const envSandbox = denoModule.denoCodeSandbox({ permissions: [denoModule.DenoPermission.ENV], codeStepMemoryLimitMb: 128 })
const codeFilePath = path.join(stepDir, 'index.ts')
await writeFile(codeFilePath, 'export const code = async () => Deno.env.get(\'DENO_DIR\')')
@@ -96,7 +96,7 @@ describe('denoCodeSandbox permission boundary', () => {
})
it('with the ENV permission exposes only PATH, never the engine env', async () => {
- const envSandbox = denoModule.denoCodeSandbox([denoModule.DenoPermission.ENV])
+ const envSandbox = denoModule.denoCodeSandbox({ permissions: [denoModule.DenoPermission.ENV], codeStepMemoryLimitMb: 128 })
const codeFilePath = path.join(stepDir, 'index.ts')
await writeFile(codeFilePath, `export const code = async () => ({ keys: Object.keys(Deno.env.toObject()).sort(), missing: process.env.AP_EXECUTION_MODE ?? null })`)
const result = await envSandbox.runCodeModule({ codeFilePath, inputs: {} })
@@ -112,7 +112,7 @@ describe('denoCodeSandbox permission boundary', () => {
const codeFilePath = path.join(stepDir, 'index.ts')
await writeFile(codeFilePath, `export const code = async () => ({ secret: process.env.MY_PROPAGATED_SECRET ?? null, unlisted: process.env.MY_UNLISTED_SECRET ?? null, keys: Object.keys(Deno.env.toObject()).sort() })`)
- const envSandbox = denoModule.denoCodeSandbox([denoModule.DenoPermission.ENV])
+ const envSandbox = denoModule.denoCodeSandbox({ permissions: [denoModule.DenoPermission.ENV], codeStepMemoryLimitMb: 128 })
const result = await envSandbox.runCodeModule({ codeFilePath, inputs: {} })
expect(result).toEqual({ secret: 'propagated-value', unlisted: null, keys: ['DENO_DIR', 'MY_PROPAGATED_SECRET', 'PATH'] })
@@ -460,7 +460,7 @@ describe('denoCodeSandbox permission profiles', () => {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
async function runWith(permissions: any[], source: string): Promise<unknown> {
- const sandbox = denoModule.denoCodeSandbox(permissions)
+ const sandbox = denoModule.denoCodeSandbox({ permissions, codeStepMemoryLimitMb: 128 })
const codeFilePath = path.join(dir, 'index.ts')
await writeFile(codeFilePath, source)
return sandbox.runCodeModule({ codeFilePath, inputs: {} })
@@ -496,3 +496,27 @@ describe('denoCodeSandbox permission profiles', () => {
})
})
})
+
+describe('deno code sandbox memory limit', () => {
+ const ALLOCATE_240_MB = `export const code = async () => {
+ const chunks = [];
+ for (let i = 0; i < 30; i++) {
+ chunks.push(new Array(1_000_000).fill(i));
+ }
+ return chunks.length;
+ }`
+
+ it('kills a step whose heap exceeds the configured cap', async () => {
+ const capped = denoModule.denoCodeSandbox({ permissions: [], codeStepMemoryLimitMb: 128 })
+ const codeFilePath = path.join(stepDir, 'index.ts')
+ await writeFile(codeFilePath, ALLOCATE_240_MB)
+ await expectRejection(capped.runCodeModule({ codeFilePath, inputs: {} }), /signal SIG/)
+ })
+
+ it('runs the same step when codeStepMemoryLimitMb is null', async () => {
+ const uncapped = denoModule.denoCodeSandbox({ permissions: [], codeStepMemoryLimitMb: null })
+ const codeFilePath = path.join(stepDir, 'index.ts')
+ await writeFile(codeFilePath, ALLOCATE_240_MB)
+ await expect(uncapped.runCodeModule({ codeFilePath, inputs: {} })).resolves.toBe(30)
+ })
+})