AI Agents & MCPs & AI Workflow Automation • (~400 MCP servers for AI agents) • AI Automation / AI Agent with MCPs • AI Workflows & AI Agents • MCPs for AI Agents
TypeScript ai-agentai-agent-toolsai-agentsai-agents-frameworkmcpmcp-servermcp-toolsmcpsn8n-alternativeno-code-automationworkflowworkflow-automationworkflows
fix(chat): changing your role refreshes your suggested use cases (#17167)
Hazem Adel745a3c353ae6
diff --git a/packages/server/api/src/app/ee/agent/personalization/chat-personalization-service.ts b/packages/server/api/src/app/ee/agent/personalization/chat-personalization-service.tsindex 72060d80b5e..e12918df0d8 100644--- a/packages/server/api/src/app/ee/agent/personalization/chat-personalization-service.ts+++ b/packages/server/api/src/app/ee/agent/personalization/chat-personalization-service.ts@@ -156,17 +156,15 @@ export const chatPersonalizationService = (log: FastifyBaseLogger) => ({async upsertUserScope({ platformId, userId, companyRow, role }: { platformId: string, userId: string, companyRow: ChatPersonalization, role: string | null }): Promise<ChatPersonalizationView> {const researchToken = apId()const userRow = await findRow({ platformId, userId })+ if (!isNil(userRow) && keepsCurrentRow({ userRow, role })) {+ return this.getEffectiveView({ platformId, userId })+ }+ const refreshesReadyCards = userRow?.status === ChatPersonalizationStatus.READY+ const researchBlockedForReadyCards = refreshesReadyCards && !await guardsAllowResearch({ platformId, log })+ if (researchBlockedForReadyCards) {+ return this.getEffectiveView({ platformId, userId })+ }if (!isNil(userRow)) {- const fresh = Date.now() - new Date(userRow.updated).getTime() < RESEARCH_STALENESS_TIMEOUT_MS- const terminal = [ChatPersonalizationStatus.READY, ChatPersonalizationStatus.SKIPPED].includes(userRow.status)- const roleChanged = !isNil(role) && role !== userRow.role- const keepCurrentRow = !hasOptedOut(userRow) && (terminal || (fresh && !roleChanged))- if (keepCurrentRow) {- if (roleChanged) {- await personalizationRepo().update({ platformId, userId }, { role })- }- return this.getEffectiveView({ platformId, userId })- }await personalizationRepo().update({ platformId, userId }, { status: ChatPersonalizationStatus.PENDING, researchToken, domain: companyRow.domain, companyText: companyRow.companyText, ...spreadIfDefined('role', role) })}else {@@ -186,7 +184,7 @@ export const chatPersonalizationService = (log: FastifyBaseLogger) => ({return this.getEffectiveView({ platformId, userId })}}- const allowed = await guardsAllowResearch({ platformId, log })+ const allowed = refreshesReadyCards || await guardsAllowResearch({ platformId, log })if (!allowed) {await personalizationRepo().update({ platformId, userId }, { status: ChatPersonalizationStatus.SKIPPED })return this.getEffectiveView({ platformId, userId })@@ -385,3 +383,10 @@ export const chatPersonalizationService = (log: FastifyBaseLogger) => ({},})++function keepsCurrentRow({ userRow, role }: { userRow: ChatPersonalization, role: string | null }): boolean {+ const fresh = Date.now() - new Date(userRow.updated).getTime() < RESEARCH_STALENESS_TIMEOUT_MS+ const terminal = [ChatPersonalizationStatus.READY, ChatPersonalizationStatus.SKIPPED].includes(userRow.status)+ const roleChanged = !isNil(role) && role !== userRow.role+ return !hasOptedOut(userRow) && !roleChanged && (terminal || fresh)+}diff --git a/packages/server/api/test/integration/ee/agent/chat-personalization-opt-out.test.ts b/packages/server/api/test/integration/ee/agent/chat-personalization-opt-out.test.tsindex fd8f8c06ac2..0c939288bad 100644--- a/packages/server/api/test/integration/ee/agent/chat-personalization-opt-out.test.ts+++ b/packages/server/api/test/integration/ee/agent/chat-personalization-opt-out.test.ts@@ -2,12 +2,26 @@ import { apId } from '@activepieces/core-utils'import { ChatPersonalizationScope, ChatPersonalizationStatus } from '@activepieces/shared'import { FastifyInstance } from 'fastify'import { IsNull } from 'typeorm'-import { afterAll, beforeAll, describe, expect, it } from 'vitest'+import { afterAll, beforeAll, describe, expect, it, vi } from 'vitest'import { chatPersonalizationService } from '../../../../src/app/ee/agent/personalization/chat-personalization-service'import { db } from '../../../helpers/db'import { createTestContext, TestContext } from '../../../helpers/test-context'import { setupTestEnvironment, teardownTestEnvironment } from '../../../helpers/test-setup'+const { mockEnqueueResearchJob, mockGuardsAllowResearch } = vi.hoisted(() => ({+ mockEnqueueResearchJob: vi.fn().mockResolvedValue(undefined),+ mockGuardsAllowResearch: vi.fn().mockResolvedValue(true),+}))++vi.mock('../../../../src/app/ee/agent/personalization/personalization-research', async (importOriginal) => {+ const original = await importOriginal<typeof import('../../../../src/app/ee/agent/personalization/personalization-research')>()+ return {+ ...original,+ guardsAllowResearch: mockGuardsAllowResearch,+ enqueueResearchJob: mockEnqueueResearchJob,+ }+})+let app: FastifyInstancebeforeAll(async () => {@@ -93,10 +107,55 @@ describe('clearing chat personalization', () => {})})+describe('changing the role on finished personalization', () => {+ it('starts new research for the new role instead of keeping the old cards', async () => {+ const ctx = await createTestContext(app)+ await saveResearchedCompany(ctx)+ await saveReadyUserRow({ ctx, role: 'Sales' })++ await service().upsert({ platformId: ctx.platform.id, userId: ctx.user.id, role: 'Engineer', personalize: true })++ const userRow = await db.findOneByOrFail<{ role: string, status: string, researchToken: string | null }>('chat_personalization', { platformId: ctx.platform.id, userId: ctx.user.id })+ expect(userRow.role).toBe('Engineer')+ expect(userRow.status).toBe(ChatPersonalizationStatus.PENDING)+ expect(mockEnqueueResearchJob).toHaveBeenCalledWith(expect.objectContaining({ userId: ctx.user.id, role: 'Engineer', researchToken: userRow.researchToken }))+ })++ it('keeps the current cards when research cannot run, and retries the same role later', async () => {+ const ctx = await createTestContext(app)+ await saveResearchedCompany(ctx)+ await saveReadyUserRow({ ctx, role: 'Sales' })+ mockGuardsAllowResearch.mockResolvedValueOnce(false)++ await service().upsert({ platformId: ctx.platform.id, userId: ctx.user.id, role: 'Engineer', personalize: true })+ const blocked = await db.findOneByOrFail<{ role: string, status: string, useCases: unknown }>('chat_personalization', { platformId: ctx.platform.id, userId: ctx.user.id })+ expect(blocked).toMatchObject({ role: 'Sales', status: ChatPersonalizationStatus.READY, useCases: USE_CASES })++ await service().upsert({ platformId: ctx.platform.id, userId: ctx.user.id, role: 'Engineer', personalize: true })+ const retried = await db.findOneByOrFail<{ role: string, status: string }>('chat_personalization', { platformId: ctx.platform.id, userId: ctx.user.id })+ expect(retried).toMatchObject({ role: 'Engineer', status: ChatPersonalizationStatus.PENDING })+ })+})+function service() {return chatPersonalizationService(app.log)}+async function saveReadyUserRow({ ctx, role }: { ctx: TestContext, role: string }): Promise<void> {+ await db.save('chat_personalization', {+ id: apId(),+ platformId: ctx.platform.id,+ userId: ctx.user.id,+ domain: 'acme.com',+ companyText: null,+ role,+ status: ChatPersonalizationStatus.READY,+ researchToken: null,+ profile: null,+ useCases: USE_CASES,+ })+}+async function saveResearchedCompany(ctx: TestContext): Promise<void> {await db.save('chat_personalization', {id: apId(),