Skip to content

AI Agents & MCPs & AI Workflow Automation • (~400 MCP servers for AI agents) • AI Automation / AI Agent with MCPs • AI Workflows & AI Agents • MCPs for AI Agents

fix(tables): deleting a column no longer blanks or overwrites the other columns (#15709)

Bartosz Majewski9654b6a1bec6
diff --git a/packages/web/src/features/tables/stores/store/ap-tables-client-state.tsx b/packages/web/src/features/tables/stores/store/ap-tables-client-state.tsx
index b6b47e0712b..8e3eb663fd6 100644
--- a/packages/web/src/features/tables/stores/store/ap-tables-client-state.tsx
+++ b/packages/web/src/features/tables/stores/store/ap-tables-client-state.tsx
@@ -212,7 +212,15 @@ export const createApTableStore = (
return {
records: state.records.map((record) => ({
...record,
- values: record.values.filter((_, index) => index !== fieldIndex),
+ values: record.values
+ .filter((cell) => cell.fieldIndex !== fieldIndex)
+ .map((cell) => ({
+ ...cell,
+ fieldIndex:
+ cell.fieldIndex > fieldIndex
+ ? cell.fieldIndex - 1
+ : cell.fieldIndex,
+ })),
})),
fields: state.fields.filter((_, index) => index !== fieldIndex),
};
diff --git a/packages/web/test/features/tables/delete-middle-field.test.tsx b/packages/web/test/features/tables/delete-middle-field.test.tsx
new file mode 100644
index 00000000000..4602c73f7e2
--- /dev/null
+++ b/packages/web/test/features/tables/delete-middle-field.test.tsx
@@ -0,0 +1,198 @@
+/** @vitest-environment jsdom */
+import {
+ Field,
+ FieldType,
+ PopulatedRecord,
+ Table,
+ TableAutomationStatus,
+} from '@activepieces/shared';
+import { render } from '@testing-library/react';
+import { useEffect } from 'react';
+import { describe, expect, it, vi } from 'vitest';
+
+import {
+ CellProvider,
+ useCellContext,
+} from '@/features/tables/components/cell-context';
+import { mapRecordsToRows } from '@/features/tables/components/table-columns';
+import {
+ createApTableStore,
+ type ApTableStore,
+} from '@/features/tables/stores/store/ap-tables-client-state';
+
+const harness = vi.hoisted(() => ({
+ store: undefined as undefined | ApTableStore,
+}));
+
+vi.mock('@/features/tables/stores/store/ap-tables-server-state', () => ({
+ createServerState: (
+ _table: unknown,
+ fields: unknown[],
+ records: unknown[],
+ ) => ({
+ deleteField: vi.fn(),
+ createField: vi.fn(),
+ fields,
+ records,
+ }),
+}));
+
+vi.mock('@/features/tables/components/ap-table-state-provider', () => ({
+ useTableState: <T,>(selector: (state: unknown) => T) =>
+ selector(harness.store!.getState()),
+}));
+
+const table: Table = {
+ id: 'table-1',
+ created: '2026-09-16T00:00:00.000Z',
+ updated: '2026-09-16T00:00:00.000Z',
+ name: 'Table',
+ projectId: 'project-1',
+ externalId: 'table-1',
+ status: TableAutomationStatus.ENABLED,
+ trigger: null,
+};
+
+const buildField = (id: string, name: string, position: number): Field => ({
+ id,
+ created: '2026-09-16T00:00:00.000Z',
+ updated: '2026-09-16T00:00:00.000Z',
+ name,
+ externalId: id,
+ type: FieldType.TEXT,
+ tableId: table.id,
+ projectId: table.projectId,
+ position,
+});
+
+const buildCell = (value: string, fieldName: string) => ({
+ created: '2026-09-16T00:00:00.000Z',
+ updated: '2026-09-16T00:00:00.000Z',
+ value,
+ fieldName,
+});
+
+const fields = [
+ buildField('field-a', 'A', 0),
+ buildField('field-b', 'B', 1),
+ buildField('field-c', 'C', 2),
+];
+
+const records: PopulatedRecord[] = [
+ {
+ id: 'record-1',
+ created: '2026-09-16T00:00:00.000Z',
+ updated: '2026-09-16T00:00:00.000Z',
+ tableId: table.id,
+ projectId: table.projectId,
+ cells: {
+ 'field-c': buildCell('c-value', 'C'),
+ 'field-a': buildCell('a-value', 'A'),
+ 'field-b': buildCell('b-value', 'B'),
+ },
+ },
+];
+
+const createStore = () => createApTableStore(table, fields, records);
+
+const cellsByIndex = (store: ApTableStore) =>
+ [...store.getState().records[0].values].sort(
+ (a, b) => a.fieldIndex - b.fieldIndex,
+ );
+
+describe('deleteField remaps surviving cells (ENG-537)', () => {
+ it('keeps the values of every column to the right of the deleted one', () => {
+ const store = createStore();
+
+ store.getState().deleteField(1);
+
+ expect(store.getState().fields.map((field) => field.name)).toEqual([
+ 'A',
+ 'C',
+ ]);
+ expect(cellsByIndex(store)).toEqual([
+ { fieldIndex: 0, value: 'a-value' },
+ { fieldIndex: 1, value: 'c-value' },
+ ]);
+ });
+
+ it('still renders the shifted column in the grid', () => {
+ const store = createStore();
+
+ store.getState().deleteField(1);
+
+ const state = store.getState();
+ const [row] = mapRecordsToRows(state.records, state.fields);
+ expect(row['field-a']).toBe('a-value');
+ expect(row['field-c']).toBe('c-value');
+ });
+
+ it('does not off-by-one when the last column is deleted', () => {
+ const store = createStore();
+
+ store.getState().deleteField(2);
+
+ expect(store.getState().fields.map((field) => field.name)).toEqual([
+ 'A',
+ 'B',
+ ]);
+ expect(cellsByIndex(store)).toEqual([
+ { fieldIndex: 0, value: 'a-value' },
+ { fieldIndex: 1, value: 'b-value' },
+ ]);
+ });
+
+ it('leaves no index collision when a column is added after a middle delete', () => {
+ const store = createStore();
+
+ store.getState().deleteField(1);
+ store
+ .getState()
+ .createField({ uuid: 'field-d', name: 'D', type: FieldType.TEXT });
+
+ expect(cellsByIndex(store).map((cell) => cell.fieldIndex)).toEqual([
+ 0, 1, 2,
+ ]);
+ });
+
+ it('does not overwrite the shifted column when a cell is edited afterwards', () => {
+ const store = createStore();
+ harness.store = store;
+ store.getState().deleteField(1);
+
+ const updateRecord = vi.fn();
+ store.setState({ updateRecord });
+
+ function Editor() {
+ const { handleCellChange } = useCellContext();
+ useEffect(() => {
+ handleCellChange('a-edited');
+ // eslint-disable-next-line react-hooks/exhaustive-deps
+ }, []);
+ return null;
+ }
+
+ render(
+ <CellProvider
+ rowIdx={0}
+ columnIdx={0}
+ fieldType={FieldType.TEXT}
+ value="a-value"
+ isEditing={true}
+ setIsEditing={() => undefined}
+ handleCellChange={() => undefined}
+ disabled={false}
+ containerRef={{ current: null }}
+ >
+ <Editor />
+ </CellProvider>,
+ );
+
+ expect(updateRecord).toHaveBeenCalledWith(0, {
+ values: [
+ { fieldIndex: 0, value: 'a-edited' },
+ { fieldIndex: 1, value: 'c-value' },
+ ],
+ });
+ });
+});