AI Agents & MCPs & AI Workflow Automation • (~400 MCP servers for AI agents) • AI Automation / AI Agent with MCPs • AI Workflows & AI Agents • MCPs for AI Agents
TypeScript ai-agentai-agent-toolsai-agentsai-agents-frameworkmcpmcp-servermcp-toolsmcpsn8n-alternativeno-code-automationworkflowworkflow-automationworkflows
feat(job-broker): log pickup-wait metric on dequeue (#16794)
lina-alomaribcf9eab02f07
diff --git a/packages/server/api/src/app/workers/job-queue/job-broker.ts b/packages/server/api/src/app/workers/job-queue/job-broker.tsindex 9c5aafbc1af..fccbd820231 100644--- a/packages/server/api/src/app/workers/job-queue/job-broker.ts+++ b/packages/server/api/src/app/workers/job-queue/job-broker.ts@@ -107,7 +107,7 @@ async function tryDequeue(worker: BullMQWorker, queueName: string, log: FastifyBreturn tryDequeue(worker, queueName, log)}- log.info({ queueName, job: { id: job.id }, jobName: job.name }, '[jobBroker#tryDequeue] Dequeued job')+ log.info({ queueName, job: { id: job.id, pickupWaitMs: (job.processedOn ?? Date.now()) - job.timestamp - (job.opts.delay ?? 0) }, jobName: job.name }, '[jobBroker#tryDequeue] Dequeued job')const originalSchemaVersion = (job.data as Record<string, unknown>).schemaVersionconst migratedData = await jobMigrations(log).apply(job.data)diff --git a/packages/server/api/test/unit/app/workers/job-queue/job-broker.test.ts b/packages/server/api/test/unit/app/workers/job-queue/job-broker.test.tsindex b247816b4e0..adcd5696479 100644--- a/packages/server/api/test/unit/app/workers/job-queue/job-broker.test.ts+++ b/packages/server/api/test/unit/app/workers/job-queue/job-broker.test.ts@@ -65,6 +65,8 @@ function createMockJob(id: string, data?: Record<string, unknown>, deferredFailuname: `job-name-${id}`,data: { ...validExecuteFlowJobData, ...data },attemptsMade: 0,+ timestamp: 1_000,+ processedOn: 1_050,opts: { attempts: 2 },deferredFailure,moveToDelayed: vi.fn().mockResolvedValue(undefined),@@ -242,4 +244,49 @@ describe('tryDequeue', () => {expect(result).toBeNull()expect(mockWorker.getNextJob).toHaveBeenCalledTimes(1)})++ it('should log pickupWaitMs as the time from creation to pickup for an immediate job', async () => {+ const job = createMockJob('job-immediate')+ vi.mocked(mockWorker.getNextJob).mockResolvedValueOnce(job)+ mockPreDispatch.mockResolvedValueOnce({ verdict: InterceptorVerdict.ALLOW })++ await tryDequeue(mockWorker, 'test-queue', mockLog)++ expect(mockLog.info).toHaveBeenCalledWith(+ expect.objectContaining({ job: { id: 'job-immediate', pickupWaitMs: 50 } }),+ '[jobBroker#tryDequeue] Dequeued job',+ )+ })++ it('should exclude the scheduled delay from pickupWaitMs', async () => {+ const job = createMockJob('job-delayed')+ job.opts.delay = 3_600_000+ job.processedOn = 3_601_050+ vi.mocked(mockWorker.getNextJob).mockResolvedValueOnce(job)+ mockPreDispatch.mockResolvedValueOnce({ verdict: InterceptorVerdict.ALLOW })++ await tryDequeue(mockWorker, 'test-queue', mockLog)++ expect(mockLog.info).toHaveBeenCalledWith(+ expect.objectContaining({ job: { id: 'job-delayed', pickupWaitMs: 50 } }),+ '[jobBroker#tryDequeue] Dequeued job',+ )+ })++ it('should fall back to the current time when processedOn is missing', async () => {+ vi.useFakeTimers({ toFake: ['Date'] })+ vi.setSystemTime(1_200)+ const job = createMockJob('job-no-processed-on')+ job.processedOn = undefined+ vi.mocked(mockWorker.getNextJob).mockResolvedValueOnce(job)+ mockPreDispatch.mockResolvedValueOnce({ verdict: InterceptorVerdict.ALLOW })++ await tryDequeue(mockWorker, 'test-queue', mockLog)+ vi.useRealTimers()++ expect(mockLog.info).toHaveBeenCalledWith(+ expect.objectContaining({ job: { id: 'job-no-processed-on', pickupWaitMs: 200 } }),+ '[jobBroker#tryDequeue] Dequeued job',+ )+ })})