AI Agents & MCPs & AI Workflow Automation • (~400 MCP servers for AI agents) • AI Automation / AI Agent with MCPs • AI Workflows & AI Agents • MCPs for AI Agents
TypeScript ai-agentai-agent-toolsai-agentsai-agents-frameworkmcpmcp-servermcp-toolsmcpsn8n-alternativeno-code-automationworkflowworkflow-automationworkflows
chore(engine): tidy app webhook trigger guard
KhaledR57c7d897533048
diff --git a/packages/server/engine/src/lib/helper/trigger-helper.ts b/packages/server/engine/src/lib/helper/trigger-helper.tsindex 0d6417fd80a..d87f84a208c 100644--- a/packages/server/engine/src/lib/helper/trigger-helper.ts+++ b/packages/server/engine/src/lib/helper/trigger-helper.ts@@ -226,7 +226,7 @@ export const triggerHelper = {if (verifiedError) {throw verifiedError}- if (isNil(verified)) {+ if (verified !== true) {throw new Error('Webhook is not verified')}}diff --git a/packages/server/engine/test/helper/trigger-helper-app-webhook-verify.test.ts b/packages/server/engine/test/helper/trigger-helper-app-webhook-verify.test.tsnew file mode 100644index 00000000000..cbc72449206--- /dev/null+++ b/packages/server/engine/test/helper/trigger-helper-app-webhook-verify.test.ts@@ -0,0 +1,114 @@+import { TriggerStrategy } from '@activepieces/pieces-framework'+import { ExecuteTriggerResponse, FlowVersionState, TriggerHookType } from '@activepieces/shared'+import { beforeEach, describe, expect, it, Mock, vi } from 'vitest'++const { mockGetPieceAndTriggerOrThrow } = vi.hoisted(() => ({+ mockGetPieceAndTriggerOrThrow: vi.fn(),+}))+vi.mock('../../src/lib/helper/piece-loader', () => ({+ pieceLoader: {+ getPieceAndTriggerOrThrow: mockGetPieceAndTriggerOrThrow,+ },+}))++import { EngineConstants, ResolvedExecuteTriggerOperation } from '../../src/lib/handler/context/engine-constants'+import { triggerHelper } from '../../src/lib/helper/trigger-helper'++function makeRunOperation(): ResolvedExecuteTriggerOperation<TriggerHookType.RUN> {+ return {+ hookType: TriggerHookType.RUN,+ test: false,+ webhookUrl: 'http://127.0.0.1:3000/api/v1/webhooks/flow-1',+ appWebhookUrl: 'http://127.0.0.1:3000/api/v1/app-events/piece-under-test',+ webhookSecret: 'app-webhook-secret',+ triggerPayload: {+ body: { event: 'forged' },+ rawBody: '{"event":"forged"}',+ headers: { 'x-signature': 'not-a-valid-signature' },+ queryParams: {},+ },+ flowVersion: {+ id: 'flow-version-1',+ flowId: 'flow-1',+ state: FlowVersionState.LOCKED,+ trigger: {+ name: 'trigger',+ type: 'PIECE_TRIGGER',+ valid: true,+ displayName: 'App event',+ settings: {+ pieceName: '@activepieces/piece-under-test',+ pieceVersion: '1.0.0',+ triggerName: 'new_event',+ input: {},+ propertySettings: {},+ },+ },+ },+ projectId: 'project-1',+ platformId: 'platform-1',+ engineToken: 'engine-token',+ internalApiUrl: 'http://127.0.0.1:3000/api/',+ publicApiUrl: 'http://127.0.0.1:4200/api/',+ timeoutInSeconds: 30,+ } as unknown as ResolvedExecuteTriggerOperation<TriggerHookType.RUN>+}++function mockAppWebhookPiece({ verify }: { verify: (() => unknown) | undefined }): { run: Mock } {+ const run = vi.fn().mockResolvedValue([{ event: 'forged' }])+ mockGetPieceAndTriggerOrThrow.mockResolvedValue({+ piece: {+ auth: undefined,+ events: verify === undefined ? undefined : { verify, parseAndReply: vi.fn() },+ },+ pieceTrigger: {+ type: TriggerStrategy.APP_WEBHOOK,+ props: {},+ requireAuth: false,+ run,+ },+ })+ return { run }+}++async function executeRun(): Promise<ExecuteTriggerResponse<TriggerHookType>> {+ const params = makeRunOperation()+ return triggerHelper.executeTrigger({ params, constants: EngineConstants.fromExecuteTriggerInput(params) })+}++describe('APP_WEBHOOK signature verification gate', () => {+ beforeEach(() => {+ mockGetPieceAndTriggerOrThrow.mockReset()+ })++ it('rejects the event when verify returns false', async () => {+ const { run } = mockAppWebhookPiece({ verify: () => false })+ await expect(executeRun()).rejects.toThrow('Webhook is not verified')+ expect(run).not.toHaveBeenCalled()+ })++ it('rejects the event when verify returns undefined', async () => {+ const { run } = mockAppWebhookPiece({ verify: () => undefined })+ await expect(executeRun()).rejects.toThrow('Webhook is not verified')+ expect(run).not.toHaveBeenCalled()+ })++ it('rejects the event when verify returns a truthy value that is not true', async () => {+ const { run } = mockAppWebhookPiece({ verify: () => 'true' })+ await expect(executeRun()).rejects.toThrow('Webhook is not verified')+ expect(run).not.toHaveBeenCalled()+ })++ it('rejects the event when the piece has no verify handler', async () => {+ const { run } = mockAppWebhookPiece({ verify: undefined })+ await expect(executeRun()).rejects.toThrow('Webhook is not verified')+ expect(run).not.toHaveBeenCalled()+ })++ it('runs the trigger when verify returns true', async () => {+ const { run } = mockAppWebhookPiece({ verify: () => true })+ const response = await executeRun()+ expect(run).toHaveBeenCalledTimes(1)+ expect(response).toEqual({ output: [{ event: 'forged' }] })+ })+})