Skip to content

AI Agents & MCPs & AI Workflow Automation • (~400 MCP servers for AI agents) • AI Automation / AI Agent with MCPs • AI Workflows & AI Agents • MCPs for AI Agents

fix(worker): treat an empty AP_SANDBOX_MEMORY_LIMIT as unset (#16887)

Othman Abu Ajamiehcba7b8dd5153
diff --git a/packages/server/worker/src/lib/worker.ts b/packages/server/worker/src/lib/worker.ts
index 968dd1a88e8..a5930de5b2b 100644
--- a/packages/server/worker/src/lib/worker.ts
+++ b/packages/server/worker/src/lib/worker.ts
@@ -431,7 +431,7 @@ async function fetchAndStoreSettings(sock: Socket): Promise<void> {
response.EXECUTION_MODE = localExecutionMode
}
const localSandboxMemoryLimit = system.get(WorkerSystemProp.SANDBOX_MEMORY_LIMIT)
- if (!isNil(localSandboxMemoryLimit)) {
+ if (!isNil(localSandboxMemoryLimit) && localSandboxMemoryLimit !== '') {
if (!/^[1-9]\d*$/.test(localSandboxMemoryLimit)) {
throw new Error(`AP_SANDBOX_MEMORY_LIMIT must be a positive integer in KB. Got: ${localSandboxMemoryLimit}`)
}
diff --git a/packages/server/worker/test/lib/worker-settings-override.test.ts b/packages/server/worker/test/lib/worker-settings-override.test.ts
index 0508f7fef15..79f563698d1 100644
--- a/packages/server/worker/test/lib/worker-settings-override.test.ts
+++ b/packages/server/worker/test/lib/worker-settings-override.test.ts
@@ -209,6 +209,15 @@ describe('worker settings override', () => {
expect(stored.SANDBOX_MEMORY_LIMIT).toBe('524288')
}, 10_000)
+ it('empty local AP_SANDBOX_MEMORY_LIMIT keeps server-provided limit', async () => {
+ process.env.AP_SANDBOX_MEMORY_LIMIT = ''
+ const serverSettings = buildWorkerSettingsResponse({ SANDBOX_MEMORY_LIMIT: '524288' })
+ await connectAndWaitForSettings(serverSettings)
+
+ const stored = mockWorkerSettingsSet.mock.calls[0][0] as WorkerSettingsResponse
+ expect(stored.SANDBOX_MEMORY_LIMIT).toBe('524288')
+ }, 10_000)
+
it.each(['invalid', '2097152KB', '0', '-1'])('invalid local AP_SANDBOX_MEMORY_LIMIT %s throws', async (value) => {
process.env.AP_SANDBOX_MEMORY_LIMIT = value
const serverSettings = buildWorkerSettingsResponse()